Smalltalk › Pharo › Pharo Smalltalk Developers

Fwd: [squeak-dev] Fix to OCompletion for Pharo 1.1

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Mariano Martinez Peck

Fwd: [squeak-dev] Fix to OCompletion for Pharo 1.1

---------- Forwarded message ----------
From: DeNigris Sean <[hidden email]>
Date: Fri, Apr 23, 2010 at 6:01 AM
Subject: [squeak-dev] Fix to OCompletion for Pharo 1.1
To: [hidden email]

My email to Romain Robbes (with the address on squeaksource) was returned. Can someone pass this along...

OCompletionTable class >> initializeWithPackages
Changed FillInTheBlank to FillInTheBlankMorph.
(The former has no request: initialAnswer:).

Thanks.

Sean

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

OCompletionTable class-initializeWithPackages.st (1K) Download Attachment

Romain Robbes-2

Re: [squeak-dev] Fix to OCompletion for Pharo 1.1

Sean,

Thanks for the fix!

(and Mariano for forwarding the mail! I fixed my squeaksource address).

I'm wondering though, if in the long term re-introducing a reference to the specific Morph class is a good idea. So I made a similar fix,

using "UIManager default" instead of FillInTheBlank.

The fix is in oCompletion version 58 on squeaksource.

Romain

On Apr 23, 2010, at 7:40 AM, Mariano Martinez Peck wrote:

---------- Forwarded message ----------
From: DeNigris Sean <[hidden email]>
Date: Fri, Apr 23, 2010 at 6:01 AM
Subject: [squeak-dev] Fix to OCompletion for Pharo 1.1
To: [hidden email]

My email to Romain Robbes (with the address on squeaksource) was returned. Can someone pass this along...

OCompletionTable class >> initializeWithPackages
Changed FillInTheBlank to FillInTheBlankMorph.
(The former has no request: initialAnswer:).

Thanks.
Sean

<OCompletionTable class-initializeWithPackages.st>

Romain Robbes

http://romain.robb.es

[hidden email]

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Stéphane Ducasse

Re: Fwd: [squeak-dev] Fix to OCompletion for Pharo 1.1

In reply to this post by Mariano Martinez Peck

Pay attention FillInTheBlank does not exist anymore in 1.1

Stef

On Apr 23, 2010, at 1:40 PM, Mariano Martinez Peck wrote:

>
>
> ---------- Forwarded message ----------
> From: DeNigris Sean <[hidden email]>
> Date: Fri, Apr 23, 2010 at 6:01 AM
> Subject: [squeak-dev] Fix to OCompletion for Pharo 1.1
> To: [hidden email]
>
>
> My email to Romain Robbes (with the address on squeaksource) was returned. Can someone pass this along...
>
> OCompletionTable class >> initializeWithPackages
> Changed FillInTheBlank to FillInTheBlankMorph.
> (The former has no request: initialAnswer:).
>
> Thanks.
> Sean
>
>
>
>
>
>
> <OCompletionTable class-initializeWithPackages.st>_______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Henrik Sperre Johansen

Re: Fwd: [squeak-dev] Fix to OCompletion for Pharo 1.1

UIManager default request: initialAnswer: which Romain replaced it
with, works in both though :)

Cheers,
Henry

Den 23. apr. 2010 kl. 19.36 skrev Stéphane Ducasse <[hidden email]
r>:

> Pay attention FillInTheBlank does not exist anymore in 1.1
>
> Stef
>
> On Apr 23, 2010, at 1:40 PM, Mariano Martinez Peck wrote:
>
>>
>>
>> ---------- Forwarded message ----------
>> From: DeNigris Sean <[hidden email]>
>> Date: Fri, Apr 23, 2010 at 6:01 AM
>> Subject: [squeak-dev] Fix to OCompletion for Pharo 1.1
>> To: [hidden email]
>>
>>
>> My email to Romain Robbes (with the address on squeaksource) was
>> returned. Can someone pass this along...
>>
>> OCompletionTable class >> initializeWithPackages
>> Changed FillInTheBlank to FillInTheBlankMorph.
>> (The former has no request: initialAnswer:).
>>
>> Thanks.
>> Sean
>>
>>
>>
>>
>>
>>
>> <OCompletionTable class-
>> initializeWithPackages.st>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Stéphane Ducasse

Re: Fwd: [squeak-dev] Fix to OCompletion for Pharo 1.1

Yes this was more a message to Sean.

Stef

On Apr 23, 2010, at 7:43 PM, Henrik Johansen wrote:

> UIManager default request: initialAnswer: which Romain replaced it with, works in both though :)
>
> Cheers,
> Henry
>
> Den 23. apr. 2010 kl. 19.36 skrev Stéphane Ducasse <[hidden email]>:
>
>> Pay attention FillInTheBlank does not exist anymore in 1.1
>>
>> Stef
>>
>> On Apr 23, 2010, at 1:40 PM, Mariano Martinez Peck wrote:
>>
>>>
>>>
>>> ---------- Forwarded message ----------
>>> From: DeNigris Sean <[hidden email]>
>>> Date: Fri, Apr 23, 2010 at 6:01 AM
>>> Subject: [squeak-dev] Fix to OCompletion for Pharo 1.1
>>> To: [hidden email]
>>>
>>>
>>> My email to Romain Robbes (with the address on squeaksource) was returned. Can someone pass this along...
>>>
>>> OCompletionTable class >> initializeWithPackages
>>> Changed FillInTheBlank to FillInTheBlankMorph.
>>> (The former has no request: initialAnswer:).
>>>
>>> Thanks.
>>> Sean
>>>
>>>
>>>
>>>
>>>
>>>
>>> <OCompletionTable class-initializeWithPackages.st>_______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Sean P. DeNigris

Re: Fwd: [squeak-dev] Fix to OCompletion for Pharo 1.1

Administrator

In reply to this post by Stéphane Ducasse

Stéphane Ducasse wrote

Pay attention FillInTheBlank does not exist anymore in 1.1

Ha ha, yes that was kind of the point of the fix ;-) FillInTheBlankMorph works in 1.1-11317.

Or, maybe you meant the comment '(The former has no request: initialAnswer:).' - since FillInTheBlank returns an UndefinedObject, then it does indeed not have that method, lol.

Sean

Cheers,
Sean