GLMAction and PharoShortcut

> Le 12/02/2017 à 11:53, Ben Coman a écrit :
>>
>> Well spotted.  They should be consistent.  I guess the next questions  
>> are;
>> * Does Glamour convert cross platform Meta-x definitions to platform
>> specific in its rendering? Or are the Ctrl-xx hard coded?
>
> GLMAction comes with a method to render a print representation of shor
> tcut, but it is not its responsibility to do so. It is the short cut
> responsibility, so other widget can also use the same and consistent
> print representation.
>
> The responsability should go to instance of KMModifiedKeyCombination,
> not sure about that though.
>
> The way the modifier is selected in the GLamour looks strange, why not
> using the modifier instance?
>
>
>> * If the former, can Spec be made to do the same conversion for its
>> rendering?
>> * Or do we prefer to refer to the general Meta-x throughout the UI?
>
>
> The way short cuts are rendered in menu or tool tip is not consistent.
> In Nautilus you have for example: 'Ctrl + A', in debugger it is rendered
> 'ctrl+a' for Ctrl-a or 'ctrl+shift+a' for Ctrl-A.
> In playground you can see both depending on you are viewing a menu or a
> button tool tip.
>
> Now I see another place where short cut gets a print representation:
> MorphicMenuItemAdapter>>shortcutText
>
>
>

> For the record we were discussing with denis to have a hierarchy of
> command each one encapsulating its
> shortcut and other.
> Now it should work for calypso and we will remove Nautilus in 70. But
> the problem is all the places
> where shortcuts are hardcoded and we will have to work on them.
>
> Now I'm not saying that we should not do anything now to fix the current
> problem.
> I just mention our current thoughts.

>
> Hilaire
>
> Le 12/02/2017 à 18:51, stepharong a écrit :
>> For the record we were discussing with denis to have a hierarchy of
>> command each one encapsulating its
>> shortcut and other.
>> Now it should work for calypso and we will remove Nautilus in 70. But
>> the problem is all the places
>> where shortcuts are hardcoded and we will have to work on them.
>>
>> Now I'm not saying that we should not do anything now to fix the current
>> problem.
>> I just mention our current thoughts.
>

> Hi,
>
> While writing these tooltips for the debugger, it seems to me some
> refactoring is needed in the use of Pharo shortcut:
> https://pharo.fogbugz.com/f/cases/19684/GLMAction-and-PharoShortcut-need-refactoring
>
> because the current situation to have Glamour tk rendering short cut as
> 'Ctrl-A' then Spec as 'Meta-A'
>
> Any opinion on the topic.
>
> Hilaire
>
> --
> Dr. Geo
> http://drgeo.eu
>
>

> Hi,
>
> Good catch. Indeed GLMAction>>#shortcutAsString should go to the keymap object.
>
> Apart from the inconsistencies that you mention, there is in my view
> another one. For example, in the debugger in the context menu of the
> stack modifiers are displayed using special characters (at least on
> mac). In tooltips they are display using Shift, Meta, Ctrl, etc.
> Right now the logic for printing shortcuts that way is in
> ToggleMenuItemShortcut>>#owner:keyText: and it's a bit complicated to
> reuse. See GTSpotterCategoryTitleBrick>>#setShortcutBrickTextFor: for
> an example.
>
> Cheers,
> Andrei