Smalltalk › Frameworks & Tools › Moose

GLMTabulator bug?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Usman Bhatti

GLMTabulator bug?

It seems that GLMTabulator when creating rows, does not take into account size of the container into which rows are placed. The bottom row surpasses the size of its container by the amount of the size specified for the top row and it is not completely visible. Here is a script that shows the problem.

|tab|

tab := GLMTabulator new.

tab column: [ :col |

col

row: #first size: 80;

row: #second;

row: #third size: 100].

tab transmit to: #first; andShow: [:a | a dropDownList display: [:x | 1 to: x ] ].

tab transmit to: #second; andShow: [:a | a list display: [:x | 1 to: x ] ].tab transmit to: #third; andShow: [:a | a list display: [:x | 1 to: x ] ].

tab openOn: 10

I know the specifying size as span shows correctly the tree rows but then droplistMorph get resized awkwardly, and size works better for the widget.

Is this a known issue?

usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Andrei Chis

Re: GLMTabulator bug?

Yes, it's a bug.

It seems that the offset of the last pane does not get properly computed if the last pane has a fixed size and there is at least another pane with a fixed size.

I'll look for a fix.

Cheers,

Andrei

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Andrei Chis

Re: GLMTabulator bug?

Hi Usman,

Your example should work now.

There is still a problem in the renderer if your tabulator ends with multiple rows/columns that have a fixes size. (https://code.google.com/p/moose-technology/issues/detail?id=1083)

Let me know if you run into this issue.

Cheers,

Andrei

On Wed, Jul 23, 2014 at 5:44 PM, Andrei Chis <[hidden email]> wrote:

Yes, it's a bug.
It seems that the offset of the last pane does not get properly computed if the last pane has a fixed size and there is at least another pane with a fixed size.

I'll look for a fix.

Cheers,
Andrei

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba-2

Re: GLMTabulator bug?

Indeed it is a problem, and it is a known issue:

https://code.google.com/p/moose-technology/issues/detail?id=1083

Doru

On Wed, Jul 23, 2014 at 6:07 PM, Andrei Chis <[hidden email]> wrote:

Hi Usman,

Your example should work now.
There is still a problem in the renderer if your tabulator ends with multiple rows/columns that have a fixes size. (https://code.google.com/p/moose-technology/issues/detail?id=1083)

Let me know if you run into this issue.

Cheers,
Andrei

On Wed, Jul 23, 2014 at 5:44 PM, Andrei Chis <[hidden email]> wrote:

Yes, it's a bug.
It seems that the offset of the last pane does not get properly computed if the last pane has a fixed size and there is at least another pane with a fixed size.

I'll look for a fix.

Cheers,
Andrei

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba-2

Re: GLMTabulator bug?

Sorry. Wrong pasting :)

https://code.google.com/p/moose-technology/issues/detail?id=1039

Thanks, Andrei!

Doru

On Wed, Jul 23, 2014 at 7:38 PM, Tudor Girba <[hidden email]> wrote:

Indeed it is a problem, and it is a known issue:
https://code.google.com/p/moose-technology/issues/detail?id=1083

Doru

On Wed, Jul 23, 2014 at 6:07 PM, Andrei Chis <[hidden email]> wrote:

Hi Usman,

Your example should work now.
There is still a problem in the renderer if your tabulator ends with multiple rows/columns that have a fixes size. (https://code.google.com/p/moose-technology/issues/detail?id=1083)

Let me know if you run into this issue.

Cheers,
Andrei

On Wed, Jul 23, 2014 at 5:44 PM, Andrei Chis <[hidden email]> wrote:

Yes, it's a bug.
It seems that the offset of the last pane does not get properly computed if the last pane has a fixed size and there is at least another pane with a fixed size.

I'll look for a fix.

Cheers,
Andrei

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every thing has its own flow"

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Usman Bhatti

Re: GLMTabulator bug?

In reply to this post by Andrei Chis

Tx Andrei for looking into this problem.

Yes, my example works with your fix and the rows heights are computed correctly.

However, when we do not provide the size for the last row, it appears that row size exceeds the container (column) size (height). So, to reproduce you need to remove the size of the third pane to see the problem:

|tab|

tab := GLMTabulator new.

tab column: [ :col |

col

row: #first size: 80;

row: #second;

row: #third ].

tab transmit to: #first; andShow: [:a | a dropDownList display: [:x | 1 to: x ] ].

tab transmit to: #second; andShow: [:a | a list display: [:x | 1 to: x ] ].tab transmit to: #third; andShow: [:a | a list display: [:x | 1 to: x ] ].

tab openOn: 10

usman

On Wed, Jul 23, 2014 at 6:07 PM, Andrei Chis <[hidden email]> wrote:

Hi Usman,

Your example should work now.
There is still a problem in the renderer if your tabulator ends with multiple rows/columns that have a fixes size. (https://code.google.com/p/moose-technology/issues/detail?id=1083)

Let me know if you run into this issue.

Cheers,
Andrei

On Wed, Jul 23, 2014 at 5:44 PM, Andrei Chis <[hidden email]> wrote:

Yes, it's a bug.
It seems that the offset of the last pane does not get properly computed if the last pane has a fixed size and there is at least another pane with a fixed size.

I'll look for a fix.

Cheers,
Andrei

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Andrei Chis

Re: GLMTabulator bug?

I see the problem.

I have a fix for this particular problem but I'm not sure why the current solution doesn't work.

I'll look more into it.

Cheers,

Andrei

On Wed, Jul 23, 2014 at 8:35 PM, Usman Bhatti <[hidden email]> wrote:

Tx Andrei for looking into this problem.
Yes, my example works with your fix and the rows heights are computed correctly.

However, when we do not provide the size for the last row, it appears that row size exceeds the container (column) size (height). So, to reproduce you need to remove the size of the third pane to see the problem:

|tab|
tab := GLMTabulator new.
tab column: [ :col |
col
row: #first size: 80;

row: #second;
row: #third ].
tab transmit to: #first; andShow: [:a | a dropDownList display: [:x | 1 to: x ] ].

tab transmit to: #second; andShow: [:a | a list display: [:x | 1 to: x ] ].tab transmit to: #third; andShow: [:a | a list display: [:x | 1 to: x ] ].
tab openOn: 10

usman

On Wed, Jul 23, 2014 at 6:07 PM, Andrei Chis <[hidden email]> wrote:

Hi Usman,

Your example should work now.
There is still a problem in the renderer if your tabulator ends with multiple rows/columns that have a fixes size. (https://code.google.com/p/moose-technology/issues/detail?id=1083)

Let me know if you run into this issue.

Cheers,
Andrei

On Wed, Jul 23, 2014 at 5:44 PM, Andrei Chis <[hidden email]> wrote:

Yes, it's a bug.
It seems that the offset of the last pane does not get properly computed if the last pane has a fixed size and there is at least another pane with a fixed size.

I'll look for a fix.

Cheers,
Andrei

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev