Smalltalk › Frameworks & Tools › Moose

GLMTreePresentation filtering roots only

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Usman Bhatti

GLMTreePresentation filtering roots only

Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.

usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Usman Bhatti

Re: GLMTreePresentation filtering roots only

Here is a working version if someone's interested.

I would like to commit on a bug fix branch for Moose 5.0 (may be with a specific postfix) and not in the main branch to have it in Moose 5.0.

regards.

On Fri, Mar 6, 2015 at 10:42 AM, Usman Bhatti <[hidden email]> wrote:

Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.
usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Glamour-Presentations-usmanbhatti.167.mcz (39K) Download Attachment

Glamour-Morphic-Widgets-usmanbhatti.154.mcz (75K) Download Attachment

Usman Bhatti

Re: GLMTreePresentation filtering roots only

Example:

| finder |

finder := GLMFinder new.

finder show: [:a |

a list

title: 'List';

beMultiple;

filterOn: [:text :each | each asString = text ];

helpMessage: 'Enter a filtering request (e.g., "each > $f")'.

a tree

title: 'Tree';

filterOn: [:text :each | each asString = text ];

filterRootsOnly: true;

children: [:item :all :level | level < 2 ifTrue: [#(a b)] ifFalse: [#()]]].

finder openOn: ($a to: $z)

On Tue, Mar 10, 2015 at 5:22 PM, Usman Bhatti <[hidden email]> wrote:

Here is a working version if someone's interested.
I would like to commit on a bug fix branch for Moose 5.0 (may be with a specific postfix) and not in the main branch to have it in Moose 5.0.

regards.

On Fri, Mar 6, 2015 at 10:42 AM, Usman Bhatti <[hidden email]> wrote:
Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.
usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba-2

Re: GLMTreePresentation filtering roots only

In reply to this post by Usman Bhatti

Hi,

We do not have a branch for Moose 5.0. For Moose, we only have one repository.

And Moose 5.1 will be released soon after Pharo.

Cheers,

Doru

On Tue, Mar 10, 2015 at 5:22 PM, Usman Bhatti <[hidden email]> wrote:

Here is a working version if someone's interested.
I would like to commit on a bug fix branch for Moose 5.0 (may be with a specific postfix) and not in the main branch to have it in Moose 5.0.

regards.

On Fri, Mar 6, 2015 at 10:42 AM, Usman Bhatti <[hidden email]> wrote:
Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.
usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Usman Bhatti

Re: GLMTreePresentation filtering roots only

Ok then I'll keep it in another repo temporarily and commit on the main branch when we move to 5.1.

On Tue, Mar 10, 2015 at 6:09 PM, Tudor Girba <[hidden email]> wrote:

Hi,

We do not have a branch for Moose 5.0. For Moose, we only have one repository.

And Moose 5.1 will be released soon after Pharo.

Cheers,
Doru

On Tue, Mar 10, 2015 at 5:22 PM, Usman Bhatti <[hidden email]> wrote:
Here is a working version if someone's interested.
I would like to commit on a bug fix branch for Moose 5.0 (may be with a specific postfix) and not in the main branch to have it in Moose 5.0.

regards.

On Fri, Mar 6, 2015 at 10:42 AM, Usman Bhatti <[hidden email]> wrote:
Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.
usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Nicolas Anquetil

Re: GLMTreePresentation filtering roots only

Damien Cassou once instructed me on branching in Monticello:
---

it is just a question of naming your commit that opens a new branch:

https://ci.inria.fr/pharo-contribution/job/PharoForTheEnterprise/lastSuccessfulBuild/artifact/Conventions/Conventions.pier.html

---

but the link seems to be down

so here it goes
If you have a package Famix-Core

then you commit your change has Famix-Core.MyBranch

It generates a mcz with a name looking like:
Famix-Core.MyBranch-UsmanBhathi.532
which parent will be
Famix-Core-UsmanBhathi.531

I used it a couple of times and it works fine.

nicolas

On 11/03/2015 09:13, Usman Bhatti wrote:

Ok then I'll keep it in another repo temporarily and commit on the main branch when we move to 5.1.

On Tue, Mar 10, 2015 at 6:09 PM, Tudor Girba <[hidden email]> wrote:

Hi,

We do not have a branch for Moose 5.0. For Moose, we only have one repository.

And Moose 5.1 will be released soon after Pharo.

Cheers,

Doru

On Tue, Mar 10, 2015 at 5:22 PM, Usman Bhatti <[hidden email]> wrote:

Here is a working version if someone's interested.
I would like to commit on a bug fix branch for Moose 5.0 (may be with a specific postfix) and not in the main branch to have it in Moose 5.0.

regards.

On Fri, Mar 6, 2015 at 10:42 AM, Usman Bhatti <[hidden email]> wrote:

Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.

usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba-2

Re: GLMTreePresentation filtering roots only

Sure. Saving the Monticello version is not an issue. The main problem is that you would also have to manage the configuration, and this will be a manual and error-prone process.

Cheers,

Doru

On Thu, Mar 12, 2015 at 1:11 PM, Nicolas Anquetil <[hidden email]> wrote:

Damien Cassou once instructed me on branching in Monticello:
---
it is just a question of naming your commit that opens a new branch:

https://ci.inria.fr/pharo-contribution/job/PharoForTheEnterprise/lastSuccessfulBuild/artifact/Conventions/Conventions.pier.html
---

but the link seems to be down

so here it goes
If you have a package Famix-Core

then you commit your change has Famix-Core.MyBranch

It generates a mcz with a name looking like:
Famix-Core.MyBranch-UsmanBhathi.532
which parent will be
Famix-Core-UsmanBhathi.531

I used it a couple of times and it works fine.

nicolas
On 11/03/2015 09:13, Usman Bhatti wrote:
Ok then I'll keep it in another repo temporarily and commit on the main branch when we move to 5.1.

On Tue, Mar 10, 2015 at 6:09 PM, Tudor Girba <[hidden email]> wrote:

Hi,

We do not have a branch for Moose 5.0. For Moose, we only have one repository.

And Moose 5.1 will be released soon after Pharo.

Cheers,

Doru

On Tue, Mar 10, 2015 at 5:22 PM, Usman Bhatti <[hidden email]> wrote:

Here is a working version if someone's interested.
I would like to commit on a bug fix branch for Moose 5.0 (may be with a specific postfix) and not in the main branch to have it in Moose 5.0.

regards.

On Fri, Mar 6, 2015 at 10:42 AM, Usman Bhatti <[hidden email]> wrote:

Hi,

I would like to apply filter only on the root items in a tree presentation and not on all children. Computing children take a bit of time for each node, which is acceptable for each root. However, accumulated computation time make the filtering un-usable.

I could not find a possible way to avoid the filter computation for the children in GLMTreeMorphNodeModel>>shouldBeDisplayedByText with the current implementation. I can propose a fix.

Let me know what you think.

regards.

usman

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev