GRVASTPlatform class>>#shutDown throws an exception

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

GRVASTPlatform class>>#shutDown throws an exception

Marten Feldtmann-2
While playing with the 8.5 I have now for the second time the problem, that the method above throws an exception, when I want to leave/save the image.

In this method "ShutDownList" is nil (!).


--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/gLyug-czDgcJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

Marten Feldtmann-2
ShutDownList is only initialized in GRVASTPlatform>>addToShutDownList:, but I have not found any senders in my image of this method.

Marten

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/cCFAlTOqTw8J.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

Gabriel Cotelli
In reply to this post by Marten Feldtmann-2
Hi Marten,
Sounds like a bug to me. I've changed GRVASTPlatform>>#shutDown and GRVASTPlatform>>#startUp to the following to solve it:


GRVASTPlatform>>#shutDown 
ShutDownList ifNotNil: [:list | list do: [:ea | ea shutDown]]

GRVASTPlatform>>#startUp

StartUpList ifNotNil: [:list | list do: [:ea | ea startUp]].

I don't have any sender but once loaded "Platform Portabiltiy" configuration map the image can't be saved without this changes.

Regards,
Gabriel

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/yYh14VLAhWsJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

Thomas Koschate-2
In reply to this post by Marten Feldtmann-2
Marten, WAServerManager class>>initialize is sending #addToShutDownList: in my image in the application SeasideCoreServer.  One more app to make sure is in your package?

Tom

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/XMYdiGyq2-oJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

Marten Feldtmann-2
Hello Thomas,

what about using the portability layer stuff without any Seaside code (e.g. Announcement did this) ????

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/lyNrjiuO6-oJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

John O'Keefe-3
In reply to this post by Marten Feldtmann-2
Marten -
 
In a Seaside development image you should see 1 sender (WAServerManager); in a Seaside development image with tests loaded, you should see a 2ndd sender (GRPlatformTest).
 
That being said, it would make thing more resilient to implement Gabriel's suggestion (thanks Gabriel).
 
John

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/e4x5930Q-dQJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

Thomas Koschate-2
In reply to this post by Marten Feldtmann-2
Marten, personally, I'd never have implemented the class like this.  I would have created accessors for for ShutDownList and StartUpList, and either built lazy initializers, or, more likely, set their values in the class #initialize method.  You could still set the values in #initialize without modifying any code.

Tom

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/cPXQfYQo0wQJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

Thomas Koschate-2
In reply to this post by Marten Feldtmann-2
Marten, personally, I'd never have implemented the class like this.  I would have created accessors for for ShutDownList and StartUpList, and either built lazy initializers, or, more likely, set their values in the class #initialize method.  You could still set the values in #initialize without modifying any additional code.

Tom

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/K2tvS-PIL5IJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.
Reply | Threaded
Open this post in threaded view
|

Re: GRVASTPlatform class>>#shutDown throws an exception

John O'Keefe-3
Thomas -
 
That is actually how I fixed it in case 48770.  This was ancient code written in the early days of Seaside 3.0 support without a lot of thought to use of the portaility code outside Seaside (which is probably obvious since it has held up until now).
 
John 

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/Ojioao8T4rgJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.