Smalltalk › Pharo › Pharo Smalltalk Developers

GTDebugger (case 17341 Integrate GTools version 3.3)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

13 messages Options

Nicolai Hess-3-2

GTDebugger (case 17341 Integrate GTools version 3.3)

Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).
- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

Andrei Chis

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

Hi Nicolai,

Thanks for the feedback.

Some issues I'll manage to fix until we integrate.

For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:

Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Cheers,

Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

EstebanLM

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

On 08 Jan 2016, at 16:43, Andrei Chis <[hidden email]> wrote:

Hi Nicolai,

Thanks for the feedback.
Some issues I'll manage to fix until we integrate.
For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Cheers,
Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out”

for me they are not small, but misplaced. I expect to have them close to where I’m looking for: the code (that happens in all debuggers I know, with the exception of ddd who opens a different window).

For me, they should be in the code panel and not in the stack panel.

also… shortcuts do not work in code panel :(

Esteban

- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

Esteban A. Maringolo

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

2016-01-08 12:48 GMT-03:00 Esteban Lorenzano <[hidden email]>:

>
> On 08 Jan 2016, at 16:43, Andrei Chis <[hidden email]> wrote:
>
> Hi Nicolai,
>
> Thanks for the feedback.
> Some issues I'll manage to fix until we integrate.
> For those that I do not manage please open bug reports.
>
> On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
>>
>> Some feedback on GTDebugger
>>
>> - The inspector pane is great, we can inspect, evaluate code, and easily
>> show/ inspect the code (for thisContext).
>> although the evaluator pane has a bad text mode (for the thisContext).
>
>
> Can you give me more details? Maybe it's obvious but I'm missing what's
> wrong :)
>
> Cheers,
> Andrei
>
>>
>> - I think the buttons are too small and the icon for "stop over" is
>> misleading, it looks like a "step out”

+1 to this, I had to hover it to realize it.

The best icons I found for these features are the ones from Dolphin Smalltalk (now opensourced ;-) )

Imágenes integradas 1

>
> for me they are not small, but misplaced. I expect to have them close to
> where I’m looking for: the code (that happens in all debuggers I know, with
> the exception of ddd who opens a different window).
> For me, they should be in the code panel and not in the stack panel.
> also… shortcuts do not work in code panel :(

+1 to this. Altough if you use shortcuts you don't care where they are located.

BTW, is it possible to use the function keys as shortcuts? I would map F10-F12 (with modifiers) as shortcuts.

Regards!

Esteban A. Maringolo

EstebanLM

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

On 08 Jan 2016, at 17:04, Esteban A. Maringolo <[hidden email]> wrote:

2016-01-08 12:48 GMT-03:00 Esteban Lorenzano <[hidden email]>:

>
> On 08 Jan 2016, at 16:43, Andrei Chis <[hidden email]> wrote:
>
> Hi Nicolai,
>
> Thanks for the feedback.
> Some issues I'll manage to fix until we integrate.
> For those that I do not manage please open bug reports.
>
> On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
>>
>> Some feedback on GTDebugger
>>
>> - The inspector pane is great, we can inspect, evaluate code, and easily
>> show/ inspect the code (for thisContext).
>> although the evaluator pane has a bad text mode (for the thisContext).
>
>
> Can you give me more details? Maybe it's obvious but I'm missing what's
> wrong :)
>
> Cheers,
> Andrei
>
>>
>> - I think the buttons are too small and the icon for "stop over" is
>> misleading, it looks like a "step out”

+1 to this, I had to hover it to realize it.

The best icons I found for these features are the ones from Dolphin Smalltalk (now opensourced ;-) )

<dolphin-dbg.png>

they are more or less equal.

also we will not mix button sets :)

>
> for me they are not small, but misplaced. I expect to have them close to
> where I’m looking for: the code (that happens in all debuggers I know, with
> the exception of ddd who opens a different window).
> For me, they should be in the code panel and not in the stack panel.
> also… shortcuts do not work in code panel :(

+1 to this. Altough if you use shortcuts you don't care where they are located.

yes you care… I use both :)

BTW, is it possible to use the function keys as shortcuts? I would map F10-F12 (with modifiers) as shortcuts.

that’s not possible… they are taken by O.S. usually.

Esteban

Regards!

Esteban A. Maringolo

Nicolai Hess-3-2

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

In reply to this post by Andrei Chis

2016-01-08 16:43 GMT+01:00 Andrei Chis <[hidden email]>:

Hi Nicolai,

Thanks for the feedback.
Some issues I'll manage to fix until we integrate.
For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Hm, I can not reproduce it anymore.

Cheers,
Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

Nicolai Hess-3-2

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

In reply to this post by EstebanLM

2016-01-08 16:48 GMT+01:00 Esteban Lorenzano <[hidden email]>:

On 08 Jan 2016, at 16:43, Andrei Chis <[hidden email]> wrote:

Hi Nicolai,

Thanks for the feedback.
Some issues I'll manage to fix until we integrate.
For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Cheers,
Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out”

for me they are not small, but misplaced. I expect to have them close to where I’m looking for: the code (that happens in all debuggers I know, with the exception of ddd who opens a different window).
For me, they should be in the code panel and not in the stack panel.
also… shortcuts do not work in code panel :(

Maybe a small margin between the buttons ?

It often happens to me that I press the wrong button (step into instead of step over).

Esteban

- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

Nicolai Hess-3-2

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

In reply to this post by Nicolai Hess-3-2

2016-01-08 22:48 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-08 16:43 GMT+01:00 Andrei Chis <[hidden email]>:
Hi Nicolai,

Thanks for the feedback.
Some issues I'll manage to fix until we integrate.
For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Hm, I can not reproduce it anymore.

Ok, now it happened again. See screenshot, the thisContext evaluator pane is wrong. And it does

not go away (every debugger now shows this text, even if I debug a totally different method)

Cheers,
Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

PharoScreenshot.png (85K) Download Attachment

Nicolai Hess-3-2

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

2016-01-08 22:55 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-08 22:48 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-08 16:43 GMT+01:00 Andrei Chis <[hidden email]>:
Hi Nicolai,

Thanks for the feedback.
Some issues I'll manage to fix until we integrate.
For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Hm, I can not reproduce it anymore.

Ok, now it happened again. See screenshot, the thisContext evaluator pane is wrong. And it does
not go away (every debugger now shows this text, even if I debug a totally different method)

How to reporduce:

select some code and debugIt

in the debugger select

thisContex

select the Evaluator pane, now select the Source pane

close debugger

open debugger again

select Evaluator pane

-> it will always show the last source pane text in the Evaluator pane

Cheers,
Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

Tudor Girba-2

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

This is a fun one. I think the reason comes from incorrect printing as comment.

Please open a bug for this.

Cheers,
Doru

> On Jan 9, 2016, at 12:16 AM, Nicolai Hess <[hidden email]> wrote:
>
>
>
> 2016-01-08 22:55 GMT+01:00 Nicolai Hess <[hidden email]>:
>
>
> 2016-01-08 22:48 GMT+01:00 Nicolai Hess <[hidden email]>:
>
>
> 2016-01-08 16:43 GMT+01:00 Andrei Chis <[hidden email]>:
> Hi Nicolai,
>
> Thanks for the feedback.
> Some issues I'll manage to fix until we integrate.
> For those that I do not manage please open bug reports.
>
> On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:
> Some feedback on GTDebugger
>
> - The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
> although the evaluator pane has a bad text mode (for the thisContext).
>
> Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)
>
> Hm, I can not reproduce it anymore.
>
> Ok, now it happened again. See screenshot, the thisContext evaluator pane is wrong. And it does
> not go away (every debugger now shows this text, even if I debug a totally different method)
>
> How to reporduce:
>
> select some code and debugIt
> in the debugger select
> thisContex
> select the Evaluator pane, now select the Source pane
> close debugger
> open debugger again
> select Evaluator pane
> -> it will always show the last source pane text in the Evaluator pane
>
>
>
>
>
>
> Cheers,
> Andrei
>
> - I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
> - the shortcuts (neither ctrl+t nor cmd+t) aren't working
> - I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
> the rightmost pane. The context inspector should be fixed.
> - I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
> - the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).
>
> nicolai
>
>
>
>

--
www.tudorgirba.com
www.feenk.com

"Reasonable is what we are accustomed with."

stepharo

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

In reply to this post by Nicolai Hess-3-2

+1

Stef

Le 7/1/16 21:13, Nicolai Hess a écrit :

> Some feedback on GTDebugger
>
> - The inspector pane is great, we can inspect, evaluate code, and
> easily show/ inspect the code (for thisContext).
> although the evaluator pane has a bad text mode (for the thisContext).
> - I think the buttons are too small and the icon for "stop over" is
> misleading, it looks like a "step out"
> - the shortcuts (neither ctrl+t nor cmd+t) aren't working
> - I find it totally annoying and useless that the context pane
> inspector scrolls away if you select a value in
> the rightmost pane. The context inspector should be fixed.
> - I really miss the "List Methods using 'varname'/List Methods storing
> into 'varname'
> - the stacklist entry for block closures prints the block closure
> code, this is confusing (too much text for such a small widget).
>
> nicolai

stepharo

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

In reply to this post by Nicolai Hess-3-2

I like that you report bug and not me.

Le 8/1/16 22:55, Nicolai Hess a écrit :

2016-01-08 22:48 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-08 16:43 GMT+01:00 Andrei Chis <[hidden email]>:

Hi Nicolai,

Thanks for the feedback.

Some issues I'll manage to fix until we integrate.

For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:

Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Hm, I can not reproduce it anymore.

Ok, now it happened again. See screenshot, the thisContext evaluator pane is wrong. And it does

not go away (every debugger now shows this text, even if I debug a totally different method)

Cheers,

Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai

stepharo

Re: GTDebugger (case 17341 Integrate GTools version 3.3)

In reply to this post by Nicolai Hess-3-2

Why do we need thisContext?

Le 8/1/16 23:16, Nicolai Hess a écrit :

2016-01-08 22:55 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-08 22:48 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-08 16:43 GMT+01:00 Andrei Chis <[hidden email]>:

Hi Nicolai,

Thanks for the feedback.

Some issues I'll manage to fix until we integrate.

For those that I do not manage please open bug reports.

On Thu, Jan 7, 2016 at 9:13 PM, Nicolai Hess <[hidden email]> wrote:

Some feedback on GTDebugger

- The inspector pane is great, we can inspect, evaluate code, and easily show/ inspect the code (for thisContext).
although the evaluator pane has a bad text mode (for the thisContext).

Can you give me more details? Maybe it's obvious but I'm missing what's wrong :)

Hm, I can not reproduce it anymore.

Ok, now it happened again. See screenshot, the thisContext evaluator pane is wrong. And it does

not go away (every debugger now shows this text, even if I debug a totally different method)

How to reporduce:

select some code and debugIt

in the debugger select

thisContex

select the Evaluator pane, now select the Source pane

close debugger

open debugger again

select Evaluator pane

-> it will always show the last source pane text in the Evaluator pane

Cheers,

Andrei

- I think the buttons are too small and the icon for "stop over" is misleading, it looks like a "step out"
- the shortcuts (neither ctrl+t nor cmd+t) aren't working
- I find it totally annoying and useless that the context pane inspector scrolls away if you select a value in
the rightmost pane. The context inspector should be fixed.
- I really miss the "List Methods using 'varname'/List Methods storing into 'varname'
- the stacklist entry for block closures prints the block closure code, this is confusing (too much text for such a small widget).

nicolai