GTInspector extension menues with line separators and submenu items

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

GTInspector extension menues with line separators and submenu items

Torsten Bergmann
Hi,

Is it possible to separate the context menus (built with #selectionAct: ...)
in GTInspector extension methods with lines similar to the regular menue building
where #withSeparatorAfter is used.

Is it possible to have submenues in the context menu items (cascading menues as the world menu).

Any examples?`

Thx
T.

Reply | Threaded
Open this post in threaded view
|

Re: GTInspector extension menues with line separators and submenu items

Andrei Chis
Hi,

Currently when creating methods using the scripting actions from glamour you cannot directly specify #withSeparatorAfter.
Right now you can either add actions manually (for examples #browsingSelectionActions) or use something like:

   with: [ :presentation | presentation selectionActions last withSeparatorAfter]

If you find a nice way to improve this API please do so :)


For submenus look in GLMBasiExamples>>#staticAndDynamicMenu

Cheers,
Andrei

On Fri, Oct 30, 2015 at 9:00 AM, Torsten Bergmann <[hidden email]> wrote:
Hi,

Is it possible to separate the context menus (built with #selectionAct: ...)
in GTInspector extension methods with lines similar to the regular menue building
where #withSeparatorAfter is used.

Is it possible to have submenues in the context menu items (cascading menues as the world menu).

Any examples?`

Thx
T.


Reply | Threaded
Open this post in threaded view
|

Re: GTInspector extension menues with line separators and submenu items

Torsten Bergmann
Hi Andrei,

using the #with: aBlock variant initially seemed to have no effect
when using a tree representation.

Looks like  GLMTreeMorphNodeModel>>#menu:shifted: does not honor the
"separatorAfter" boolean flag during menu construction as it already
done in GLMMorphicModel>>menu:

This is a bug as this was left out in this method. I added the missing
piece to GLMTreeMorphNodeModel>>#menu:shifted: to make it work.
Works like a charme.

Packaged as for further review:

---------------------------------------------------------------------------
Name: Glamour-Morphic-Widgets-TorstenBergmann.183
Author: TorstenBergmann
Time: 30 October 2015, 4:49:41.455057 pm
UUID: 9c2470db-73bc-2c43-b40d-1633b8de00eb
Ancestors: Glamour-Morphic-Widgets-MarcusDenker.182

The #separatorAfter flag of the action should have an effect 
---------------------------------------------------------------------------

Can you integate it (or should I open an additional bug entry first)?
When is the next round for a Glamour update to have this quickly in recent Pharo image?

Thx
T.

Gesendet: Freitag, 30. Oktober 2015 um 14:14 Uhr
Von: "Andrei Chis" <[hidden email]>
An: "Pharo Development List" <[hidden email]>
Betreff: Re: [Pharo-dev] GTInspector extension menues with line separators and submenu items

Hi,
 
Currently when creating methods using the scripting actions from glamour you cannot directly specify #withSeparatorAfter.
Right now you can either add actions manually (for examples #browsingSelectionActions) or use something like:
 
   with: [ :presentation | presentation selectionActions last withSeparatorAfter]
 
If you find a nice way to improve this API please do so :)
 
 
For submenus look in GLMBasiExamples>>#staticAndDynamicMenu
 
Cheers,
Andrei
 
On Fri, Oct 30, 2015 at 9:00 AM, Torsten Bergmann <[hidden email]> wrote:Hi,

Is it possible to separate the context menus (built with #selectionAct: ...)
in GTInspector extension methods with lines similar to the regular menue building
where #withSeparatorAfter is used.

Is it possible to have submenues in the context menu items (cascading menues as the world menu).

Any examples?`

Thx
T.
 

Reply | Threaded
Open this post in threaded view
|

Re: GTInspector extension menues with line separators and submenu items

Andrei Chis
Super. Thanks for the fix.

Right now I'm in the middle of  deprecating the text renderer based in PluggableTextMorph and moving everything in glamour to rubric.
I'll probably be done today or tomorrow.  If it takes me longer and you really need this in pharo feel free to make an issue with a slice :)


On Fri, Oct 30, 2015 at 11:53 AM, Torsten Bergmann <[hidden email]> wrote:
Hi Andrei,

using the #with: aBlock variant initially seemed to have no effect
when using a tree representation.

Looks like  GLMTreeMorphNodeModel>>#menu:shifted: does not honor the
"separatorAfter" boolean flag during menu construction as it already
done in GLMMorphicModel>>menu:

This is a bug as this was left out in this method. I added the missing
piece to GLMTreeMorphNodeModel>>#menu:shifted: to make it work.
Works like a charme.

Packaged as for further review:

---------------------------------------------------------------------------
Name: Glamour-Morphic-Widgets-TorstenBergmann.183
Author: TorstenBergmann
Time: 30 October 2015, 4:49:41.455057 pm
UUID: 9c2470db-73bc-2c43-b40d-1633b8de00eb
Ancestors: Glamour-Morphic-Widgets-MarcusDenker.182

The #separatorAfter flag of the action should have an effect 
---------------------------------------------------------------------------

Can you integate it (or should I open an additional bug entry first)?
When is the next round for a Glamour update to have this quickly in recent Pharo image?

Thx
T.

Gesendet: Freitag, 30. Oktober 2015 um 14:14 Uhr
Von: "Andrei Chis" <[hidden email]>
An: "Pharo Development List" <[hidden email]>
Betreff: Re: [Pharo-dev] GTInspector extension menues with line separators and submenu items

Hi,
 
Currently when creating methods using the scripting actions from glamour you cannot directly specify #withSeparatorAfter.
Right now you can either add actions manually (for examples #browsingSelectionActions) or use something like:
 
   with: [ :presentation | presentation selectionActions last withSeparatorAfter]
 
If you find a nice way to improve this API please do so :)
 
 
For submenus look in GLMBasiExamples>>#staticAndDynamicMenu
 
Cheers,
Andrei
 
On Fri, Oct 30, 2015 at 9:00 AM, Torsten Bergmann <[hidden email]> wrote:Hi,

Is it possible to separate the context menus (built with #selectionAct: ...)
in GTInspector extension methods with lines similar to the regular menue building
where #withSeparatorAfter is used.

Is it possible to have submenues in the context menu items (cascading menues as the world menu).

Any examples?`

Thx
T.