GTTool bug:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

GTTool bug:

stepharo
edit: aText label: labelString accept: anAction
     "Open an editor on the given string/text"

     ^(Smalltalk tools workspace openLabel: labelString)
         acceptContents:  aText;
         acceptAction: anAction;
         yourself.


-> DNU

UIManager default
         edit: 'jlklkjk'
         label: 'lkjlkjjkl'

Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Uko2
Hi,

I think that there may be sense to create a trait or at least some doc that will say which functionality should current tools implement. Because I believe that it is hard to find out what is used by everyone. And as we have another tools now and some unimplemented things it makes sense to document it now, while we know what is missing.

Uko

> On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:
>
> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>
> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>


Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Tudor Girba-2
Hi,

I think that acceptAction: should not be the responsibility of the playground and that we should implement this behavior with a different widget.

Cheers,
Doru


On Tue, Sep 30, 2014 at 10:20 PM, Yuriy Tymchuk <[hidden email]> wrote:
Hi,

I think that there may be sense to create a trait or at least some doc that will say which functionality should current tools implement. Because I believe that it is hard to find out what is used by everyone. And as we have another tools now and some unimplemented things it makes sense to document it now, while we know what is missing.

Uko

> On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:
>
> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>
> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>





--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Marcus Denker-4
In reply to this post by stepharo

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>


signature.asc (210 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Tudor Girba-2

On Wed, Oct 1, 2014 at 9:20 AM, Marcus Denker <[hidden email]> wrote:

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>




--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Andrei Chis
I fixed for now the part with acceptsContents:
This should work when the issue is integrated

UIManager default
        edit: 'jlklkjk'
        label: 'lkjlkjjkl'.

On Wed, Oct 1, 2014 at 9:50 AM, Tudor Girba <[hidden email]> wrote:

On Wed, Oct 1, 2014 at 9:20 AM, Marcus Denker <[hidden email]> wrote:

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>




--

"Every thing has its own flow"

Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Tudor Girba-2
How did you fix it?

Doru

On Wed, Oct 1, 2014 at 10:22 AM, Andrei Chis <[hidden email]> wrote:
I fixed for now the part with acceptsContents:
This should work when the issue is integrated

UIManager default
        edit: 'jlklkjk'
        label: 'lkjlkjjkl'.

On Wed, Oct 1, 2014 at 9:50 AM, Tudor Girba <[hidden email]> wrote:

On Wed, Oct 1, 2014 at 9:20 AM, Marcus Denker <[hidden email]> wrote:

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>




--

"Every thing has its own flow"




--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Andrei Chis
There is an acceptsContents: on GLMSystemWindow that delegates to the model, which in this case is the playground. 

On Wed, Oct 1, 2014 at 10:26 AM, Tudor Girba <[hidden email]> wrote:
How did you fix it?

Doru

On Wed, Oct 1, 2014 at 10:22 AM, Andrei Chis <[hidden email]> wrote:
I fixed for now the part with acceptsContents:
This should work when the issue is integrated

UIManager default
        edit: 'jlklkjk'
        label: 'lkjlkjjkl'.

On Wed, Oct 1, 2014 at 9:50 AM, Tudor Girba <[hidden email]> wrote:

On Wed, Oct 1, 2014 at 9:20 AM, Marcus Denker <[hidden email]> wrote:

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>




--

"Every thing has its own flow"




--

"Every thing has its own flow"

Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Tudor Girba-2
I think this is the wrong thing to do. We should reimplement the method in the UIManager.

Doru

On Wed, Oct 1, 2014 at 10:30 AM, Andrei Chis <[hidden email]> wrote:
There is an acceptsContents: on GLMSystemWindow that delegates to the model, which in this case is the playground. 

On Wed, Oct 1, 2014 at 10:26 AM, Tudor Girba <[hidden email]> wrote:
How did you fix it?

Doru

On Wed, Oct 1, 2014 at 10:22 AM, Andrei Chis <[hidden email]> wrote:
I fixed for now the part with acceptsContents:
This should work when the issue is integrated

UIManager default
        edit: 'jlklkjk'
        label: 'lkjlkjjkl'.

On Wed, Oct 1, 2014 at 9:50 AM, Tudor Girba <[hidden email]> wrote:

On Wed, Oct 1, 2014 at 9:20 AM, Marcus Denker <[hidden email]> wrote:

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>




--

"Every thing has its own flow"




--

"Every thing has its own flow"




--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: GTTool bug:

Marcus Denker-4

On 01 Oct 2014, at 10:58, Tudor Girba <[hidden email]> wrote:

I think this is the wrong thing to do. We should reimplement the method in the UIManager.


Yes! 


Doru

On Wed, Oct 1, 2014 at 10:30 AM, Andrei Chis <[hidden email]> wrote:
There is an acceptsContents: on GLMSystemWindow that delegates to the model, which in this case is the playground. 

On Wed, Oct 1, 2014 at 10:26 AM, Tudor Girba <[hidden email]> wrote:
How did you fix it?

Doru

On Wed, Oct 1, 2014 at 10:22 AM, Andrei Chis <[hidden email]> wrote:
I fixed for now the part with acceptsContents:
This should work when the issue is integrated

UIManager default
        edit: 'jlklkjk'
        label: 'lkjlkjjkl'.

On Wed, Oct 1, 2014 at 9:50 AM, Tudor Girba <[hidden email]> wrote:

On Wed, Oct 1, 2014 at 9:20 AM, Marcus Denker <[hidden email]> wrote:

On 30 Sep 2014, at 20:41, stepharo <[hidden email]> wrote:

> edit: aText label: labelString accept: anAction
>    "Open an editor on the given string/text"
>
>    ^(Smalltalk tools workspace openLabel: labelString)
>        acceptContents:  aText;
>        acceptAction: anAction;
>        yourself.
>
>


Yes, we are abusing the workspace for an editor, this is not good.

We should have an editor that is an editor, not a workspace.

> -> DNU
>
> UIManager default
>        edit: 'jlklkjk'
>        label: 'lkjlkjjkl'
>




--

"Every thing has its own flow"




--

"Every thing has its own flow"




--

"Every thing has its own flow"


signature.asc (210 bytes) Download Attachment