GTools regression

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

GTools regression

EstebanLM
Hi,

Someway the old GLMThemeIcons is restored (which means icons are wrong)
(sending to moose-dev too, but I don’t know if needed :P)

Esteban
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Pharo-dev] GTools regression

Andrei Chis
What do you mean that the GLMThemeIcons are restored?


Cheers,
Andrei

On Fri, Jan 23, 2015 at 2:54 PM, Esteban Lorenzano <[hidden email]> wrote:
Hi,

Someway the old GLMThemeIcons is restored (which means icons are wrong)
(sending to moose-dev too, but I don’t know if needed :P)

Esteban


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Pharo-dev] GTools regression

EstebanLM
GLMThemeIcons was refactored (by me) to move out the icons from there (and included in ThemeIcons)… so they can be themed with icon packs. 
Also I made them compatible with the eclipse pack (while preserving those icons). 
I sent to you those changes last month (or the previous, I do not remember). 
Now, in last Pharo4 build, the class GLMThemeIcons again has the icons there (and because of that, playground and inspector are shown glamour icons… which is incorrect for Pharo4)

Esteban

On 23 Jan 2015, at 14:58, Andrei Chis <[hidden email]> wrote:

What do you mean that the GLMThemeIcons are restored?


Cheers,
Andrei

On Fri, Jan 23, 2015 at 2:54 PM, Esteban Lorenzano <[hidden email]> wrote:
Hi,

Someway the old GLMThemeIcons is restored (which means icons are wrong)
(sending to moose-dev too, but I don’t know if needed :P)

Esteban



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Pharo-dev] GTools regression

Andrei Chis

On Fri, Jan 23, 2015 at 3:05 PM, Esteban Lorenzano <[hidden email]> wrote:
GLMThemeIcons was refactored (by me) to move out the icons from there (and included in ThemeIcons)… so they can be themed with icon packs. 
Also I made them compatible with the eclipse pack (while preserving those icons). 
I sent to you those changes last month (or the previous, I do not remember). 
Now, in last Pharo4 build, the class GLMThemeIcons again has the icons there (and because of that, playground and inspector are shown glamour icons… which is incorrect for Pharo4)

Aha. Thanks for the explanation :) 
Your changes were integrated but got then reverted :(
It's fixed now in the latest moose version

Cheers,
Andrei
 

Esteban

On 23 Jan 2015, at 14:58, Andrei Chis <[hidden email]> wrote:

What do you mean that the GLMThemeIcons are restored?


Cheers,
Andrei

On Fri, Jan 23, 2015 at 2:54 PM, Esteban Lorenzano <[hidden email]> wrote:
Hi,

Someway the old GLMThemeIcons is restored (which means icons are wrong)
(sending to moose-dev too, but I don’t know if needed :P)

Esteban




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev