Smalltalk › Pharo › Pharo Smalltalk Developers

Git, FileTree/Cypress, missing Traits comments

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Ben Coman

Git, FileTree/Cypress, missing Traits comments

Is this of concern for Pharo...? "Pull requests on GitHub where the Trait comments get removed (because they were not loaded with the package in the first place)."

http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none

http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html

cheers -ben

Thierry Goubier

Re: Git, FileTree/Cypress, missing Traits comments

Hi Ben,

There is two Traits tests in the FileTree repository, and they pass
(both under filetree and under gitfiletree) even if I notice that you
can load the test package fine, but you get a DNU when browsing that
package from the test repository inspector.

The tests classes are MCFileTreeLoaderTraitsTest and
MCGitFileTreeLoaderTraitsTest, and the test repository is at:
https://github.com/dalehenrich/filetree/tree/pharo5.0/tests/testRepositories/traits.

Would you be interested in checking if the Squeak bug applies, adding an
additional test to confirm or infirm with a pull request?

Regards,

Thierry

Le 21/05/2017 à 05:12, Ben Coman a écrit :

> Is this of concern for Pharo...? "Pull requests on GitHub where the
> Trait comments get removed (because they were not loaded with the
> package in the first place)."
>
> http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none
>
> http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html
>
> cheers -ben
>

Ben Coman

Re: Git, FileTree/Cypress, missing Traits comments

Le 21/05/2017 à 05:12, Ben Coman a écrit :

Is this of concern for Pharo...? "Pull requests on GitHub where the
Trait comments get removed (because they were not loaded with the
package in the first place)."

http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none

http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html

cheers -ben

On Sun, May 21, 2017 at 5:12 PM, Thierry Goubier <[hidden email]> wrote:

Hi Ben,

There is two Traits tests in the FileTree repository, and they pass (both under filetree and under gitfiletree) even if I notice that you can load the test package fine, but you get a DNU when browsing that package from the test repository inspector.

The tests classes are MCFileTreeLoaderTraitsTest and MCGitFileTreeLoaderTraitsTest, and the test repository is at: https://github.com/dalehenrich/filetree/tree/pharo5.0/tests/testRepositories/traits.

Would you be interested in checking if the Squeak bug applies, adding an additional test to confirm or infirm with a pull request?

I guess I could if no one else picks it up, but I don't think I'm best placed to do it. I've never used FileTree nor Traits, so I'm not sure where to look for the Trait's comment (is this just a class comment on a subclass of Trait) - and given the move to Iceberg/Git, I'm not sure the FileTree/Git learning curve is worth it for me. I was hoping someone familiar with both or one of them could at least confirm the problem first.

cheers -ben

Dale Henrichs-3

Re: Git, FileTree/Cypress, missing Traits comments

In reply to this post by Ben Coman

I'm not familiar with Traits and how they have been integrated into
Monticello, but reading comments from the snapshot is pretty wild ---
but I I suppose it works:)

For FileTree Traits should be added as first class objects ... I assume
that Traits are just regular classes and that the trickery comes with
associating a method in a class with a method from a Trait.

In Filetree (Cypress 1.0), the first line of an st file is interpreted
as the method protocol and monkeying with the method protocol would be
possible but not transparently portable. The "most recent" Cypress
format (Cypress 1.5) switched from a single line to a 4 line structured
comment[1].

Martin McClure is currently working on Cypress2.0 and I believe that he
is proposing that methods also have an attribute dictionary (like
classes [2]), so for Cypress 2.0 Traits methods could be first class
objects ...

Cypress 2.0 is still a work in process. Cypress 1.0 is widely used,
while Cypress 1.5 is not...

Sooo, I would suggest that the Cypress 1.5 format could be modified to
accommodate Traits methods ... FileTree already supports 3 or 4
different disk formats, so FileTree could be updated to support Cypress
1.5 format and then Bob's your uncle ...

Dale

[1]https://github.com/CampSmalltalk/Cypress/wiki#method-file-format

[2] https://github.com/CampSmalltalk/Cypress/wiki#class-properties

On 5/20/17 8:12 PM, Ben Coman wrote:

Dale Henrichs-3

Re: Git, FileTree/Cypress, missing Traits comments

Looks like Thierry has a nifty solution for Traits in FileTree that
doesn't involve methods ... Bob's already your uncle:)

Dale

On 5/21/17 10:36 AM, Dale Henrichs wrote:

> I'm not familiar with Traits and how they have been integrated into
> Monticello, but reading comments from the snapshot is pretty wild ---
> but I I suppose it works:)
>
> For FileTree Traits should be added as first class objects ... I
> assume that Traits are just regular classes and that the trickery
> comes with associating a method in a class with a method from a Trait.
>
> In Filetree (Cypress 1.0), the first line of an st file is interpreted
> as the method protocol and monkeying with the method protocol would be
> possible but not transparently portable. The "most recent" Cypress
> format (Cypress 1.5) switched from a single line to a 4 line
> structured comment[1].
>
> Martin McClure is currently working on Cypress2.0 and I believe that
> he is proposing that methods also have an attribute dictionary (like
> classes [2]), so for Cypress 2.0 Traits methods could be first class
> objects ...
>
> Cypress 2.0 is still a work in process. Cypress 1.0 is widely used,
> while Cypress 1.5 is not...
>
> Sooo, I would suggest that the Cypress 1.5 format could be modified to
> accommodate Traits methods ... FileTree already supports 3 or 4
> different disk formats, so FileTree could be updated to support
> Cypress 1.5 format and then Bob's your uncle ...
>
> Dale
>
> [1]https://github.com/CampSmalltalk/Cypress/wiki#method-file-format
>
> [2] https://github.com/CampSmalltalk/Cypress/wiki#class-properties
>
> On 5/20/17 8:12 PM, Ben Coman wrote:
>> Is this of concern for Pharo...? "Pull requests on GitHub where the
>> Trait comments get removed (because they were not loaded with the
>> package in the first place)."
>>
>> http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none
>>
>> http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html
>>
>> cheers -ben
>>
>