Smalltalk › Pharo › Pharo Smalltalk Users

GitFileTree browsing changes doesn't work in Pharo 5

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Peter Uhnak

GitFileTree browsing changes doesn't work in Pharo 5

Hi,

when I wanted to see package changes in Pharo 5 (with GitFileTree from MetaRepoFor5.0 / loadDevelopment)

it died on MCMczReader class>>canReadFileNamed: fileName

because "fileName" is actually instance of GitFileTreePackageEntry

is it broken, or did I break something?

Thanks,

Peter

Thierry Goubier

Re: GitFileTree browsing changes doesn't work in Pharo 5

Hi Peter,

I may be a few updates behind Pharo5 these past days (well, I haven't
started Pharo5 recently) so I need to have a look.

Can you wait until tomorrow?

Thierry

Le 18/07/2015 23:38, Peter Uhnák a écrit :

> Hi,
>
> when I wanted to see package changes in Pharo 5 (with GitFileTree from
> MetaRepoFor5.0 / loadDevelopment)
>
> it died on MCMczReader class>>canReadFileNamed: fileName
> because "fileName" is actually instance of GitFileTreePackageEntry
>
> is it broken, or did I break something?
>
> Thanks,
> Peter

Peter Uhnak

Re: GitFileTree browsing changes doesn't work in Pharo 5

Can you wait until tomorrow?

Sure.

Interestingly enough committing still works.

Peter

Thierry Goubier

Re: GitFileTree browsing changes doesn't work in Pharo 5

Hi Peter,

I'm unable to reproduce. I'm on the latest 5.0 (50174). Could you
describe a bit more what you were trying (I tried Changes, and I go no
error).

Thierry

Le 18/07/2015 23:59, Peter Uhnák a écrit :
> Can you wait until tomorrow?
>
>
> Sure.
>
> Interestingly enough committing still works.
>
> Peter

Peter Uhnak

Re: GitFileTree browsing changes doesn't work in Pharo 5

1. downloaded a fresh Pharo (#50174)

2. ConfigurationOfGitFileTree loadDevelopment (stable fails because of StringHolder dependency)

3. open monticello and add gitfiletree:// local repo

4. do some change, e.g. add method to a class in the package

5. try to see the changes of the package

6. error

More info: I first encountered this in my main project... so to rule out problems in the actual repo I created a brand new one...

1. I created a completely new empty git repo

2. added via gitfiletree

3. added some classes...

4. committed...

5. and then followed the steps above and it broke

Maybe I can send you packed repository + pharo (image+changes) or a video?

I can consistently reproduce this.

How should I proceed?

Thanks,

Peter

On Sun, Jul 19, 2015 at 8:33 AM, Thierry Goubier <[hidden email]> wrote:

Hi Peter,

I'm unable to reproduce. I'm on the latest 5.0 (50174). Could you describe a bit more what you were trying (I tried Changes, and I go no error).

Thierry

Le 18/07/2015 23:59, Peter Uhnák a écrit :

Can you wait until tomorrow?

Sure.

Interestingly enough committing still works.

Peter

Thierry Goubier

Re: GitFileTree browsing changes doesn't work in Pharo 5

Hi Peter,

Le 19/07/2015 16:09, Peter Uhnák a écrit :
> 1. downloaded a fresh Pharo (#50174)
> 2. ConfigurationOfGitFileTree loadDevelopment (stable fails because of
> StringHolder dependency)
> 3. open monticello and add gitfiletree:// local repo
> 4. do some change, e.g. add method to a class in the package
> 5. try to see the changes of the package
> 6. error

Perfect, I have enough to solve that bug.

Beware, I suspect FileTree will return the same error.

Thierry

Thierry Goubier

Re: GitFileTree browsing changes doesn't work in Pharo 5

In reply to this post by Peter Uhnak

Le 19/07/2015 16:09, Peter Uhnák a écrit :
> 1. downloaded a fresh Pharo (#50174)
> 2. ConfigurationOfGitFileTree loadDevelopment (stable fails because of
> StringHolder dependency)
> 3. open monticello and add gitfiletree:// local repo
> 4. do some change, e.g. add method to a class in the package
> 5. try to see the changes of the package
> 6. error

I've pushed a correction in the development version of GitFileTree.

Thierry

Peter Uhnak

Re: GitFileTree browsing changes doesn't work in Pharo 5

Excellent! Works like magic.

Thank you for looking into this. :)

Peter

On Sun, Jul 19, 2015 at 6:14 PM, Thierry Goubier <[hidden email]> wrote:

Le 19/07/2015 16:09, Peter Uhnák a écrit :

1. downloaded a fresh Pharo (#50174)
2. ConfigurationOfGitFileTree loadDevelopment (stable fails because of
StringHolder dependency)
3. open monticello and add gitfiletree:// local repo
4. do some change, e.g. add method to a class in the package
5. try to see the changes of the package
6. error

I've pushed a correction in the development version of GitFileTree.

Thierry