[Glass] Simple questions while migrating code to GemStone (compatibility issues)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Glass] Simple questions while migrating code to GemStone (compatibility issues)

Mariano Martinez Peck
Hi guys,

I continue trying to make my app work in GemStone. I am making progress, but I still have some questions:

- Is there a way to print closures? When I inspect one I get something like "anExecBlock1" but I cannot see the source of the closure (not even the decompiled version).

- In Pharo I can parse a Date from this pattern: 'yyyy-mm-dd' with #readFrom. In GemStone I need to do: Date fromString: '2013-06-21'  usingFormat: #( 3 2 1 $- 1 1). Which is the easies way to deal with this? Like the rest, delegating to a my own util class with 2 impl? 

- Do we have an alternative for WeakValueDictionary? 

- I really miss the #split: and #join: methods. Maybe these could be ported to GemStone? Or are there similar methods already?

Thanks in advance,


--
Mariano
http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3



From: "Mariano Martinez Peck" <[hidden email]>
To: [hidden email]
Sent: Wednesday, November 13, 2013 10:25:59 AM
Subject: [Glass] Simple questions while migrating code to GemStone        (compatibility issues)

Hi guys,

I continue trying to make my app work in GemStone. I am making progress, but I still have some questions:

- Is there a way to print closures? When I inspect one I get something like "anExecBlock1" but I cannot see the source of the closure (not even the decompiled version).
I've submitted an issue against tODE for this[1]. As a workaround you can send the message #_sourceString to the block to get it's source ...

[1] https://github.com/dalehenrich/tode/issues/52

- In Pharo I can parse a Date from this pattern: 'yyyy-mm-dd' with #readFrom. In GemStone I need to do: Date fromString: '2013-06-21'  usingFormat: #( 3 2 1 $- 1 1). Which is the easies way to deal with this? Like the rest, delegating to a my own util class with 2 impl? 
I think that the first order answer is that we should port the Pharo implementation to GLASS ... this would entail update the GsSqueakCommon package in the glss repo[2] with the appropriate implementation (fork repo and then issue a pull request when finished) including the Pharo tests for the feature ...

In poking around in the image, I've found that SpDate class>>parseDateFromISO8601Stream: (from Sport) parses dates of the form you are looking for. Sport is ported to both GemStone and Pharo so that could be an option ...

Finally you could create your own utility layer with common messages ...

My preference is that the Pharo-style get ported to the compat layer in GemStone so others can benefit from the work ... hopefully moving GLASS up to github will make the chore of adding code to the compat layer easier than it has been in the past ...

[2] https://github.com/glassdb/glass

- Do we have an alternative for WeakValueDictionary? 
In 3.x we have KeySoftValueDictionary which is the moral equivalent of WeakValueDictionary with the caveat that instances of  KeySoftValueDictionary cannot be persisted ... we only suppor vm level weakness ...

- I really miss the #split: and #join: methods. Maybe these could be ported to GemStone? Or are there similar methods already?

I'm not familiar with split:/join: but would be in favor of having them added to the compat layer. It looks like  #split: has been added to the pharo compat layer in the GsPharo-Core package on GemSource[3] ... I think that I should move the GsPharo* packages onto the github repository to make it easy to contribute ...

The GsSqueakCommon* packages are for methods and classes that have identical implementations on both Squeak and Pharo. there are GsPharo-* and GsSqueak-* packages for methods and classes that are unique to each platform ...

If you are interested in adding #join: support, I'll move the GsPharo-* packages to the github repo ...

Dale

[3] http://seaside.gemtalksystems.com/ss/PharoCompat.html


_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Martin McClure-5
On 11/13/2013 11:35 AM, Dale K. Henrichs wrote:
>
>     - Do we have an alternative for WeakValueDictionary?
>
> In 3.x we have KeySoftValueDictionary which is the moral equivalent of
> WeakValueDictionary with the caveat that instances of
> KeySoftValueDictionary cannot be persisted ... we only suppor vm level
> weakness ...

Note that soft references are only cleared under memory pressure, so it
may or may not meet your needs for equivalence to WeakValueDictionary.

We do support ephemerons in 3.x, which could be used to build
collections whose behavior is closer to traditional weak collections.
Ephemerons also are limited to being non-persistent.

Regards,

-Martin
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Mariano Martinez Peck



On Wed, Nov 13, 2013 at 8:06 PM, Martin McClure <[hidden email]> wrote:
On 11/13/2013 11:35 AM, Dale K. Henrichs wrote:
>
>     - Do we have an alternative for WeakValueDictionary?
>
> In 3.x we have KeySoftValueDictionary which is the moral equivalent of
> WeakValueDictionary with the caveat that instances of
> KeySoftValueDictionary cannot be persisted ... we only suppor vm level
> weakness ...

Note that soft references are only cleared under memory pressure, so it
may or may not meet your needs for equivalence to WeakValueDictionary.

We do support ephemerons in 3.x, which could be used to build
collections whose behavior is closer to traditional weak collections.
Ephemerons also are limited to being non-persistent.

Cool!  (before answering Dale..I need to deep a bit more for that) ... what does it mean that it is not-persistent? what happens to an object which IS persistent and has a pointer to a non-persistent object? Error? replaced by nil?  

Thanks, 

--
Mariano
http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Martin McClure-5
On 11/13/2013 05:59 PM, Mariano Martinez Peck wrote:
> Cool!  (before answering Dale..I need to deep a bit more for that) ...
> what does it mean that it is not-persistent? what happens to an object
> which IS persistent and has a pointer to a non-persistent object? Error?
> replaced by nil?  

Normally, when you put a reference to a non-persistent object into a
persistent object, when you commit the transaction the non-persistent
object becomes persistent. If the non-persistent object is one of those
that is not allowed to become persistent, the commit will fail signaling
a TransactionError.

Regards,

-Martin
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Mariano Martinez Peck
In reply to this post by Dale Henrichs-3



- I really miss the #split: and #join: methods. Maybe these could be ported to GemStone? Or are there similar methods already?

I'm not familiar with split:/join: but would be in favor of having them added to the compat layer. It looks like  #split: has been added to the pharo compat layer in the GsPharo-Core package on GemSource[3] ... I think that I should move the GsPharo* packages onto the github repository to make it easy to contribute ...

The GsSqueakCommon* packages are for methods and classes that have identical implementations on both Squeak and Pharo. there are GsPharo-* and GsSqueak-* packages for methods and classes that are unique to each platform ...

If you are interested in adding #join: support, I'll move the GsPharo-* packages to the github repo ...

Dale

[3] http://seaside.gemtalksystems.com/ss/PharoCompat.html


Dale, I have ported the rest of the tests and protocols of #join: and #split: . All tests but one are green. I wanted to commit to such a repo but I don't have access. Could you please add me?


_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3
Before we go to far down any one path, let's coordinate with Johan, because he has additional pharo methods that he would like to share and I assume he started with the packages in PharoCompat so I would prefer to minimze the proliferation of packages to merge ...

If Johan thinks that putting your changes into PharoCompat makes sense, then go ahead and do so ...

In the mean time, I will add you to the glass developers team, which should give you write access to all of the relevant repos on GemSource ...

Have you registered on GemSource? I didn't find you there...

Dale


From: "Mariano Martinez Peck" <[hidden email]>
To: "Dale K. Henrichs" <[hidden email]>
Cc: [hidden email]
Sent: Friday, November 15, 2013 6:45:09 AM
Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)




- I really miss the #split: and #join: methods. Maybe these could be ported to GemStone? Or are there similar methods already?

I'm not familiar with split:/join: but would be in favor of having them added to the compat layer. It looks like  #split: has been added to the pharo compat layer in the GsPharo-Core package on GemSource[3] ... I think that I should move the GsPharo* packages onto the github repository to make it easy to contribute ...

The GsSqueakCommon* packages are for methods and classes that have identical implementations on both Squeak and Pharo. there are GsPharo-* and GsSqueak-* packages for methods and classes that are unique to each platform ...

If you are interested in adding #join: support, I'll move the GsPharo-* packages to the github repo ...

Dale

[3] http://seaside.gemtalksystems.com/ss/PharoCompat.html


Dale, I have ported the rest of the tests and protocols of #join: and #split: . All tests but one are green. I wanted to commit to such a repo but I don't have access. Could you please add me?



_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Johan Brichau-3
Dale, Mariano,

Indeed we need to sync :-)

Especially because I now realise that I have not been consistent. I added the packages Gettext and OrderPreservingDictionary to the Pharocompat repository [1] as Dale suggested a couple of years back (but most of the other packages I never touched -- they are included in GLASS).

The reason I started the PharoCompatibility repository [2] on github was actually more motivated by the fact that github is more convenient for working together on a single code base (using pull requests, travis etc.) and the fact that I wanted a good place to host code to improve on the 'develop in Pharo, deploy in Gemstone' experience. I was not sure if that would need to be in GLASS directly.

I'm more in favour of using a github repository (a new one would be fine too) but I guess it depends if we want the code to be in GLASS immediately or as an add-on. The latter would be feasible but I'm guessing Dale is not quite ready to include github-hosted repositories in the GLASS codebase.

What are your opinions?

[1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
[2] https://github.com/jbrichau/PharoCompatibility

On 15 Nov 2013, at 17:53, Dale K. Henrichs <[hidden email]> wrote:

> Before we go to far down any one path, let's coordinate with Johan, because he has additional pharo methods that he would like to share and I assume he started with the packages in PharoCompat so I would prefer to minimze the proliferation of packages to merge ...
>
> If Johan thinks that putting your changes into PharoCompat makes sense, then go ahead and do so ...
>
> In the mean time, I will add you to the glass developers team, which should give you write access to all of the relevant repos on GemSource ...
>
> Have you registered on GemSource? I didn't find you there...
>
> Dale
>
> From: "Mariano Martinez Peck" <[hidden email]>
> To: "Dale K. Henrichs" <[hidden email]>
> Cc: [hidden email]
> Sent: Friday, November 15, 2013 6:45:09 AM
> Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
>
>
>
>
> - I really miss the #split: and #join: methods. Maybe these could be ported to GemStone? Or are there similar methods already?
>
> I'm not familiar with split:/join: but would be in favor of having them added to the compat layer. It looks like  #split: has been added to the pharo compat layer in the GsPharo-Core package on GemSource[3] ... I think that I should move the GsPharo* packages onto the github repository to make it easy to contribute ...
>
> The GsSqueakCommon* packages are for methods and classes that have identical implementations on both Squeak and Pharo. there are GsPharo-* and GsSqueak-* packages for methods and classes that are unique to each platform ...
>
> If you are interested in adding #join: support, I'll move the GsPharo-* packages to the github repo ...
>
> Dale
>
> [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
>
>
> Dale, I have ported the rest of the tests and protocols of #join: and #split: . All tests but one are green. I wanted to commit to such a repo but I don't have access. Could you please add me?
>
> Thanks,
>
>
>
> --
> Mariano
> http://marianopeck.wordpress.com
>
> _______________________________________________
> Glass mailing list
> [hidden email]
> http://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3
Johan,

I am heading in the direction of putting all of the GLASS (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related repositories on github, so that would be my preference for moving forward...

The sharing part is the most important and I think Gitub/git is the most powerfull combo for collaboration...

I can fork you library on glassdb and that way you won't be the bottleneck for pull requests and then Mariano can fork the glassdb repo and we can be off to the races ...

Dale

----- Original Message -----
| From: "Johan Brichau" <[hidden email]>
| To: "Dale K. Henrichs" <[hidden email]>
| Cc: "Mariano Martinez Peck" <[hidden email]>, [hidden email]
| Sent: Friday, November 15, 2013 10:59:47 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
| Dale, Mariano,
|
| Indeed we need to sync :-)
|
| Especially because I now realise that I have not been consistent. I
| added the packages Gettext and OrderPreservingDictionary to the
| Pharocompat repository [1] as Dale suggested a couple of years back
| (but most of the other packages I never touched -- they are included
| in GLASS).
|
| The reason I started the PharoCompatibility repository [2] on github
| was actually more motivated by the fact that github is more
| convenient for working together on a single code base (using pull
| requests, travis etc.) and the fact that I wanted a good place to
| host code to improve on the 'develop in Pharo, deploy in Gemstone'
| experience. I was not sure if that would need to be in GLASS
| directly.
|
| I'm more in favour of using a github repository (a new one would be
| fine too) but I guess it depends if we want the code to be in GLASS
| immediately or as an add-on. The latter would be feasible but I'm
| guessing Dale is not quite ready to include github-hosted
| repositories in the GLASS codebase.
|
| What are your opinions?
|
| [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| [2] https://github.com/jbrichau/PharoCompatibility
|
| On 15 Nov 2013, at 17:53, Dale K. Henrichs
| <[hidden email]> wrote:
|
| > Before we go to far down any one path, let's coordinate with Johan,
| > because he has additional pharo methods that he would like to
| > share and I assume he started with the packages in PharoCompat so
| > I would prefer to minimze the proliferation of packages to merge
| > ...
| >
| > If Johan thinks that putting your changes into PharoCompat makes
| > sense, then go ahead and do so ...
| >
| > In the mean time, I will add you to the glass developers team,
| > which should give you write access to all of the relevant repos on
| > GemSource ...
| >
| > Have you registered on GemSource? I didn't find you there...
| >
| > Dale
| >
| > From: "Mariano Martinez Peck" <[hidden email]>
| > To: "Dale K. Henrichs" <[hidden email]>
| > Cc: [hidden email]
| > Sent: Friday, November 15, 2013 6:45:09 AM
| > Subject: Re: [Glass] Simple questions while migrating code to
| > GemStone (compatibility issues)
| >
| >
| >
| >
| > - I really miss the #split: and #join: methods. Maybe these could
| > be ported to GemStone? Or are there similar methods already?
| >
| > I'm not familiar with split:/join: but would be in favor of having
| > them added to the compat layer. It looks like  #split: has been
| > added to the pharo compat layer in the GsPharo-Core package on
| > GemSource[3] ... I think that I should move the GsPharo* packages
| > onto the github repository to make it easy to contribute ...
| >
| > The GsSqueakCommon* packages are for methods and classes that have
| > identical implementations on both Squeak and Pharo. there are
| > GsPharo-* and GsSqueak-* packages for methods and classes that are
| > unique to each platform ...
| >
| > If you are interested in adding #join: support, I'll move the
| > GsPharo-* packages to the github repo ...
| >
| > Dale
| >
| > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| >
| >
| > Dale, I have ported the rest of the tests and protocols of #join:
| > and #split: . All tests but one are green. I wanted to commit to
| > such a repo but I don't have access. Could you please add me?
| >
| > Thanks,
| >
| >
| >
| > --
| > Mariano
| > http://marianopeck.wordpress.com
| >
| > _______________________________________________
| > Glass mailing list
| > [hidden email]
| > http://lists.gemtalksystems.com/mailman/listinfo/glass
|
|
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Mariano Martinez Peck
Hi guys,

For me it is the same. I am new here, so I let you choose. Just let me know what do I clone, where do I commit and I start :)

Thanks!


On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs <[hidden email]> wrote:
Johan,

I am heading in the direction of putting all of the GLASS (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related repositories on github, so that would be my preference for moving forward...

The sharing part is the most important and I think Gitub/git is the most powerfull combo for collaboration...

I can fork you library on glassdb and that way you won't be the bottleneck for pull requests and then Mariano can fork the glassdb repo and we can be off to the races ...

Dale

----- Original Message -----
| From: "Johan Brichau" <[hidden email]>
| To: "Dale K. Henrichs" <[hidden email]>
| Cc: "Mariano Martinez Peck" <[hidden email]>, [hidden email]
| Sent: Friday, November 15, 2013 10:59:47 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
| Dale, Mariano,
|
| Indeed we need to sync :-)
|
| Especially because I now realise that I have not been consistent. I
| added the packages Gettext and OrderPreservingDictionary to the
| Pharocompat repository [1] as Dale suggested a couple of years back
| (but most of the other packages I never touched -- they are included
| in GLASS).
|
| The reason I started the PharoCompatibility repository [2] on github
| was actually more motivated by the fact that github is more
| convenient for working together on a single code base (using pull
| requests, travis etc.) and the fact that I wanted a good place to
| host code to improve on the 'develop in Pharo, deploy in Gemstone'
| experience. I was not sure if that would need to be in GLASS
| directly.
|
| I'm more in favour of using a github repository (a new one would be
| fine too) but I guess it depends if we want the code to be in GLASS
| immediately or as an add-on. The latter would be feasible but I'm
| guessing Dale is not quite ready to include github-hosted
| repositories in the GLASS codebase.
|
| What are your opinions?
|
| [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| [2] https://github.com/jbrichau/PharoCompatibility
|
| On 15 Nov 2013, at 17:53, Dale K. Henrichs
| <[hidden email]> wrote:
|
| > Before we go to far down any one path, let's coordinate with Johan,
| > because he has additional pharo methods that he would like to
| > share and I assume he started with the packages in PharoCompat so
| > I would prefer to minimze the proliferation of packages to merge
| > ...
| >
| > If Johan thinks that putting your changes into PharoCompat makes
| > sense, then go ahead and do so ...
| >
| > In the mean time, I will add you to the glass developers team,
| > which should give you write access to all of the relevant repos on
| > GemSource ...
| >
| > Have you registered on GemSource? I didn't find you there...
| >
| > Dale
| >
| > From: "Mariano Martinez Peck" <[hidden email]>
| > To: "Dale K. Henrichs" <[hidden email]>
| > Cc: [hidden email]
| > Sent: Friday, November 15, 2013 6:45:09 AM
| > Subject: Re: [Glass] Simple questions while migrating code to
| > GemStone (compatibility issues)
| >
| >
| >
| >
| > - I really miss the #split: and #join: methods. Maybe these could
| > be ported to GemStone? Or are there similar methods already?
| >
| > I'm not familiar with split:/join: but would be in favor of having
| > them added to the compat layer. It looks like  #split: has been
| > added to the pharo compat layer in the GsPharo-Core package on
| > GemSource[3] ... I think that I should move the GsPharo* packages
| > onto the github repository to make it easy to contribute ...
| >
| > The GsSqueakCommon* packages are for methods and classes that have
| > identical implementations on both Squeak and Pharo. there are
| > GsPharo-* and GsSqueak-* packages for methods and classes that are
| > unique to each platform ...
| >
| > If you are interested in adding #join: support, I'll move the
| > GsPharo-* packages to the github repo ...
| >
| > Dale
| >
| > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| >
| >
| > Dale, I have ported the rest of the tests and protocols of #join:
| > and #split: . All tests but one are green. I wanted to commit to
| > such a repo but I don't have access. Could you please add me?
| >
| > Thanks,
| >
| >
| >
| > --
| > Mariano
| > http://marianopeck.wordpress.com
| >
| > _______________________________________________
| > Glass mailing list
| > [hidden email]
| > http://lists.gemtalksystems.com/mailman/listinfo/glass
|
|



--
Mariano
http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Johan Brichau-3
Ok guys,

In that case, I think I will create a new repository in glassdb and just commit all the code we have over there.
The reason is that I will want to fork that repository myself and contribute like that.
Perhaps I'm old-fashioned but I prefer the <master> repository to be the glassdb one.

I'm taking care of it right away!

Johan

On 16 Nov 2013, at 00:08, Mariano Martinez Peck <[hidden email]> wrote:

> Hi guys,
>
> For me it is the same. I am new here, so I let you choose. Just let me know what do I clone, where do I commit and I start :)
>
> Thanks!
>
>
> On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs <[hidden email]> wrote:
> Johan,
>
> I am heading in the direction of putting all of the GLASS (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related repositories on github, so that would be my preference for moving forward...
>
> The sharing part is the most important and I think Gitub/git is the most powerfull combo for collaboration...
>
> I can fork you library on glassdb and that way you won't be the bottleneck for pull requests and then Mariano can fork the glassdb repo and we can be off to the races ...
>
> Dale
>
> ----- Original Message -----
> | From: "Johan Brichau" <[hidden email]>
> | To: "Dale K. Henrichs" <[hidden email]>
> | Cc: "Mariano Martinez Peck" <[hidden email]>, [hidden email]
> | Sent: Friday, November 15, 2013 10:59:47 AM
> | Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
> |
> | Dale, Mariano,
> |
> | Indeed we need to sync :-)
> |
> | Especially because I now realise that I have not been consistent. I
> | added the packages Gettext and OrderPreservingDictionary to the
> | Pharocompat repository [1] as Dale suggested a couple of years back
> | (but most of the other packages I never touched -- they are included
> | in GLASS).
> |
> | The reason I started the PharoCompatibility repository [2] on github
> | was actually more motivated by the fact that github is more
> | convenient for working together on a single code base (using pull
> | requests, travis etc.) and the fact that I wanted a good place to
> | host code to improve on the 'develop in Pharo, deploy in Gemstone'
> | experience. I was not sure if that would need to be in GLASS
> | directly.
> |
> | I'm more in favour of using a github repository (a new one would be
> | fine too) but I guess it depends if we want the code to be in GLASS
> | immediately or as an add-on. The latter would be feasible but I'm
> | guessing Dale is not quite ready to include github-hosted
> | repositories in the GLASS codebase.
> |
> | What are your opinions?
> |
> | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | [2] https://github.com/jbrichau/PharoCompatibility
> |
> | On 15 Nov 2013, at 17:53, Dale K. Henrichs
> | <[hidden email]> wrote:
> |
> | > Before we go to far down any one path, let's coordinate with Johan,
> | > because he has additional pharo methods that he would like to
> | > share and I assume he started with the packages in PharoCompat so
> | > I would prefer to minimze the proliferation of packages to merge
> | > ...
> | >
> | > If Johan thinks that putting your changes into PharoCompat makes
> | > sense, then go ahead and do so ...
> | >
> | > In the mean time, I will add you to the glass developers team,
> | > which should give you write access to all of the relevant repos on
> | > GemSource ...
> | >
> | > Have you registered on GemSource? I didn't find you there...
> | >
> | > Dale
> | >
> | > From: "Mariano Martinez Peck" <[hidden email]>
> | > To: "Dale K. Henrichs" <[hidden email]>
> | > Cc: [hidden email]
> | > Sent: Friday, November 15, 2013 6:45:09 AM
> | > Subject: Re: [Glass] Simple questions while migrating code to
> | > GemStone (compatibility issues)
> | >
> | >
> | >
> | >
> | > - I really miss the #split: and #join: methods. Maybe these could
> | > be ported to GemStone? Or are there similar methods already?
> | >
> | > I'm not familiar with split:/join: but would be in favor of having
> | > them added to the compat layer. It looks like  #split: has been
> | > added to the pharo compat layer in the GsPharo-Core package on
> | > GemSource[3] ... I think that I should move the GsPharo* packages
> | > onto the github repository to make it easy to contribute ...
> | >
> | > The GsSqueakCommon* packages are for methods and classes that have
> | > identical implementations on both Squeak and Pharo. there are
> | > GsPharo-* and GsSqueak-* packages for methods and classes that are
> | > unique to each platform ...
> | >
> | > If you are interested in adding #join: support, I'll move the
> | > GsPharo-* packages to the github repo ...
> | >
> | > Dale
> | >
> | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | >
> | >
> | > Dale, I have ported the rest of the tests and protocols of #join:
> | > and #split: . All tests but one are green. I wanted to commit to
> | > such a repo but I don't have access. Could you please add me?
> | >
> | > Thanks,
> | >
> | >
> | >
> | > --
> | > Mariano
> | > http://marianopeck.wordpress.com
> | >
> | > _______________________________________________
> | > Glass mailing list
> | > [hidden email]
> | > http://lists.gemtalksystems.com/mailman/listinfo/glass
> |
> |
>
>
>
> --
> Mariano
> http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Johan Brichau-3
In reply to this post by Dale Henrichs-3

On 15 Nov 2013, at 23:52, Dale K. Henrichs <[hidden email]> wrote:

> GLASS (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?)

Are you looking for a new name? I prefer the GsWebEdition one ;-)
Or is the gemstone web edition also supposed to run without the GLASS code base?

Johan
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3
Johan,

Yes, I'm looking for a new name for GLASS ... GsWebEdition is good, but the GLASS1 package isn't necessarily web only, i.e., Seaside isn't included in the default install (which is why GLASS isn't so good) ...

Another name that has been mentioned is GsFreeEdition since ... well that's what it is:)...

Suggestions are welcome ...

Dale

----- Original Message -----
| From: "Johan Brichau" <[hidden email]>
| To: "Dale K. Henrichs" <[hidden email]>
| Cc: "Mariano Martinez Peck" <[hidden email]>, [hidden email]
| Sent: Saturday, November 16, 2013 1:56:54 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
|
| On 15 Nov 2013, at 23:52, Dale K. Henrichs
| <[hidden email]> wrote:
|
| > GLASS (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?)
|
| Are you looking for a new name? I prefer the GsWebEdition one ;-)
| Or is the gemstone web edition also supposed to run without the GLASS
| code base?
|
| Johan
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3
In reply to this post by Johan Brichau-3
Excellent!

----- Original Message -----
| From: "Johan Brichau" <[hidden email]>
| To: "Mariano Martinez Peck" <[hidden email]>
| Cc: "Dale K. Henrichs" <[hidden email]>, [hidden email]
| Sent: Saturday, November 16, 2013 1:46:55 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
| Ok guys,
|
| In that case, I think I will create a new repository in glassdb and
| just commit all the code we have over there.
| The reason is that I will want to fork that repository myself and
| contribute like that.
| Perhaps I'm old-fashioned but I prefer the <master> repository to be
| the glassdb one.
|
| I'm taking care of it right away!
|
| Johan
|
| On 16 Nov 2013, at 00:08, Mariano Martinez Peck
| <[hidden email]> wrote:
|
| > Hi guys,
| >
| > For me it is the same. I am new here, so I let you choose. Just let
| > me know what do I clone, where do I commit and I start :)
| >
| > Thanks!
| >
| >
| > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
| > <[hidden email]> wrote:
| > Johan,
| >
| > I am heading in the direction of putting all of the GLASS
| > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
| > repositories on github, so that would be my preference for moving
| > forward...
| >
| > The sharing part is the most important and I think Gitub/git is the
| > most powerfull combo for collaboration...
| >
| > I can fork you library on glassdb and that way you won't be the
| > bottleneck for pull requests and then Mariano can fork the glassdb
| > repo and we can be off to the races ...
| >
| > Dale
| >
| > ----- Original Message -----
| > | From: "Johan Brichau" <[hidden email]>
| > | To: "Dale K. Henrichs" <[hidden email]>
| > | Cc: "Mariano Martinez Peck" <[hidden email]>,
| > | [hidden email]
| > | Sent: Friday, November 15, 2013 10:59:47 AM
| > | Subject: Re: [Glass] Simple questions while migrating code to
| > | GemStone (compatibility issues)
| > |
| > | Dale, Mariano,
| > |
| > | Indeed we need to sync :-)
| > |
| > | Especially because I now realise that I have not been consistent.
| > | I
| > | added the packages Gettext and OrderPreservingDictionary to the
| > | Pharocompat repository [1] as Dale suggested a couple of years
| > | back
| > | (but most of the other packages I never touched -- they are
| > | included
| > | in GLASS).
| > |
| > | The reason I started the PharoCompatibility repository [2] on
| > | github
| > | was actually more motivated by the fact that github is more
| > | convenient for working together on a single code base (using pull
| > | requests, travis etc.) and the fact that I wanted a good place to
| > | host code to improve on the 'develop in Pharo, deploy in
| > | Gemstone'
| > | experience. I was not sure if that would need to be in GLASS
| > | directly.
| > |
| > | I'm more in favour of using a github repository (a new one would
| > | be
| > | fine too) but I guess it depends if we want the code to be in
| > | GLASS
| > | immediately or as an add-on. The latter would be feasible but I'm
| > | guessing Dale is not quite ready to include github-hosted
| > | repositories in the GLASS codebase.
| > |
| > | What are your opinions?
| > |
| > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| > | [2] https://github.com/jbrichau/PharoCompatibility
| > |
| > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
| > | <[hidden email]> wrote:
| > |
| > | > Before we go to far down any one path, let's coordinate with
| > | > Johan,
| > | > because he has additional pharo methods that he would like to
| > | > share and I assume he started with the packages in PharoCompat
| > | > so
| > | > I would prefer to minimze the proliferation of packages to
| > | > merge
| > | > ...
| > | >
| > | > If Johan thinks that putting your changes into PharoCompat
| > | > makes
| > | > sense, then go ahead and do so ...
| > | >
| > | > In the mean time, I will add you to the glass developers team,
| > | > which should give you write access to all of the relevant repos
| > | > on
| > | > GemSource ...
| > | >
| > | > Have you registered on GemSource? I didn't find you there...
| > | >
| > | > Dale
| > | >
| > | > From: "Mariano Martinez Peck" <[hidden email]>
| > | > To: "Dale K. Henrichs" <[hidden email]>
| > | > Cc: [hidden email]
| > | > Sent: Friday, November 15, 2013 6:45:09 AM
| > | > Subject: Re: [Glass] Simple questions while migrating code to
| > | > GemStone (compatibility issues)
| > | >
| > | >
| > | >
| > | >
| > | > - I really miss the #split: and #join: methods. Maybe these
| > | > could
| > | > be ported to GemStone? Or are there similar methods already?
| > | >
| > | > I'm not familiar with split:/join: but would be in favor of
| > | > having
| > | > them added to the compat layer. It looks like  #split: has been
| > | > added to the pharo compat layer in the GsPharo-Core package on
| > | > GemSource[3] ... I think that I should move the GsPharo*
| > | > packages
| > | > onto the github repository to make it easy to contribute ...
| > | >
| > | > The GsSqueakCommon* packages are for methods and classes that
| > | > have
| > | > identical implementations on both Squeak and Pharo. there are
| > | > GsPharo-* and GsSqueak-* packages for methods and classes that
| > | > are
| > | > unique to each platform ...
| > | >
| > | > If you are interested in adding #join: support, I'll move the
| > | > GsPharo-* packages to the github repo ...
| > | >
| > | > Dale
| > | >
| > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| > | >
| > | >
| > | > Dale, I have ported the rest of the tests and protocols of
| > | > #join:
| > | > and #split: . All tests but one are green. I wanted to commit
| > | > to
| > | > such a repo but I don't have access. Could you please add me?
| > | >
| > | > Thanks,
| > | >
| > | >
| > | >
| > | > --
| > | > Mariano
| > | > http://marianopeck.wordpress.com
| > | >
| > | > _______________________________________________
| > | > Glass mailing list
| > | > [hidden email]
| > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
| > |
| > |
| >
| >
| >
| > --
| > Mariano
| > http://marianopeck.wordpress.com
|
|
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Johan Brichau-3
Mariano, Dale,

I set up a new repository and copied in our port of the multilingual textconversion package (aka text encoding conversion) of Pharo.

https://github.com/glassdb/PharoCompatibility

For this repo and send pull requests to merge things in.
I did the same and will add code via our fork.

Off to the races! ;-)
Johan

On 16 Nov 2013, at 19:46, Dale K. Henrichs <[hidden email]> wrote:

> Excellent!
>
> ----- Original Message -----
> | From: "Johan Brichau" <[hidden email]>
> | To: "Mariano Martinez Peck" <[hidden email]>
> | Cc: "Dale K. Henrichs" <[hidden email]>, [hidden email]
> | Sent: Saturday, November 16, 2013 1:46:55 AM
> | Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
> |
> | Ok guys,
> |
> | In that case, I think I will create a new repository in glassdb and
> | just commit all the code we have over there.
> | The reason is that I will want to fork that repository myself and
> | contribute like that.
> | Perhaps I'm old-fashioned but I prefer the <master> repository to be
> | the glassdb one.
> |
> | I'm taking care of it right away!
> |
> | Johan
> |
> | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
> | <[hidden email]> wrote:
> |
> | > Hi guys,
> | >
> | > For me it is the same. I am new here, so I let you choose. Just let
> | > me know what do I clone, where do I commit and I start :)
> | >
> | > Thanks!
> | >
> | >
> | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
> | > <[hidden email]> wrote:
> | > Johan,
> | >
> | > I am heading in the direction of putting all of the GLASS
> | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
> | > repositories on github, so that would be my preference for moving
> | > forward...
> | >
> | > The sharing part is the most important and I think Gitub/git is the
> | > most powerfull combo for collaboration...
> | >
> | > I can fork you library on glassdb and that way you won't be the
> | > bottleneck for pull requests and then Mariano can fork the glassdb
> | > repo and we can be off to the races ...
> | >
> | > Dale
> | >
> | > ----- Original Message -----
> | > | From: "Johan Brichau" <[hidden email]>
> | > | To: "Dale K. Henrichs" <[hidden email]>
> | > | Cc: "Mariano Martinez Peck" <[hidden email]>,
> | > | [hidden email]
> | > | Sent: Friday, November 15, 2013 10:59:47 AM
> | > | Subject: Re: [Glass] Simple questions while migrating code to
> | > | GemStone (compatibility issues)
> | > |
> | > | Dale, Mariano,
> | > |
> | > | Indeed we need to sync :-)
> | > |
> | > | Especially because I now realise that I have not been consistent.
> | > | I
> | > | added the packages Gettext and OrderPreservingDictionary to the
> | > | Pharocompat repository [1] as Dale suggested a couple of years
> | > | back
> | > | (but most of the other packages I never touched -- they are
> | > | included
> | > | in GLASS).
> | > |
> | > | The reason I started the PharoCompatibility repository [2] on
> | > | github
> | > | was actually more motivated by the fact that github is more
> | > | convenient for working together on a single code base (using pull
> | > | requests, travis etc.) and the fact that I wanted a good place to
> | > | host code to improve on the 'develop in Pharo, deploy in
> | > | Gemstone'
> | > | experience. I was not sure if that would need to be in GLASS
> | > | directly.
> | > |
> | > | I'm more in favour of using a github repository (a new one would
> | > | be
> | > | fine too) but I guess it depends if we want the code to be in
> | > | GLASS
> | > | immediately or as an add-on. The latter would be feasible but I'm
> | > | guessing Dale is not quite ready to include github-hosted
> | > | repositories in the GLASS codebase.
> | > |
> | > | What are your opinions?
> | > |
> | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | > | [2] https://github.com/jbrichau/PharoCompatibility
> | > |
> | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
> | > | <[hidden email]> wrote:
> | > |
> | > | > Before we go to far down any one path, let's coordinate with
> | > | > Johan,
> | > | > because he has additional pharo methods that he would like to
> | > | > share and I assume he started with the packages in PharoCompat
> | > | > so
> | > | > I would prefer to minimze the proliferation of packages to
> | > | > merge
> | > | > ...
> | > | >
> | > | > If Johan thinks that putting your changes into PharoCompat
> | > | > makes
> | > | > sense, then go ahead and do so ...
> | > | >
> | > | > In the mean time, I will add you to the glass developers team,
> | > | > which should give you write access to all of the relevant repos
> | > | > on
> | > | > GemSource ...
> | > | >
> | > | > Have you registered on GemSource? I didn't find you there...
> | > | >
> | > | > Dale
> | > | >
> | > | > From: "Mariano Martinez Peck" <[hidden email]>
> | > | > To: "Dale K. Henrichs" <[hidden email]>
> | > | > Cc: [hidden email]
> | > | > Sent: Friday, November 15, 2013 6:45:09 AM
> | > | > Subject: Re: [Glass] Simple questions while migrating code to
> | > | > GemStone (compatibility issues)
> | > | >
> | > | >
> | > | >
> | > | >
> | > | > - I really miss the #split: and #join: methods. Maybe these
> | > | > could
> | > | > be ported to GemStone? Or are there similar methods already?
> | > | >
> | > | > I'm not familiar with split:/join: but would be in favor of
> | > | > having
> | > | > them added to the compat layer. It looks like  #split: has been
> | > | > added to the pharo compat layer in the GsPharo-Core package on
> | > | > GemSource[3] ... I think that I should move the GsPharo*
> | > | > packages
> | > | > onto the github repository to make it easy to contribute ...
> | > | >
> | > | > The GsSqueakCommon* packages are for methods and classes that
> | > | > have
> | > | > identical implementations on both Squeak and Pharo. there are
> | > | > GsPharo-* and GsSqueak-* packages for methods and classes that
> | > | > are
> | > | > unique to each platform ...
> | > | >
> | > | > If you are interested in adding #join: support, I'll move the
> | > | > GsPharo-* packages to the github repo ...
> | > | >
> | > | > Dale
> | > | >
> | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | > | >
> | > | >
> | > | > Dale, I have ported the rest of the tests and protocols of
> | > | > #join:
> | > | > and #split: . All tests but one are green. I wanted to commit
> | > | > to
> | > | > such a repo but I don't have access. Could you please add me?
> | > | >
> | > | > Thanks,
> | > | >
> | > | >
> | > | >
> | > | > --
> | > | > Mariano
> | > | > http://marianopeck.wordpress.com
> | > | >
> | > | > _______________________________________________
> | > | > Glass mailing list
> | > | > [hidden email]
> | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
> | > |
> | > |
> | >
> | >
> | >
> | > --
> | > Mariano
> | > http://marianopeck.wordpress.com
> |
> |

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3
Great!

I'll spend some time and hook things up to travis and add a MIT license file ... which you will want to edit as a contributor ...

Dale

----- Original Message -----
| From: "Johan Brichau" <[hidden email]>
| To: "Dale K. Henrichs" <[hidden email]>
| Cc: [hidden email], "Mariano Martinez Peck" <[hidden email]>
| Sent: Sunday, November 17, 2013 2:16:38 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
| Mariano, Dale,
|
| I set up a new repository and copied in our port of the multilingual
| textconversion package (aka text encoding conversion) of Pharo.
|
| https://github.com/glassdb/PharoCompatibility
|
| For this repo and send pull requests to merge things in.
| I did the same and will add code via our fork.
|
| Off to the races! ;-)
| Johan
|
| On 16 Nov 2013, at 19:46, Dale K. Henrichs
| <[hidden email]> wrote:
|
| > Excellent!
| >
| > ----- Original Message -----
| > | From: "Johan Brichau" <[hidden email]>
| > | To: "Mariano Martinez Peck" <[hidden email]>
| > | Cc: "Dale K. Henrichs" <[hidden email]>,
| > | [hidden email]
| > | Sent: Saturday, November 16, 2013 1:46:55 AM
| > | Subject: Re: [Glass] Simple questions while migrating code to
| > | GemStone (compatibility issues)
| > |
| > | Ok guys,
| > |
| > | In that case, I think I will create a new repository in glassdb
| > | and
| > | just commit all the code we have over there.
| > | The reason is that I will want to fork that repository myself and
| > | contribute like that.
| > | Perhaps I'm old-fashioned but I prefer the <master> repository to
| > | be
| > | the glassdb one.
| > |
| > | I'm taking care of it right away!
| > |
| > | Johan
| > |
| > | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
| > | <[hidden email]> wrote:
| > |
| > | > Hi guys,
| > | >
| > | > For me it is the same. I am new here, so I let you choose. Just
| > | > let
| > | > me know what do I clone, where do I commit and I start :)
| > | >
| > | > Thanks!
| > | >
| > | >
| > | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
| > | > <[hidden email]> wrote:
| > | > Johan,
| > | >
| > | > I am heading in the direction of putting all of the GLASS
| > | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
| > | > repositories on github, so that would be my preference for
| > | > moving
| > | > forward...
| > | >
| > | > The sharing part is the most important and I think Gitub/git is
| > | > the
| > | > most powerfull combo for collaboration...
| > | >
| > | > I can fork you library on glassdb and that way you won't be the
| > | > bottleneck for pull requests and then Mariano can fork the
| > | > glassdb
| > | > repo and we can be off to the races ...
| > | >
| > | > Dale
| > | >
| > | > ----- Original Message -----
| > | > | From: "Johan Brichau" <[hidden email]>
| > | > | To: "Dale K. Henrichs" <[hidden email]>
| > | > | Cc: "Mariano Martinez Peck" <[hidden email]>,
| > | > | [hidden email]
| > | > | Sent: Friday, November 15, 2013 10:59:47 AM
| > | > | Subject: Re: [Glass] Simple questions while migrating code to
| > | > | GemStone (compatibility issues)
| > | > |
| > | > | Dale, Mariano,
| > | > |
| > | > | Indeed we need to sync :-)
| > | > |
| > | > | Especially because I now realise that I have not been
| > | > | consistent.
| > | > | I
| > | > | added the packages Gettext and OrderPreservingDictionary to
| > | > | the
| > | > | Pharocompat repository [1] as Dale suggested a couple of
| > | > | years
| > | > | back
| > | > | (but most of the other packages I never touched -- they are
| > | > | included
| > | > | in GLASS).
| > | > |
| > | > | The reason I started the PharoCompatibility repository [2] on
| > | > | github
| > | > | was actually more motivated by the fact that github is more
| > | > | convenient for working together on a single code base (using
| > | > | pull
| > | > | requests, travis etc.) and the fact that I wanted a good
| > | > | place to
| > | > | host code to improve on the 'develop in Pharo, deploy in
| > | > | Gemstone'
| > | > | experience. I was not sure if that would need to be in GLASS
| > | > | directly.
| > | > |
| > | > | I'm more in favour of using a github repository (a new one
| > | > | would
| > | > | be
| > | > | fine too) but I guess it depends if we want the code to be in
| > | > | GLASS
| > | > | immediately or as an add-on. The latter would be feasible but
| > | > | I'm
| > | > | guessing Dale is not quite ready to include github-hosted
| > | > | repositories in the GLASS codebase.
| > | > |
| > | > | What are your opinions?
| > | > |
| > | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| > | > | [2] https://github.com/jbrichau/PharoCompatibility
| > | > |
| > | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
| > | > | <[hidden email]> wrote:
| > | > |
| > | > | > Before we go to far down any one path, let's coordinate
| > | > | > with
| > | > | > Johan,
| > | > | > because he has additional pharo methods that he would like
| > | > | > to
| > | > | > share and I assume he started with the packages in
| > | > | > PharoCompat
| > | > | > so
| > | > | > I would prefer to minimze the proliferation of packages to
| > | > | > merge
| > | > | > ...
| > | > | >
| > | > | > If Johan thinks that putting your changes into PharoCompat
| > | > | > makes
| > | > | > sense, then go ahead and do so ...
| > | > | >
| > | > | > In the mean time, I will add you to the glass developers
| > | > | > team,
| > | > | > which should give you write access to all of the relevant
| > | > | > repos
| > | > | > on
| > | > | > GemSource ...
| > | > | >
| > | > | > Have you registered on GemSource? I didn't find you
| > | > | > there...
| > | > | >
| > | > | > Dale
| > | > | >
| > | > | > From: "Mariano Martinez Peck" <[hidden email]>
| > | > | > To: "Dale K. Henrichs" <[hidden email]>
| > | > | > Cc: [hidden email]
| > | > | > Sent: Friday, November 15, 2013 6:45:09 AM
| > | > | > Subject: Re: [Glass] Simple questions while migrating code
| > | > | > to
| > | > | > GemStone (compatibility issues)
| > | > | >
| > | > | >
| > | > | >
| > | > | >
| > | > | > - I really miss the #split: and #join: methods. Maybe these
| > | > | > could
| > | > | > be ported to GemStone? Or are there similar methods
| > | > | > already?
| > | > | >
| > | > | > I'm not familiar with split:/join: but would be in favor of
| > | > | > having
| > | > | > them added to the compat layer. It looks like  #split: has
| > | > | > been
| > | > | > added to the pharo compat layer in the GsPharo-Core package
| > | > | > on
| > | > | > GemSource[3] ... I think that I should move the GsPharo*
| > | > | > packages
| > | > | > onto the github repository to make it easy to contribute
| > | > | > ...
| > | > | >
| > | > | > The GsSqueakCommon* packages are for methods and classes
| > | > | > that
| > | > | > have
| > | > | > identical implementations on both Squeak and Pharo. there
| > | > | > are
| > | > | > GsPharo-* and GsSqueak-* packages for methods and classes
| > | > | > that
| > | > | > are
| > | > | > unique to each platform ...
| > | > | >
| > | > | > If you are interested in adding #join: support, I'll move
| > | > | > the
| > | > | > GsPharo-* packages to the github repo ...
| > | > | >
| > | > | > Dale
| > | > | >
| > | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| > | > | >
| > | > | >
| > | > | > Dale, I have ported the rest of the tests and protocols of
| > | > | > #join:
| > | > | > and #split: . All tests but one are green. I wanted to
| > | > | > commit
| > | > | > to
| > | > | > such a repo but I don't have access. Could you please add
| > | > | > me?
| > | > | >
| > | > | > Thanks,
| > | > | >
| > | > | >
| > | > | >
| > | > | > --
| > | > | > Mariano
| > | > | > http://marianopeck.wordpress.com
| > | > | >
| > | > | > _______________________________________________
| > | > | > Glass mailing list
| > | > | > [hidden email]
| > | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
| > | > |
| > | > |
| > | >
| > | >
| > | >
| > | > --
| > | > Mariano
| > | > http://marianopeck.wordpress.com
| > |
| > |
|
|
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Dale Henrichs-3
Johan,

I've moved the GsParo-Core packages into this repo, added a license (please add yourselves and/or correct as you see fit), and hooked up travis.

When running the tests there are some test errors and failures[1]. So either those are open issues or something else is up ... I will go ahead and push my changes into the glassdb repo and turn on travis there as well ...

Dale

[1] https://travis-ci.org/dalehenrich/PharoCompatibility/jobs/14104855#L126

----- Original Message -----
| From: "Dale K. Henrichs" <[hidden email]>
| To: "Johan Brichau" <[hidden email]>
| Cc: [hidden email], "Mariano Martinez Peck" <[hidden email]>
| Sent: Sunday, November 17, 2013 8:36:30 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
| Great!
|
| I'll spend some time and hook things up to travis and add a MIT
| license file ... which you will want to edit as a contributor ...
|
| Dale
|
| ----- Original Message -----
| | From: "Johan Brichau" <[hidden email]>
| | To: "Dale K. Henrichs" <[hidden email]>
| | Cc: [hidden email], "Mariano Martinez Peck"
| | <[hidden email]>
| | Sent: Sunday, November 17, 2013 2:16:38 AM
| | Subject: Re: [Glass] Simple questions while migrating code to
| | GemStone (compatibility issues)
| |
| | Mariano, Dale,
| |
| | I set up a new repository and copied in our port of the
| | multilingual
| | textconversion package (aka text encoding conversion) of Pharo.
| |
| | https://github.com/glassdb/PharoCompatibility
| |
| | For this repo and send pull requests to merge things in.
| | I did the same and will add code via our fork.
| |
| | Off to the races! ;-)
| | Johan
| |
| | On 16 Nov 2013, at 19:46, Dale K. Henrichs
| | <[hidden email]> wrote:
| |
| | > Excellent!
| | >
| | > ----- Original Message -----
| | > | From: "Johan Brichau" <[hidden email]>
| | > | To: "Mariano Martinez Peck" <[hidden email]>
| | > | Cc: "Dale K. Henrichs" <[hidden email]>,
| | > | [hidden email]
| | > | Sent: Saturday, November 16, 2013 1:46:55 AM
| | > | Subject: Re: [Glass] Simple questions while migrating code to
| | > | GemStone (compatibility issues)
| | > |
| | > | Ok guys,
| | > |
| | > | In that case, I think I will create a new repository in glassdb
| | > | and
| | > | just commit all the code we have over there.
| | > | The reason is that I will want to fork that repository myself
| | > | and
| | > | contribute like that.
| | > | Perhaps I'm old-fashioned but I prefer the <master> repository
| | > | to
| | > | be
| | > | the glassdb one.
| | > |
| | > | I'm taking care of it right away!
| | > |
| | > | Johan
| | > |
| | > | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
| | > | <[hidden email]> wrote:
| | > |
| | > | > Hi guys,
| | > | >
| | > | > For me it is the same. I am new here, so I let you choose.
| | > | > Just
| | > | > let
| | > | > me know what do I clone, where do I commit and I start :)
| | > | >
| | > | > Thanks!
| | > | >
| | > | >
| | > | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
| | > | > <[hidden email]> wrote:
| | > | > Johan,
| | > | >
| | > | > I am heading in the direction of putting all of the GLASS
| | > | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
| | > | > repositories on github, so that would be my preference for
| | > | > moving
| | > | > forward...
| | > | >
| | > | > The sharing part is the most important and I think Gitub/git
| | > | > is
| | > | > the
| | > | > most powerfull combo for collaboration...
| | > | >
| | > | > I can fork you library on glassdb and that way you won't be
| | > | > the
| | > | > bottleneck for pull requests and then Mariano can fork the
| | > | > glassdb
| | > | > repo and we can be off to the races ...
| | > | >
| | > | > Dale
| | > | >
| | > | > ----- Original Message -----
| | > | > | From: "Johan Brichau" <[hidden email]>
| | > | > | To: "Dale K. Henrichs" <[hidden email]>
| | > | > | Cc: "Mariano Martinez Peck" <[hidden email]>,
| | > | > | [hidden email]
| | > | > | Sent: Friday, November 15, 2013 10:59:47 AM
| | > | > | Subject: Re: [Glass] Simple questions while migrating code
| | > | > | to
| | > | > | GemStone (compatibility issues)
| | > | > |
| | > | > | Dale, Mariano,
| | > | > |
| | > | > | Indeed we need to sync :-)
| | > | > |
| | > | > | Especially because I now realise that I have not been
| | > | > | consistent.
| | > | > | I
| | > | > | added the packages Gettext and OrderPreservingDictionary to
| | > | > | the
| | > | > | Pharocompat repository [1] as Dale suggested a couple of
| | > | > | years
| | > | > | back
| | > | > | (but most of the other packages I never touched -- they are
| | > | > | included
| | > | > | in GLASS).
| | > | > |
| | > | > | The reason I started the PharoCompatibility repository [2]
| | > | > | on
| | > | > | github
| | > | > | was actually more motivated by the fact that github is more
| | > | > | convenient for working together on a single code base
| | > | > | (using
| | > | > | pull
| | > | > | requests, travis etc.) and the fact that I wanted a good
| | > | > | place to
| | > | > | host code to improve on the 'develop in Pharo, deploy in
| | > | > | Gemstone'
| | > | > | experience. I was not sure if that would need to be in
| | > | > | GLASS
| | > | > | directly.
| | > | > |
| | > | > | I'm more in favour of using a github repository (a new one
| | > | > | would
| | > | > | be
| | > | > | fine too) but I guess it depends if we want the code to be
| | > | > | in
| | > | > | GLASS
| | > | > | immediately or as an add-on. The latter would be feasible
| | > | > | but
| | > | > | I'm
| | > | > | guessing Dale is not quite ready to include github-hosted
| | > | > | repositories in the GLASS codebase.
| | > | > |
| | > | > | What are your opinions?
| | > | > |
| | > | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| | > | > | [2] https://github.com/jbrichau/PharoCompatibility
| | > | > |
| | > | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
| | > | > | <[hidden email]> wrote:
| | > | > |
| | > | > | > Before we go to far down any one path, let's coordinate
| | > | > | > with
| | > | > | > Johan,
| | > | > | > because he has additional pharo methods that he would
| | > | > | > like
| | > | > | > to
| | > | > | > share and I assume he started with the packages in
| | > | > | > PharoCompat
| | > | > | > so
| | > | > | > I would prefer to minimze the proliferation of packages
| | > | > | > to
| | > | > | > merge
| | > | > | > ...
| | > | > | >
| | > | > | > If Johan thinks that putting your changes into
| | > | > | > PharoCompat
| | > | > | > makes
| | > | > | > sense, then go ahead and do so ...
| | > | > | >
| | > | > | > In the mean time, I will add you to the glass developers
| | > | > | > team,
| | > | > | > which should give you write access to all of the relevant
| | > | > | > repos
| | > | > | > on
| | > | > | > GemSource ...
| | > | > | >
| | > | > | > Have you registered on GemSource? I didn't find you
| | > | > | > there...
| | > | > | >
| | > | > | > Dale
| | > | > | >
| | > | > | > From: "Mariano Martinez Peck" <[hidden email]>
| | > | > | > To: "Dale K. Henrichs" <[hidden email]>
| | > | > | > Cc: [hidden email]
| | > | > | > Sent: Friday, November 15, 2013 6:45:09 AM
| | > | > | > Subject: Re: [Glass] Simple questions while migrating
| | > | > | > code
| | > | > | > to
| | > | > | > GemStone (compatibility issues)
| | > | > | >
| | > | > | >
| | > | > | >
| | > | > | >
| | > | > | > - I really miss the #split: and #join: methods. Maybe
| | > | > | > these
| | > | > | > could
| | > | > | > be ported to GemStone? Or are there similar methods
| | > | > | > already?
| | > | > | >
| | > | > | > I'm not familiar with split:/join: but would be in favor
| | > | > | > of
| | > | > | > having
| | > | > | > them added to the compat layer. It looks like  #split:
| | > | > | > has
| | > | > | > been
| | > | > | > added to the pharo compat layer in the GsPharo-Core
| | > | > | > package
| | > | > | > on
| | > | > | > GemSource[3] ... I think that I should move the GsPharo*
| | > | > | > packages
| | > | > | > onto the github repository to make it easy to contribute
| | > | > | > ...
| | > | > | >
| | > | > | > The GsSqueakCommon* packages are for methods and classes
| | > | > | > that
| | > | > | > have
| | > | > | > identical implementations on both Squeak and Pharo. there
| | > | > | > are
| | > | > | > GsPharo-* and GsSqueak-* packages for methods and classes
| | > | > | > that
| | > | > | > are
| | > | > | > unique to each platform ...
| | > | > | >
| | > | > | > If you are interested in adding #join: support, I'll move
| | > | > | > the
| | > | > | > GsPharo-* packages to the github repo ...
| | > | > | >
| | > | > | > Dale
| | > | > | >
| | > | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| | > | > | >
| | > | > | >
| | > | > | > Dale, I have ported the rest of the tests and protocols
| | > | > | > of
| | > | > | > #join:
| | > | > | > and #split: . All tests but one are green. I wanted to
| | > | > | > commit
| | > | > | > to
| | > | > | > such a repo but I don't have access. Could you please add
| | > | > | > me?
| | > | > | >
| | > | > | > Thanks,
| | > | > | >
| | > | > | >
| | > | > | >
| | > | > | > --
| | > | > | > Mariano
| | > | > | > http://marianopeck.wordpress.com
| | > | > | >
| | > | > | > _______________________________________________
| | > | > | > Glass mailing list
| | > | > | > [hidden email]
| | > | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
| | > | > |
| | > | > |
| | > | >
| | > | >
| | > | >
| | > | > --
| | > | > Mariano
| | > | > http://marianopeck.wordpress.com
| | > |
| | > |
| |
| |
|
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Mariano Martinez Peck
HI guys,

I was planing to commit by Gs-Pharo-Core but I wonder...should I clone and commit directly, or fork and pull request? 
yes, git newbie here ;)

Just in case, we are talking about:


Cheers,


On Sun, Nov 17, 2013 at 3:18 PM, Dale K. Henrichs <[hidden email]> wrote:
Johan,

I've moved the GsParo-Core packages into this repo, added a license (please add yourselves and/or correct as you see fit), and hooked up travis.

When running the tests there are some test errors and failures[1]. So either those are open issues or something else is up ... I will go ahead and push my changes into the glassdb repo and turn on travis there as well ...

Dale

[1] https://travis-ci.org/dalehenrich/PharoCompatibility/jobs/14104855#L126

----- Original Message -----
| From: "Dale K. Henrichs" <[hidden email]>
| To: "Johan Brichau" <[hidden email]>
| Cc: [hidden email], "Mariano Martinez Peck" <[hidden email]>
| Sent: Sunday, November 17, 2013 8:36:30 AM
| Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
|
| Great!
|
| I'll spend some time and hook things up to travis and add a MIT
| license file ... which you will want to edit as a contributor ...
|
| Dale
|
| ----- Original Message -----
| | From: "Johan Brichau" <[hidden email]>
| | To: "Dale K. Henrichs" <[hidden email]>
| | Cc: [hidden email], "Mariano Martinez Peck"
| | <[hidden email]>
| | Sent: Sunday, November 17, 2013 2:16:38 AM
| | Subject: Re: [Glass] Simple questions while migrating code to
| | GemStone (compatibility issues)
| |
| | Mariano, Dale,
| |
| | I set up a new repository and copied in our port of the
| | multilingual
| | textconversion package (aka text encoding conversion) of Pharo.
| |
| | https://github.com/glassdb/PharoCompatibility
| |
| | For this repo and send pull requests to merge things in.
| | I did the same and will add code via our fork.
| |
| | Off to the races! ;-)
| | Johan
| |
| | On 16 Nov 2013, at 19:46, Dale K. Henrichs
| | <[hidden email]> wrote:
| |
| | > Excellent!
| | >
| | > ----- Original Message -----
| | > | From: "Johan Brichau" <[hidden email]>
| | > | To: "Mariano Martinez Peck" <[hidden email]>
| | > | Cc: "Dale K. Henrichs" <[hidden email]>,
| | > | [hidden email]
| | > | Sent: Saturday, November 16, 2013 1:46:55 AM
| | > | Subject: Re: [Glass] Simple questions while migrating code to
| | > | GemStone (compatibility issues)
| | > |
| | > | Ok guys,
| | > |
| | > | In that case, I think I will create a new repository in glassdb
| | > | and
| | > | just commit all the code we have over there.
| | > | The reason is that I will want to fork that repository myself
| | > | and
| | > | contribute like that.
| | > | Perhaps I'm old-fashioned but I prefer the <master> repository
| | > | to
| | > | be
| | > | the glassdb one.
| | > |
| | > | I'm taking care of it right away!
| | > |
| | > | Johan
| | > |
| | > | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
| | > | <[hidden email]> wrote:
| | > |
| | > | > Hi guys,
| | > | >
| | > | > For me it is the same. I am new here, so I let you choose.
| | > | > Just
| | > | > let
| | > | > me know what do I clone, where do I commit and I start :)
| | > | >
| | > | > Thanks!
| | > | >
| | > | >
| | > | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
| | > | > <[hidden email]> wrote:
| | > | > Johan,
| | > | >
| | > | > I am heading in the direction of putting all of the GLASS
| | > | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
| | > | > repositories on github, so that would be my preference for
| | > | > moving
| | > | > forward...
| | > | >
| | > | > The sharing part is the most important and I think Gitub/git
| | > | > is
| | > | > the
| | > | > most powerfull combo for collaboration...
| | > | >
| | > | > I can fork you library on glassdb and that way you won't be
| | > | > the
| | > | > bottleneck for pull requests and then Mariano can fork the
| | > | > glassdb
| | > | > repo and we can be off to the races ...
| | > | >
| | > | > Dale
| | > | >
| | > | > ----- Original Message -----
| | > | > | From: "Johan Brichau" <[hidden email]>
| | > | > | To: "Dale K. Henrichs" <[hidden email]>
| | > | > | Cc: "Mariano Martinez Peck" <[hidden email]>,
| | > | > | [hidden email]
| | > | > | Sent: Friday, November 15, 2013 10:59:47 AM
| | > | > | Subject: Re: [Glass] Simple questions while migrating code
| | > | > | to
| | > | > | GemStone (compatibility issues)
| | > | > |
| | > | > | Dale, Mariano,
| | > | > |
| | > | > | Indeed we need to sync :-)
| | > | > |
| | > | > | Especially because I now realise that I have not been
| | > | > | consistent.
| | > | > | I
| | > | > | added the packages Gettext and OrderPreservingDictionary to
| | > | > | the
| | > | > | Pharocompat repository [1] as Dale suggested a couple of
| | > | > | years
| | > | > | back
| | > | > | (but most of the other packages I never touched -- they are
| | > | > | included
| | > | > | in GLASS).
| | > | > |
| | > | > | The reason I started the PharoCompatibility repository [2]
| | > | > | on
| | > | > | github
| | > | > | was actually more motivated by the fact that github is more
| | > | > | convenient for working together on a single code base
| | > | > | (using
| | > | > | pull
| | > | > | requests, travis etc.) and the fact that I wanted a good
| | > | > | place to
| | > | > | host code to improve on the 'develop in Pharo, deploy in
| | > | > | Gemstone'
| | > | > | experience. I was not sure if that would need to be in
| | > | > | GLASS
| | > | > | directly.
| | > | > |
| | > | > | I'm more in favour of using a github repository (a new one
| | > | > | would
| | > | > | be
| | > | > | fine too) but I guess it depends if we want the code to be
| | > | > | in
| | > | > | GLASS
| | > | > | immediately or as an add-on. The latter would be feasible
| | > | > | but
| | > | > | I'm
| | > | > | guessing Dale is not quite ready to include github-hosted
| | > | > | repositories in the GLASS codebase.
| | > | > |
| | > | > | What are your opinions?
| | > | > |
| | > | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| | > | > | [2] https://github.com/jbrichau/PharoCompatibility
| | > | > |
| | > | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
| | > | > | <[hidden email]> wrote:
| | > | > |
| | > | > | > Before we go to far down any one path, let's coordinate
| | > | > | > with
| | > | > | > Johan,
| | > | > | > because he has additional pharo methods that he would
| | > | > | > like
| | > | > | > to
| | > | > | > share and I assume he started with the packages in
| | > | > | > PharoCompat
| | > | > | > so
| | > | > | > I would prefer to minimze the proliferation of packages
| | > | > | > to
| | > | > | > merge
| | > | > | > ...
| | > | > | >
| | > | > | > If Johan thinks that putting your changes into
| | > | > | > PharoCompat
| | > | > | > makes
| | > | > | > sense, then go ahead and do so ...
| | > | > | >
| | > | > | > In the mean time, I will add you to the glass developers
| | > | > | > team,
| | > | > | > which should give you write access to all of the relevant
| | > | > | > repos
| | > | > | > on
| | > | > | > GemSource ...
| | > | > | >
| | > | > | > Have you registered on GemSource? I didn't find you
| | > | > | > there...
| | > | > | >
| | > | > | > Dale
| | > | > | >
| | > | > | > From: "Mariano Martinez Peck" <[hidden email]>
| | > | > | > To: "Dale K. Henrichs" <[hidden email]>
| | > | > | > Cc: [hidden email]
| | > | > | > Sent: Friday, November 15, 2013 6:45:09 AM
| | > | > | > Subject: Re: [Glass] Simple questions while migrating
| | > | > | > code
| | > | > | > to
| | > | > | > GemStone (compatibility issues)
| | > | > | >
| | > | > | >
| | > | > | >
| | > | > | >
| | > | > | > - I really miss the #split: and #join: methods. Maybe
| | > | > | > these
| | > | > | > could
| | > | > | > be ported to GemStone? Or are there similar methods
| | > | > | > already?
| | > | > | >
| | > | > | > I'm not familiar with split:/join: but would be in favor
| | > | > | > of
| | > | > | > having
| | > | > | > them added to the compat layer. It looks like  #split:
| | > | > | > has
| | > | > | > been
| | > | > | > added to the pharo compat layer in the GsPharo-Core
| | > | > | > package
| | > | > | > on
| | > | > | > GemSource[3] ... I think that I should move the GsPharo*
| | > | > | > packages
| | > | > | > onto the github repository to make it easy to contribute
| | > | > | > ...
| | > | > | >
| | > | > | > The GsSqueakCommon* packages are for methods and classes
| | > | > | > that
| | > | > | > have
| | > | > | > identical implementations on both Squeak and Pharo. there
| | > | > | > are
| | > | > | > GsPharo-* and GsSqueak-* packages for methods and classes
| | > | > | > that
| | > | > | > are
| | > | > | > unique to each platform ...
| | > | > | >
| | > | > | > If you are interested in adding #join: support, I'll move
| | > | > | > the
| | > | > | > GsPharo-* packages to the github repo ...
| | > | > | >
| | > | > | > Dale
| | > | > | >
| | > | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
| | > | > | >
| | > | > | >
| | > | > | > Dale, I have ported the rest of the tests and protocols
| | > | > | > of
| | > | > | > #join:
| | > | > | > and #split: . All tests but one are green. I wanted to
| | > | > | > commit
| | > | > | > to
| | > | > | > such a repo but I don't have access. Could you please add
| | > | > | > me?
| | > | > | >
| | > | > | > Thanks,
| | > | > | >
| | > | > | >
| | > | > | >
| | > | > | > --
| | > | > | > Mariano
| | > | > | > http://marianopeck.wordpress.com
| | > | > | >
| | > | > | > _______________________________________________
| | > | > | > Glass mailing list
| | > | > | > [hidden email]
| | > | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
| | > | > |
| | > | > |
| | > | >
| | > | >
| | > | >
| | > | > --
| | > | > Mariano
| | > | > http://marianopeck.wordpress.com
| | > |
| | > |
| |
| |
|



--
Mariano
http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Johan Brichau-3
Hi Mariano,

Fork and pull request is the way to go.

thx
Johan

On 20 Nov 2013, at 19:50, Mariano Martinez Peck <[hidden email]> wrote:

> HI guys,
>
> I was planing to commit by Gs-Pharo-Core but I wonder...should I clone and commit directly, or fork and pull request?
> yes, git newbie here ;)
>
> Just in case, we are talking about:
>
> https://github.com/glassdb/PharoCompatibility
>
> Cheers,
>
>
> On Sun, Nov 17, 2013 at 3:18 PM, Dale K. Henrichs <[hidden email]> wrote:
> Johan,
>
> I've moved the GsParo-Core packages into this repo, added a license (please add yourselves and/or correct as you see fit), and hooked up travis.
>
> When running the tests there are some test errors and failures[1]. So either those are open issues or something else is up ... I will go ahead and push my changes into the glassdb repo and turn on travis there as well ...
>
> Dale
>
> [1] https://travis-ci.org/dalehenrich/PharoCompatibility/jobs/14104855#L126
>
> ----- Original Message -----
> | From: "Dale K. Henrichs" <[hidden email]>
> | To: "Johan Brichau" <[hidden email]>
> | Cc: [hidden email], "Mariano Martinez Peck" <[hidden email]>
> | Sent: Sunday, November 17, 2013 8:36:30 AM
> | Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
> |
> | Great!
> |
> | I'll spend some time and hook things up to travis and add a MIT
> | license file ... which you will want to edit as a contributor ...
> |
> | Dale
> |
> | ----- Original Message -----
> | | From: "Johan Brichau" <[hidden email]>
> | | To: "Dale K. Henrichs" <[hidden email]>
> | | Cc: [hidden email], "Mariano Martinez Peck"
> | | <[hidden email]>
> | | Sent: Sunday, November 17, 2013 2:16:38 AM
> | | Subject: Re: [Glass] Simple questions while migrating code to
> | | GemStone (compatibility issues)
> | |
> | | Mariano, Dale,
> | |
> | | I set up a new repository and copied in our port of the
> | | multilingual
> | | textconversion package (aka text encoding conversion) of Pharo.
> | |
> | | https://github.com/glassdb/PharoCompatibility
> | |
> | | For this repo and send pull requests to merge things in.
> | | I did the same and will add code via our fork.
> | |
> | | Off to the races! ;-)
> | | Johan
> | |
> | | On 16 Nov 2013, at 19:46, Dale K. Henrichs
> | | <[hidden email]> wrote:
> | |
> | | > Excellent!
> | | >
> | | > ----- Original Message -----
> | | > | From: "Johan Brichau" <[hidden email]>
> | | > | To: "Mariano Martinez Peck" <[hidden email]>
> | | > | Cc: "Dale K. Henrichs" <[hidden email]>,
> | | > | [hidden email]
> | | > | Sent: Saturday, November 16, 2013 1:46:55 AM
> | | > | Subject: Re: [Glass] Simple questions while migrating code to
> | | > | GemStone (compatibility issues)
> | | > |
> | | > | Ok guys,
> | | > |
> | | > | In that case, I think I will create a new repository in glassdb
> | | > | and
> | | > | just commit all the code we have over there.
> | | > | The reason is that I will want to fork that repository myself
> | | > | and
> | | > | contribute like that.
> | | > | Perhaps I'm old-fashioned but I prefer the <master> repository
> | | > | to
> | | > | be
> | | > | the glassdb one.
> | | > |
> | | > | I'm taking care of it right away!
> | | > |
> | | > | Johan
> | | > |
> | | > | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
> | | > | <[hidden email]> wrote:
> | | > |
> | | > | > Hi guys,
> | | > | >
> | | > | > For me it is the same. I am new here, so I let you choose.
> | | > | > Just
> | | > | > let
> | | > | > me know what do I clone, where do I commit and I start :)
> | | > | >
> | | > | > Thanks!
> | | > | >
> | | > | >
> | | > | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
> | | > | > <[hidden email]> wrote:
> | | > | > Johan,
> | | > | >
> | | > | > I am heading in the direction of putting all of the GLASS
> | | > | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
> | | > | > repositories on github, so that would be my preference for
> | | > | > moving
> | | > | > forward...
> | | > | >
> | | > | > The sharing part is the most important and I think Gitub/git
> | | > | > is
> | | > | > the
> | | > | > most powerfull combo for collaboration...
> | | > | >
> | | > | > I can fork you library on glassdb and that way you won't be
> | | > | > the
> | | > | > bottleneck for pull requests and then Mariano can fork the
> | | > | > glassdb
> | | > | > repo and we can be off to the races ...
> | | > | >
> | | > | > Dale
> | | > | >
> | | > | > ----- Original Message -----
> | | > | > | From: "Johan Brichau" <[hidden email]>
> | | > | > | To: "Dale K. Henrichs" <[hidden email]>
> | | > | > | Cc: "Mariano Martinez Peck" <[hidden email]>,
> | | > | > | [hidden email]
> | | > | > | Sent: Friday, November 15, 2013 10:59:47 AM
> | | > | > | Subject: Re: [Glass] Simple questions while migrating code
> | | > | > | to
> | | > | > | GemStone (compatibility issues)
> | | > | > |
> | | > | > | Dale, Mariano,
> | | > | > |
> | | > | > | Indeed we need to sync :-)
> | | > | > |
> | | > | > | Especially because I now realise that I have not been
> | | > | > | consistent.
> | | > | > | I
> | | > | > | added the packages Gettext and OrderPreservingDictionary to
> | | > | > | the
> | | > | > | Pharocompat repository [1] as Dale suggested a couple of
> | | > | > | years
> | | > | > | back
> | | > | > | (but most of the other packages I never touched -- they are
> | | > | > | included
> | | > | > | in GLASS).
> | | > | > |
> | | > | > | The reason I started the PharoCompatibility repository [2]
> | | > | > | on
> | | > | > | github
> | | > | > | was actually more motivated by the fact that github is more
> | | > | > | convenient for working together on a single code base
> | | > | > | (using
> | | > | > | pull
> | | > | > | requests, travis etc.) and the fact that I wanted a good
> | | > | > | place to
> | | > | > | host code to improve on the 'develop in Pharo, deploy in
> | | > | > | Gemstone'
> | | > | > | experience. I was not sure if that would need to be in
> | | > | > | GLASS
> | | > | > | directly.
> | | > | > |
> | | > | > | I'm more in favour of using a github repository (a new one
> | | > | > | would
> | | > | > | be
> | | > | > | fine too) but I guess it depends if we want the code to be
> | | > | > | in
> | | > | > | GLASS
> | | > | > | immediately or as an add-on. The latter would be feasible
> | | > | > | but
> | | > | > | I'm
> | | > | > | guessing Dale is not quite ready to include github-hosted
> | | > | > | repositories in the GLASS codebase.
> | | > | > |
> | | > | > | What are your opinions?
> | | > | > |
> | | > | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | | > | > | [2] https://github.com/jbrichau/PharoCompatibility
> | | > | > |
> | | > | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
> | | > | > | <[hidden email]> wrote:
> | | > | > |
> | | > | > | > Before we go to far down any one path, let's coordinate
> | | > | > | > with
> | | > | > | > Johan,
> | | > | > | > because he has additional pharo methods that he would
> | | > | > | > like
> | | > | > | > to
> | | > | > | > share and I assume he started with the packages in
> | | > | > | > PharoCompat
> | | > | > | > so
> | | > | > | > I would prefer to minimze the proliferation of packages
> | | > | > | > to
> | | > | > | > merge
> | | > | > | > ...
> | | > | > | >
> | | > | > | > If Johan thinks that putting your changes into
> | | > | > | > PharoCompat
> | | > | > | > makes
> | | > | > | > sense, then go ahead and do so ...
> | | > | > | >
> | | > | > | > In the mean time, I will add you to the glass developers
> | | > | > | > team,
> | | > | > | > which should give you write access to all of the relevant
> | | > | > | > repos
> | | > | > | > on
> | | > | > | > GemSource ...
> | | > | > | >
> | | > | > | > Have you registered on GemSource? I didn't find you
> | | > | > | > there...
> | | > | > | >
> | | > | > | > Dale
> | | > | > | >
> | | > | > | > From: "Mariano Martinez Peck" <[hidden email]>
> | | > | > | > To: "Dale K. Henrichs" <[hidden email]>
> | | > | > | > Cc: [hidden email]
> | | > | > | > Sent: Friday, November 15, 2013 6:45:09 AM
> | | > | > | > Subject: Re: [Glass] Simple questions while migrating
> | | > | > | > code
> | | > | > | > to
> | | > | > | > GemStone (compatibility issues)
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | > - I really miss the #split: and #join: methods. Maybe
> | | > | > | > these
> | | > | > | > could
> | | > | > | > be ported to GemStone? Or are there similar methods
> | | > | > | > already?
> | | > | > | >
> | | > | > | > I'm not familiar with split:/join: but would be in favor
> | | > | > | > of
> | | > | > | > having
> | | > | > | > them added to the compat layer. It looks like  #split:
> | | > | > | > has
> | | > | > | > been
> | | > | > | > added to the pharo compat layer in the GsPharo-Core
> | | > | > | > package
> | | > | > | > on
> | | > | > | > GemSource[3] ... I think that I should move the GsPharo*
> | | > | > | > packages
> | | > | > | > onto the github repository to make it easy to contribute
> | | > | > | > ...
> | | > | > | >
> | | > | > | > The GsSqueakCommon* packages are for methods and classes
> | | > | > | > that
> | | > | > | > have
> | | > | > | > identical implementations on both Squeak and Pharo. there
> | | > | > | > are
> | | > | > | > GsPharo-* and GsSqueak-* packages for methods and classes
> | | > | > | > that
> | | > | > | > are
> | | > | > | > unique to each platform ...
> | | > | > | >
> | | > | > | > If you are interested in adding #join: support, I'll move
> | | > | > | > the
> | | > | > | > GsPharo-* packages to the github repo ...
> | | > | > | >
> | | > | > | > Dale
> | | > | > | >
> | | > | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | | > | > | >
> | | > | > | >
> | | > | > | > Dale, I have ported the rest of the tests and protocols
> | | > | > | > of
> | | > | > | > #join:
> | | > | > | > and #split: . All tests but one are green. I wanted to
> | | > | > | > commit
> | | > | > | > to
> | | > | > | > such a repo but I don't have access. Could you please add
> | | > | > | > me?
> | | > | > | >
> | | > | > | > Thanks,
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | > --
> | | > | > | > Mariano
> | | > | > | > http://marianopeck.wordpress.com
> | | > | > | >
> | | > | > | > _______________________________________________
> | | > | > | > Glass mailing list
> | | > | > | > [hidden email]
> | | > | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
> | | > | > |
> | | > | > |
> | | > | >
> | | > | >
> | | > | >
> | | > | > --
> | | > | > Mariano
> | | > | > http://marianopeck.wordpress.com
> | | > |
> | | > |
> | |
> | |
> |
>
>
>
> --
> Mariano
> http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)

Mariano Martinez Peck
Ok. If everything was fine, I should have done a pull request with the finish of the #split: and #join: protocol and their tests. 

Please, I am still newbie with the integration of git and pharo, so let me know if it looks ok. If it is ok, I will try to add more stuff next week. But that needs some cleaning, a filter, and maybe write some tests...

Cheers, 


On Wed, Nov 20, 2013 at 4:18 PM, Johan Brichau <[hidden email]> wrote:
Hi Mariano,

Fork and pull request is the way to go.

thx
Johan

On 20 Nov 2013, at 19:50, Mariano Martinez Peck <[hidden email]> wrote:

> HI guys,
>
> I was planing to commit by Gs-Pharo-Core but I wonder...should I clone and commit directly, or fork and pull request?
> yes, git newbie here ;)
>
> Just in case, we are talking about:
>
> https://github.com/glassdb/PharoCompatibility
>
> Cheers,
>
>
> On Sun, Nov 17, 2013 at 3:18 PM, Dale K. Henrichs <[hidden email]> wrote:
> Johan,
>
> I've moved the GsParo-Core packages into this repo, added a license (please add yourselves and/or correct as you see fit), and hooked up travis.
>
> When running the tests there are some test errors and failures[1]. So either those are open issues or something else is up ... I will go ahead and push my changes into the glassdb repo and turn on travis there as well ...
>
> Dale
>
> [1] https://travis-ci.org/dalehenrich/PharoCompatibility/jobs/14104855#L126
>
> ----- Original Message -----
> | From: "Dale K. Henrichs" <[hidden email]>
> | To: "Johan Brichau" <[hidden email]>
> | Cc: [hidden email], "Mariano Martinez Peck" <[hidden email]>
> | Sent: Sunday, November 17, 2013 8:36:30 AM
> | Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
> |
> | Great!
> |
> | I'll spend some time and hook things up to travis and add a MIT
> | license file ... which you will want to edit as a contributor ...
> |
> | Dale
> |
> | ----- Original Message -----
> | | From: "Johan Brichau" <[hidden email]>
> | | To: "Dale K. Henrichs" <[hidden email]>
> | | Cc: [hidden email], "Mariano Martinez Peck"
> | | <[hidden email]>
> | | Sent: Sunday, November 17, 2013 2:16:38 AM
> | | Subject: Re: [Glass] Simple questions while migrating code to
> | | GemStone (compatibility issues)
> | |
> | | Mariano, Dale,
> | |
> | | I set up a new repository and copied in our port of the
> | | multilingual
> | | textconversion package (aka text encoding conversion) of Pharo.
> | |
> | | https://github.com/glassdb/PharoCompatibility
> | |
> | | For this repo and send pull requests to merge things in.
> | | I did the same and will add code via our fork.
> | |
> | | Off to the races! ;-)
> | | Johan
> | |
> | | On 16 Nov 2013, at 19:46, Dale K. Henrichs
> | | <[hidden email]> wrote:
> | |
> | | > Excellent!
> | | >
> | | > ----- Original Message -----
> | | > | From: "Johan Brichau" <[hidden email]>
> | | > | To: "Mariano Martinez Peck" <[hidden email]>
> | | > | Cc: "Dale K. Henrichs" <[hidden email]>,
> | | > | [hidden email]
> | | > | Sent: Saturday, November 16, 2013 1:46:55 AM
> | | > | Subject: Re: [Glass] Simple questions while migrating code to
> | | > | GemStone (compatibility issues)
> | | > |
> | | > | Ok guys,
> | | > |
> | | > | In that case, I think I will create a new repository in glassdb
> | | > | and
> | | > | just commit all the code we have over there.
> | | > | The reason is that I will want to fork that repository myself
> | | > | and
> | | > | contribute like that.
> | | > | Perhaps I'm old-fashioned but I prefer the <master> repository
> | | > | to
> | | > | be
> | | > | the glassdb one.
> | | > |
> | | > | I'm taking care of it right away!
> | | > |
> | | > | Johan
> | | > |
> | | > | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
> | | > | <[hidden email]> wrote:
> | | > |
> | | > | > Hi guys,
> | | > | >
> | | > | > For me it is the same. I am new here, so I let you choose.
> | | > | > Just
> | | > | > let
> | | > | > me know what do I clone, where do I commit and I start :)
> | | > | >
> | | > | > Thanks!
> | | > | >
> | | > | >
> | | > | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
> | | > | > <[hidden email]> wrote:
> | | > | > Johan,
> | | > | >
> | | > | > I am heading in the direction of putting all of the GLASS
> | | > | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
> | | > | > repositories on github, so that would be my preference for
> | | > | > moving
> | | > | > forward...
> | | > | >
> | | > | > The sharing part is the most important and I think Gitub/git
> | | > | > is
> | | > | > the
> | | > | > most powerfull combo for collaboration...
> | | > | >
> | | > | > I can fork you library on glassdb and that way you won't be
> | | > | > the
> | | > | > bottleneck for pull requests and then Mariano can fork the
> | | > | > glassdb
> | | > | > repo and we can be off to the races ...
> | | > | >
> | | > | > Dale
> | | > | >
> | | > | > ----- Original Message -----
> | | > | > | From: "Johan Brichau" <[hidden email]>
> | | > | > | To: "Dale K. Henrichs" <[hidden email]>
> | | > | > | Cc: "Mariano Martinez Peck" <[hidden email]>,
> | | > | > | [hidden email]
> | | > | > | Sent: Friday, November 15, 2013 10:59:47 AM
> | | > | > | Subject: Re: [Glass] Simple questions while migrating code
> | | > | > | to
> | | > | > | GemStone (compatibility issues)
> | | > | > |
> | | > | > | Dale, Mariano,
> | | > | > |
> | | > | > | Indeed we need to sync :-)
> | | > | > |
> | | > | > | Especially because I now realise that I have not been
> | | > | > | consistent.
> | | > | > | I
> | | > | > | added the packages Gettext and OrderPreservingDictionary to
> | | > | > | the
> | | > | > | Pharocompat repository [1] as Dale suggested a couple of
> | | > | > | years
> | | > | > | back
> | | > | > | (but most of the other packages I never touched -- they are
> | | > | > | included
> | | > | > | in GLASS).
> | | > | > |
> | | > | > | The reason I started the PharoCompatibility repository [2]
> | | > | > | on
> | | > | > | github
> | | > | > | was actually more motivated by the fact that github is more
> | | > | > | convenient for working together on a single code base
> | | > | > | (using
> | | > | > | pull
> | | > | > | requests, travis etc.) and the fact that I wanted a good
> | | > | > | place to
> | | > | > | host code to improve on the 'develop in Pharo, deploy in
> | | > | > | Gemstone'
> | | > | > | experience. I was not sure if that would need to be in
> | | > | > | GLASS
> | | > | > | directly.
> | | > | > |
> | | > | > | I'm more in favour of using a github repository (a new one
> | | > | > | would
> | | > | > | be
> | | > | > | fine too) but I guess it depends if we want the code to be
> | | > | > | in
> | | > | > | GLASS
> | | > | > | immediately or as an add-on. The latter would be feasible
> | | > | > | but
> | | > | > | I'm
> | | > | > | guessing Dale is not quite ready to include github-hosted
> | | > | > | repositories in the GLASS codebase.
> | | > | > |
> | | > | > | What are your opinions?
> | | > | > |
> | | > | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | | > | > | [2] https://github.com/jbrichau/PharoCompatibility
> | | > | > |
> | | > | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
> | | > | > | <[hidden email]> wrote:
> | | > | > |
> | | > | > | > Before we go to far down any one path, let's coordinate
> | | > | > | > with
> | | > | > | > Johan,
> | | > | > | > because he has additional pharo methods that he would
> | | > | > | > like
> | | > | > | > to
> | | > | > | > share and I assume he started with the packages in
> | | > | > | > PharoCompat
> | | > | > | > so
> | | > | > | > I would prefer to minimze the proliferation of packages
> | | > | > | > to
> | | > | > | > merge
> | | > | > | > ...
> | | > | > | >
> | | > | > | > If Johan thinks that putting your changes into
> | | > | > | > PharoCompat
> | | > | > | > makes
> | | > | > | > sense, then go ahead and do so ...
> | | > | > | >
> | | > | > | > In the mean time, I will add you to the glass developers
> | | > | > | > team,
> | | > | > | > which should give you write access to all of the relevant
> | | > | > | > repos
> | | > | > | > on
> | | > | > | > GemSource ...
> | | > | > | >
> | | > | > | > Have you registered on GemSource? I didn't find you
> | | > | > | > there...
> | | > | > | >
> | | > | > | > Dale
> | | > | > | >
> | | > | > | > From: "Mariano Martinez Peck" <[hidden email]>
> | | > | > | > To: "Dale K. Henrichs" <[hidden email]>
> | | > | > | > Cc: [hidden email]
> | | > | > | > Sent: Friday, November 15, 2013 6:45:09 AM
> | | > | > | > Subject: Re: [Glass] Simple questions while migrating
> | | > | > | > code
> | | > | > | > to
> | | > | > | > GemStone (compatibility issues)
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | > - I really miss the #split: and #join: methods. Maybe
> | | > | > | > these
> | | > | > | > could
> | | > | > | > be ported to GemStone? Or are there similar methods
> | | > | > | > already?
> | | > | > | >
> | | > | > | > I'm not familiar with split:/join: but would be in favor
> | | > | > | > of
> | | > | > | > having
> | | > | > | > them added to the compat layer. It looks like  #split:
> | | > | > | > has
> | | > | > | > been
> | | > | > | > added to the pharo compat layer in the GsPharo-Core
> | | > | > | > package
> | | > | > | > on
> | | > | > | > GemSource[3] ... I think that I should move the GsPharo*
> | | > | > | > packages
> | | > | > | > onto the github repository to make it easy to contribute
> | | > | > | > ...
> | | > | > | >
> | | > | > | > The GsSqueakCommon* packages are for methods and classes
> | | > | > | > that
> | | > | > | > have
> | | > | > | > identical implementations on both Squeak and Pharo. there
> | | > | > | > are
> | | > | > | > GsPharo-* and GsSqueak-* packages for methods and classes
> | | > | > | > that
> | | > | > | > are
> | | > | > | > unique to each platform ...
> | | > | > | >
> | | > | > | > If you are interested in adding #join: support, I'll move
> | | > | > | > the
> | | > | > | > GsPharo-* packages to the github repo ...
> | | > | > | >
> | | > | > | > Dale
> | | > | > | >
> | | > | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | | > | > | >
> | | > | > | >
> | | > | > | > Dale, I have ported the rest of the tests and protocols
> | | > | > | > of
> | | > | > | > #join:
> | | > | > | > and #split: . All tests but one are green. I wanted to
> | | > | > | > commit
> | | > | > | > to
> | | > | > | > such a repo but I don't have access. Could you please add
> | | > | > | > me?
> | | > | > | >
> | | > | > | > Thanks,
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | > --
> | | > | > | > Mariano
> | | > | > | > http://marianopeck.wordpress.com
> | | > | > | >
> | | > | > | > _______________________________________________
> | | > | > | > Glass mailing list
> | | > | > | > [hidden email]
> | | > | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
> | | > | > |
> | | > | > |
> | | > | >
> | | > | >
> | | > | >
> | | > | > --
> | | > | > Mariano
> | | > | > http://marianopeck.wordpress.com
> | | > |
> | | > |
> | |
> | |
> |
>
>
>
> --
> Mariano
> http://marianopeck.wordpress.com




--
Mariano
http://marianopeck.wordpress.com

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
12