Grease-Core-DaleHenrichs.36
Locked
 
|
Name: Grease-Core-DaleHenrichs.36
Author: DaleHenrichs Time: 12 May 2010, 5:00:48 pm UUID: 820d8e2d-bbd4-4c25-8c92-1b36139b4cac Ancestors: Grease-Core-pmm.35 The comment for Grease-Core-jok.34 says: "Use #reverse (ANSI) rather than #reversed" Yet in Pharo1.1, #reverse has been deprecated for SequenceableCollection... Since I was working on getting Seaside3.0 to load into Pharo1.1 without firing off deprecated warnings, I made this change and checked in Grease-Core-DaleHenrichs.36... I imagine that Pharo1.1 will end up favoring the ANSI variant in the end ... Dale _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
|
|
With the change below, Seaside30 loads into Pharo1.1 fine however there are a number of test failures and errors:
1605 run, 1571 passes, 2 expected failures, 13 failures, 19 errors, 0 unexpected passes Plus WAFileLibraryTest>>testCompileByteArrayAgain uses #reverse. The Slime tests were also tripping across #reverse deprecation warnings, but the for some reason, Monticello lost track of the changed method so I lost track of it, too --- the method was in the refactoring universe somewhere... I will be testing Seaside3.0.0-alpha5.12 on Squeak and then release the version ... Dale ----- "Dale Henrichs" <[hidden email]> wrote: | Name: Grease-Core-DaleHenrichs.36 | Author: DaleHenrichs | Time: 12 May 2010, 5:00:48 pm | UUID: 820d8e2d-bbd4-4c25-8c92-1b36139b4cac | Ancestors: Grease-Core-pmm.35 | | | The comment for Grease-Core-jok.34 says: | | "Use #reverse (ANSI) rather than #reversed" | | Yet in Pharo1.1, #reverse has been deprecated for | SequenceableCollection... Since I was working on getting Seaside3.0 to | load into Pharo1.1 without firing off deprecated warnings, I made this | change and checked in Grease-Core-DaleHenrichs.36... | | I imagine that Pharo1.1 will end up favoring the ANSI variant in the | end ... | | Dale | | _______________________________________________ | seaside-dev mailing list | [hidden email] | http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: Grease-Core-DaleHenrichs.36
|
|
In reply to this post by Dale
I sent a mail to the Pharo list asking to reconsider that change.
Lukas On 13 May 2010 02:07, Dale Henrichs <[hidden email]> wrote: > Name: Grease-Core-DaleHenrichs.36 > Author: DaleHenrichs > Time: 12 May 2010, 5:00:48 pm > UUID: 820d8e2d-bbd4-4c25-8c92-1b36139b4cac > Ancestors: Grease-Core-pmm.35 > > > The comment for Grease-Core-jok.34 says: > > "Use #reverse (ANSI) rather than #reversed" > > Yet in Pharo1.1, #reverse has been deprecated for SequenceableCollection... Since I was working on getting Seaside3.0 to load into Pharo1.1 without firing off deprecated warnings, I made this change and checked in Grease-Core-DaleHenrichs.36... > > I imagine that Pharo1.1 will end up favoring the ANSI variant in the end ... > > Dale > > _______________________________________________ > seaside-dev mailing list > [hidden email] > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > -- Lukas Renggli www.lukas-renggli.ch _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: Grease-Core-DaleHenrichs.36
|
|
Hmmm, rather odd that Pharo would deprecate an ANSI method. Thanks for following up on this.
On Thu, May 13, 2010 at 12:47 AM, Lukas Renggli <[hidden email]> wrote: I sent a mail to the Pharo list asking to reconsider that change. -- John O'Keefe [|], Principal Smalltalk Architect , Instantiations Inc. Mobile: +1 919 417-3181 (Business hours USA Eastern Time zone (GMT -5)) Skype: john_okeefe2 [hidden email] http://www.instantiations.com/vast _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: Grease-Core-DaleHenrichs.36
|
|
http://code.google.com/p/pharo/issues/detail?id=2428
On 13 May 2010 13:52, John O'Keefe <[hidden email]> wrote: > Hmmm, rather odd that Pharo would deprecate an ANSI method. Thanks for > following up on this. > > On Thu, May 13, 2010 at 12:47 AM, Lukas Renggli <[hidden email]> wrote: >> >> I sent a mail to the Pharo list asking to reconsider that change. >> >> Lukas >> >> On 13 May 2010 02:07, Dale Henrichs <[hidden email]> wrote: >> > Name: Grease-Core-DaleHenrichs.36 >> > Author: DaleHenrichs >> > Time: 12 May 2010, 5:00:48 pm >> > UUID: 820d8e2d-bbd4-4c25-8c92-1b36139b4cac >> > Ancestors: Grease-Core-pmm.35 >> > >> > >> > The comment for Grease-Core-jok.34 says: >> > >> > "Use #reverse (ANSI) rather than #reversed" >> > >> > Yet in Pharo1.1, #reverse has been deprecated for >> > SequenceableCollection... Since I was working on getting Seaside3.0 to load >> > into Pharo1.1 without firing off deprecated warnings, I made this change and >> > checked in Grease-Core-DaleHenrichs.36... >> > >> > I imagine that Pharo1.1 will end up favoring the ANSI variant in the end >> > ... >> > >> > Dale >> > >> > _______________________________________________ >> > seaside-dev mailing list >> > [hidden email] >> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >> > >> >> >> >> -- >> Lukas Renggli >> www.lukas-renggli.ch >> _______________________________________________ >> seaside-dev mailing list >> [hidden email] >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > > > -- > John O'Keefe [|], Principal Smalltalk Architect , Instantiations Inc. > Mobile: +1 919 417-3181 (Business hours USA Eastern Time zone (GMT -5)) > Skype: john_okeefe2 > [hidden email] > http://www.instantiations.com/vast > > _______________________________________________ > seaside-dev mailing list > [hidden email] > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > -- Lukas Renggli www.lukas-renggli.ch _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
«
Return to Seaside Development
|
1 view|%1 views
| Free forum by Nabble | Edit this page |