Grease-Pharo-Core-pmm.34 introduced methods from WAUrlEncoder into Grease

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Grease-Pharo-Core-pmm.34 introduced methods from WAUrlEncoder into Grease

Dale Henrichs
The following methods that belong to WAURlEncoder were incorrectly
included in Grease-Pharo-Core

   WAUrlEncoder>>basicnextPut:
   WAUrlEncoder>>greaseNext:putAll:startingAt:
   WAUrlEncoder>>isBinary

I'll be able to fix this up, but I did wonder why the hudson seaside
server didn't uncover the problem back in December.

It looks like the hudson build script loads Grease and a bunch of core
packages in one load, so dependency violations like the above don't show
up.

Might make sense to load (and test?) Grease independent of the core
Seaside packages.

Dale
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: Grease-Pharo-Core-pmm.34 introduced methods from WAUrlEncoder into Grease

Dale Henrichs
On 02/09/2011 02:49 PM, Dale Henrichs wrote:

> The following methods that belong to WAURlEncoder were incorrectly
> included in Grease-Pharo-Core
>
>     WAUrlEncoder>>basicnextPut:
>     WAUrlEncoder>>greaseNext:putAll:startingAt:
>     WAUrlEncoder>>isBinary
>
> I'll be able to fix this up, but I did wonder why the hudson seaside
> server didn't uncover the problem back in December.
>
> It looks like the hudson build script loads Grease and a bunch of core
> packages in one load, so dependency violations like the above don't show
> up.
>
> Might make sense to load (and test?) Grease independent of the core
> Seaside packages.
>
> Dale
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Well the resolution is quite as obvious to me...Since original code was
in Grease-Pharo-Core, I assume that the correct place to put the code is
in Seaside-Pharo-Core, but I was just curious under what conditions a
WAUrlEncoder might be used as a stream and if such a thing might be
generally useful or not ...

Anyway, for now I'll move the code to Seaside-Pharo-Core and continue on...

Dale
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: Grease-Pharo-Core-pmm.34 introduced methods from WAUrlEncoder into Grease

Philippe Marschall
In reply to this post by Dale Henrichs
2011/2/9 Dale Henrichs <[hidden email]>:

> The following methods that belong to WAURlEncoder were incorrectly included
> in Grease-Pharo-Core
>
>  WAUrlEncoder>>basicnextPut:
>  WAUrlEncoder>>greaseNext:putAll:startingAt:
>  WAUrlEncoder>>isBinary
>
> I'll be able to fix this up, but I did wonder why the hudson seaside server
> didn't uncover the problem back in December.
>
> It looks like the hudson build script loads Grease and a bunch of core
> packages in one load, so dependency violations like the above don't show up.
>
> Might make sense to load (and test?) Grease independent of the core Seaside
> packages.

Oops, I moved them to Seaside-Pharo-Core which is a much better place.

Cheers
Philippe
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev