Help with a bug fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Help with a bug fix

CyrilFerlicot
Hi,

I begun to fix a bug, I have a working fix (I think). But I am not
satisfy by a method I made. I think the method can be much better but I
don't have the knowledge and time to improve it now.

If someone wish to take a look:
https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list

--
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France


signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Help with a bug fix

CyrilFerlicot
Le 24/10/2015 15:27, Ferlicot D. Cyril a écrit :
> Hi,
>
> I begun to fix a bug, I have a working fix (I think). But I am not
> satisfy by a method I made. I think the method can be much better but I
> don't have the knowledge and time to improve it now.
>
> If someone wish to take a look:
> https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list
>

Thanks to Nicolai and Esteban for the help.
As Esteban said this change can be confusing so I want to have your
opinion guys.

Do you think that the protocols of the current extension should be
before the normal protocols ?
There is an example on the issue at:
https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list

Should Pharo integrate this slice or not ?

--
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France


signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Help with a bug fix

Nicolai Hess-3-2


2015-10-25 0:58 GMT+02:00 Ferlicot D. Cyril <[hidden email]>:
Le 24/10/2015 15:27, Ferlicot D. Cyril a écrit :
> Hi,
>
> I begun to fix a bug, I have a working fix (I think). But I am not
> satisfy by a method I made. I think the method can be much better but I
> don't have the knowledge and time to improve it now.
>
> If someone wish to take a look:
> https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list
>

Thanks to Nicolai and Esteban for the help.
As Esteban said this change can be confusing so I want to have your
opinion guys.

Do you think that the protocols of the current extension should be
before the normal protocols ?
There is an example on the issue at:
https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list

Should Pharo integrate this slice or not ?

I like it. But maybe we can add an option in Nautilus settings for this.
 

--
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France


Reply | Threaded
Open this post in threaded view
|

Re: Help with a bug fix

Stephan Eggermont-3
On 25/10/15 10:47, Nicolai Hess wrote:
> I like it. But maybe we can add an option in Nautilus settings for this.

-1 to options.

Stephan


Reply | Threaded
Open this post in threaded view
|

Re: Help with a bug fix

stepharo
In reply to this post by CyrilFerlicot
This is really nice that you guys spent time improving the user experience.
I deeply appreciate it.

Stef


Le 24/10/15 09:27, Ferlicot D. Cyril a écrit :
> Hi,
>
> I begun to fix a bug, I have a working fix (I think). But I am not
> satisfy by a method I made. I think the method can be much better but I
> don't have the knowledge and time to improve it now.
>
> If someone wish to take a look:
> https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list
>


Reply | Threaded
Open this post in threaded view
|

Re: Help with a bug fix

Ben Coman
I like it, but wonder if it should even appear above "-- all --".

Possibly it should also remain in its original sort position in the
list for consistency.  I tried this out but the second entry cannot be
selected, which seems strange.  Maybe list selection is by-content
rather than by-index - and I wonder if this is peculiar to Nautilus or
standard for list selection in the system?

cheers -ben

On Mon, Oct 26, 2015 at 6:33 AM, stepharo <[hidden email]> wrote:

> This is really nice that you guys spent time improving the user experience.
> I deeply appreciate it.
>
> Stef
>
>
> Le 24/10/15 09:27, Ferlicot D. Cyril a écrit :
>
>> Hi,
>>
>> I begun to fix a bug, I have a working fix (I think). But I am not
>> satisfy by a method I made. I think the method can be much better but I
>> don't have the knowledge and time to improve it now.
>>
>> If someone wish to take a look:
>>
>> https://pharo.fogbugz.com/f/cases/11091/Ensure-the-current-extension-is-always-on-top-in-protocols-list
>>
>
>