How best to report (loading) errors in latest Seaside on Pharo?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

How best to report (loading) errors in latest Seaside on Pharo?

Tim Mackinnon
Hi guys - I’ve finally got my simple application CI working (and still contemplating using SmalltalkCI) and it immediately failed as I look for Undeclared classes on load and Seaside has a bunch of them on Pharo 6. I think all libraries should load clean (a noble goal - but useful in a dynamic language)

I’ve inherited a spec from Willow which is;

baseline: 'Seaside3'
                        with: [ spec
                                repository: 'github://SeasideSt/Seaside:v3.2.4/repository';
                                loads: #('Seaside-Environment' 'JQuery' 'Zinc') ];
                project: 'Seaside3-Tests' copyFrom: 'Seaside3' with: [ spec loads: #('Seaside-Tests-Core') ].


The following come up:

1. BaselineOfGrease>>initializeLatin1ToUtf8Encodings (GRUtf8CodecStream is Undeclared)
2. GRSmallDictionary>>explorerContents (ObjectExplorerWrapper is Undeclared)
3. WAEnvironment class>>configureApplicationExceptionHandlingDefaults (WAWalkbackErrorHandler is Undeclared)

1. This seems to be in the doit category of BaselineOfGrease>>initializeLatin1ToUtf8Encodings which seems to be a GemStone thing so not sure why its in a Pharo image?
2. This seems to be in GRSmallDictionary>>explorerContents which seems to be in Grease-Pharo60-Core - this doesn’t look familiar so not sure if its some old remnant?
3. This one looks more serious - WAEnvironment>>configureApplicationExceptionHandlingDefaults which is in Seaside-Environment, however WAWalkbackErrorHandler is defined in Seaside-Development - Core (so its at the wrong level?)


Do I log something for them? I think they are easy enough to fix - I guess I could try and do a pull request (but its still early days for me on that front).

Tim
_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: How best to report (loading) errors in latest Seaside on Pharo?

Thomas Brodt-2
For 3) I already asked in this list in february if the standard error
handler should be WAHtmlErrorHandler, and only be replaced by
WAWalkbackErrorHandler when Development is loaded. This sounds right to
me, but I didn't get any answer to my request, though.

Maybe your email triggers enough interest for this?

Thomas

Am 16.05.2018 um 23:08 schrieb Tim Mackinnon:

> Hi guys - I’ve finally got my simple application CI working (and still contemplating using SmalltalkCI) and it immediately failed as I look for Undeclared classes on load and Seaside has a bunch of them on Pharo 6. I think all libraries should load clean (a noble goal - but useful in a dynamic language)
>
> I’ve inherited a spec from Willow which is;
>
> baseline: 'Seaside3'
> with: [ spec
> repository: 'github://SeasideSt/Seaside:v3.2.4/repository';
> loads: #('Seaside-Environment' 'JQuery' 'Zinc') ];
> project: 'Seaside3-Tests' copyFrom: 'Seaside3' with: [ spec loads: #('Seaside-Tests-Core') ].
>
>
> The following come up:
>
> 1. BaselineOfGrease>>initializeLatin1ToUtf8Encodings (GRUtf8CodecStream is Undeclared)
> 2. GRSmallDictionary>>explorerContents (ObjectExplorerWrapper is Undeclared)
> 3. WAEnvironment class>>configureApplicationExceptionHandlingDefaults (WAWalkbackErrorHandler is Undeclared)
>
> 1. This seems to be in the doit category of BaselineOfGrease>>initializeLatin1ToUtf8Encodings which seems to be a GemStone thing so not sure why its in a Pharo image?
> 2. This seems to be in GRSmallDictionary>>explorerContents which seems to be in Grease-Pharo60-Core - this doesn’t look familiar so not sure if its some old remnant?
> 3. This one looks more serious - WAEnvironment>>configureApplicationExceptionHandlingDefaults which is in Seaside-Environment, however WAWalkbackErrorHandler is defined in Seaside-Development - Core (so its at the wrong level?)
>
>
> Do I log something for them? I think they are easy enough to fix - I guess I could try and do a pull request (but its still early days for me on that front).
>
> Tim
> _______________________________________________
> seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: How best to report (loading) errors in latest Seaside on Pharo?

Thomas Brodt-2
Hi Tim

yes, we have our own Errorhandler class that replaces the Seaside one.
But our build process logs the Undeclared WAWalkbackErrorHandler because
Development is not loaded in our runtime build. So it leaves at least a
"code smell" where I would like to have clean builds.

We use Seaside with Visualworks, so I also didn't know how to propose a
fix for Pharo, which indeed seems on a transition to git, which makes it
even harder.

Thomas


Am 17.05.2018 um 12:32 schrieb Tim Mackinnon:

> Hi Thomas - what did you do to fix it, reinitialise it in your code afterwards?
>
> I seem to recall that seaside is exported to git  so I’m not sure if a simple pull request can do it - and it’s also tricky as you need to consider all dialects - still I’m guessing the ci should help try a fix.
>
> I’ll see if I can propose a fix, at least for the Pharo bits
>
> Tim
>
> Sent from my iPhone
>
>> On 17 May 2018, at 07:59, Thomas Brodt <[hidden email]> wrote:
>>
>> For 3) I already asked in this list in february if the standard error handler should be WAHtmlErrorHandler, and only be replaced by WAWalkbackErrorHandler when Development is loaded. This sounds right to me, but I didn't get any answer to my request, though.
>>
>> Maybe your email triggers enough interest for this?
>>
>> Thomas
>>
>>> Am 16.05.2018 um 23:08 schrieb Tim Mackinnon:
>>> Hi guys - I’ve finally got my simple application CI working (and still contemplating using SmalltalkCI) and it immediately failed as I look for Undeclared classes on load and Seaside has a bunch of them on Pharo 6. I think all libraries should load clean (a noble goal - but useful in a dynamic language)
>>>
>>> I’ve inherited a spec from Willow which is;
>>>
>>> baseline: 'Seaside3'
>>>             with: [ spec
>>>                 repository: 'github://SeasideSt/Seaside:v3.2.4/repository';
>>>                 loads: #('Seaside-Environment' 'JQuery' 'Zinc') ];
>>>         project: 'Seaside3-Tests' copyFrom: 'Seaside3' with: [ spec loads: #('Seaside-Tests-Core') ].
>>>
>>>
>>> The following come up:
>>>
>>> 1. BaselineOfGrease>>initializeLatin1ToUtf8Encodings (GRUtf8CodecStream is Undeclared)
>>> 2. GRSmallDictionary>>explorerContents (ObjectExplorerWrapper is Undeclared)
>>> 3. WAEnvironment class>>configureApplicationExceptionHandlingDefaults (WAWalkbackErrorHandler is Undeclared)
>>>
>>> 1. This seems to be in the doit category of BaselineOfGrease>>initializeLatin1ToUtf8Encodings which seems to be a GemStone thing so not sure why its in a Pharo image?
>>> 2. This seems to be in GRSmallDictionary>>explorerContents which seems to be in Grease-Pharo60-Core - this doesn’t look familiar so not sure if its some old remnant?
>>> 3. This one looks more serious - WAEnvironment>>configureApplicationExceptionHandlingDefaults which is in Seaside-Environment, however WAWalkbackErrorHandler is defined in Seaside-Development - Core (so its at the wrong level?)
>>>
>>>
>>> Do I log something for them? I think they are easy enough to fix - I guess I could try and do a pull request (but its still early days for me on that front).
>>>
>>> Tim
>>> _______________________________________________
>>> seaside mailing list
>>> [hidden email]
>>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>> _______________________________________________
>> seaside mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>
>

_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside