How to contribute to PharoLauncher?

Tim Mackinnon wrote:

Stef - hmm thats an interesting feature as well, I’ll have a quick look.

I tried committing my changes but I don’t have commit writes on that project. I have entered a Fogbugz issue in the Launcher category and attached my slice to it.

I still think I’m doing something wrong with Monticello though. I thought I was getting to grips with it, but when I compared my slice against the smalltalk hub repo for Launcher, it shows a lot more outgoing changes than are mine. Mine are in there - but there are lots of other classes which I know I didn’t change which show with a green tick as an outgoing change? It has me very confused.

Yet - If I take a fresh Luancher image and then apply my Slice it works fine (and also shows just my changes).

Could it be the Smalltalk hub repo has moved on a lot since the released version of Launcher - but then surely when diffing changes it would just consider what is in my slice. I think I’m missing something important.

Tim
  

I'm sure I've hit something similar before, but then I think I learnt to work around it or "just not go there" and those neurons have been garbage collected, so I have a thin grasp of this but here goes...     A slice doesn't actually contain any code (only dependencies), and the <Changes> 't pull in those dependencies, so you are kind of comparing nothing against an a whole image, so everything is changed.  I find I must check the changes of individual packages of a slice.  It would be real-nice to be able to get the changes of a whole slice versus Pharo/main in one go, but I think that behaviour is just missing.

Btw, loading a slice into a fresh image <Changes> and <Merge> is a different function, so all the changes for the whole slice are shown in one go.  
cheers -ben

On 11 Aug 2014, at 11:49, stepharo [hidden email] wrote:

  

Hi tim

I would love a sync from file possibility because I often remove directly folders and after the launcher is dead.

I think that to contribute you should commits code in the inbox of the project.
Damien is on vacation now but I'm sure he will welcome help.

    

Hi - I’ve added a few interesting features to PharoLauncher, but I’m not sure what the steps are for contributing to a SmalltalkHub project?

My proposed changes are as follows:
- Change default image template name to include the parent folder name (e.g. Pharo 4.0 (beta)-540123 vs. 450123)
- Add a new image command “Image Summary” that shows you the date of the last image modification as well as the contents of “description.txt” - as I can’t always remember why I have some old images kicking around (this change is quite basic - I couldn’t see how best to create a nice popup window so I reused the deny: one with a new title. I did think possibly a hover over balloon or having something like the comments panel in Pharo - but its a modal dialog for now)
- I changed the Run icon to a play button (as the process icon used - seemed a bit obscure)


Tim