How to get PRs reviewed?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

How to get PRs reviewed?

Holger Freyther
 
I have a couple of PRs and would like to make some progress in getting reviewed, revised and included. Please see a summary of the changes.


https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386
Update external software to not build known vulnerable software. This is also aligning the ./configure && make cycles.
And in general the same build script should work for Win32, Unix and Mac as the third-parties buildsystem handles the differences already. We should be able to remove some of the redundancy


https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/393:
Fix CLI argument. --pollpip actually takes an argument but it is not documented. I fixed this for Mac and Unix.


https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394:
Remove unused variables in the serial plugin for Macos and Unix.


https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395:
Add a --quiet option for the VM. Pillar, ectstatic or other CLI applications compete with the VM on stderr (e.g. the pthread priority warning). Add an option to make the VM quiet (and in the future to send this somewhere else).

If there is support I will extend struct VirtualMachine so that plugins can use the right stderr as well.



I also have some spring cleaning if there is interest:

* NPAPI is unsupported/dead. I propose the removal of npsqueak and the plugin code paths
* Removal of "zzz" directories as we have a SCM now.


cheers
        holger
Reply | Threaded
Open this post in threaded view
|

Re: How to get PRs reviewed?

Holger Freyther
 


> On 7. May 2019, at 15:22, Holger Freyther <[hidden email]> wrote:

Is this thing on? Do my socks have the right color...



> I have a couple of PRs and would like to make some progress in getting reviewed, revised and included. Please see a summary of the changes.
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386
> Update external software to not build known vulnerable software. This is also aligning the ./configure && make cycles.
> And in general the same build script should work for Win32, Unix and Mac as the third-parties buildsystem handles the differences already. We should be able to remove some of the redundancy
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/393:
> Fix CLI argument. --pollpip actually takes an argument but it is not documented. I fixed this for Mac and Unix.
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394:
> Remove unused variables in the serial plugin for Macos and Unix.
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395:
> Add a --quiet option for the VM. Pillar, ectstatic or other CLI applications compete with the VM on stderr (e.g. the pthread priority warning). Add an option to make the VM quiet (and in the future to send this somewhere else).
>
> If there is support I will extend struct VirtualMachine so that plugins can use the right stderr as well.
>
>
>
> I also have some spring cleaning if there is interest:
>
> * NPAPI is unsupported/dead. I propose the removal of npsqueak and the plugin code paths
> * Removal of "zzz" directories as we have a SCM now.
>
>
> cheers
> holger

Reply | Threaded
Open this post in threaded view
|

Re: How to get PRs reviewed?

Jakob Reschke-2
 
I can't tell you about your socks, but your messages do arrive on the mailing list. ;-)

Holger Freyther <[hidden email]> schrieb am Mi., 15. Mai 2019, 12:32:
 


> On 7. May 2019, at 15:22, Holger Freyther <[hidden email]> wrote:

Is this thing on? Do my socks have the right color...



> I have a couple of PRs and would like to make some progress in getting reviewed, revised and included. Please see a summary of the changes.
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386
> Update external software to not build known vulnerable software. This is also aligning the ./configure && make cycles.
> And in general the same build script should work for Win32, Unix and Mac as the third-parties buildsystem handles the differences already. We should be able to remove some of the redundancy
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/393:
> Fix CLI argument. --pollpip actually takes an argument but it is not documented. I fixed this for Mac and Unix.
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394:
> Remove unused variables in the serial plugin for Macos and Unix.
>
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395:
> Add a --quiet option for the VM. Pillar, ectstatic or other CLI applications compete with the VM on stderr (e.g. the pthread priority warning). Add an option to make the VM quiet (and in the future to send this somewhere else).
>
> If there is support I will extend struct VirtualMachine so that plugins can use the right stderr as well.
>
>
>
> I also have some spring cleaning if there is interest:
>
> * NPAPI is unsupported/dead. I propose the removal of npsqueak and the plugin code paths
> * Removal of "zzz" directories as we have a SCM now.
>
>
> cheers
>       holger