How to integrate change on class Point

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

How to integrate change on class Point

stepharo
Hi

I would like to remove some dusts in the class Point.
No decent class comments, cleaning typo in organisation and cleaning
some method comments.
In fact I should do a real pass. Now I  published
https://pharo.fogbugz.com/f/cases/16953/Clean-Point-Reciprocal-comment-and-improving-class-comment

When I merged the slice I get a classBuilder warning and it means that
my changes cannot be loaded and it fails of course.
I do not like this classBuilder warning in fact. I can break Pharo in
one line of code even with it. So may be in pharo dev mode we should not
get it.
So what is the way to do it properly.

Stef

Reply | Threaded
Open this post in threaded view
|

Re: How to integrate change on class Point

stepharo
There is a trick
Tx henrik
DangerousClassNotifier disable :)


Le 8/11/15 21:32, stepharo a écrit :

> Hi
>
> I would like to remove some dusts in the class Point.
> No decent class comments, cleaning typo in organisation and cleaning
> some method comments.
> In fact I should do a real pass. Now I  published
> https://pharo.fogbugz.com/f/cases/16953/Clean-Point-Reciprocal-comment-and-improving-class-comment
>
> When I merged the slice I get a classBuilder warning and it means that
> my changes cannot be loaded and it fails of course.
> I do not like this classBuilder warning in fact. I can break Pharo in
> one line of code even with it. So may be in pharo dev mode we should
> not get it.
> So what is the way to do it properly.
>
> Stef
>
>


Reply | Threaded
Open this post in threaded view
|

Re: How to integrate change on class Point

Marcus Denker-4

> On 08 Nov 2015, at 18:23, stepharo <[hidden email]> wrote:
>
> There is a trick
> Tx henrik
> DangerousClassNotifier disable :)
>

Yes, but we should actually fix the class builder to not raise the error when just changing a comment…
but then, this happens not often so I did not yet even report an issue for it.

        Marcus
Reply | Threaded
Open this post in threaded view
|

Re: How to integrate change on class Point

stepharo
so when does it report it? When we redefine a method?


Le 9/11/15 12:05, Marcus Denker a écrit :

>> On 08 Nov 2015, at 18:23, stepharo <[hidden email]> wrote:
>>
>> There is a trick
>> Tx henrik
>> DangerousClassNotifier disable :)
>>
> Yes, but we should actually fix the class builder to not raise the error when just changing a comment…
> but then, this happens not often so I did not yet even report an issue for it.
>
> Marcus
>


Reply | Threaded
Open this post in threaded view
|

Re: How to integrate change on class Point

Marcus Denker-4

I think it would be enough to do it when the shape of the class changes
(adding/removing variables).

        Marcus

> On 09 Nov 2015, at 12:07, stepharo <[hidden email]> wrote:
>
> so when does it report it? When we redefine a method?
>
>
> Le 9/11/15 12:05, Marcus Denker a écrit :
>>> On 08 Nov 2015, at 18:23, stepharo <[hidden email]> wrote:
>>>
>>> There is a trick
>>> Tx henrik
>>> DangerousClassNotifier disable :)
>>>
>> Yes, but we should actually fix the class builder to not raise the error when just changing a comment…
>> but then, this happens not often so I did not yet even report an issue for it.
>>
>> Marcus
>>
>
>