Smalltalk › Pharo › Pharo Smalltalk Developers

Huge Critiques Area in Calypso in Pharo 7

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Sven Van Caekenberghe-2

Huge Critiques Area in Calypso in Pharo 7

I am seeing a huge (multiline, ~ 5 to 7 lines) high 'critiques' area at the bottom of Calypso browsers in Pharo 7 (dl today), see screenshot:

Why is that ? I can't resize it to be smaller.

On a smaller screen this takes up way too much space.

Can't we have a widget to remove/collapse that area ? Not a setting.

Sven

Denis Kudriashov

Re: Huge Critiques Area in Calypso in Pharo 7

Hi Sven.

I checked problem and found following method:

FTTableMorph >> minHeight
^ 100

It prevents full critiques widget to be small.

There is probably a bug in morphic which does not set up this "correct" extent by default. In my case when I browse your method in fresh image only three rows are visible in critiques view. But as soon as I start resizing this pane it becomes bigger and unminimizable.

пн, 17 дек. 2018 г. в 17:14, Sven Van Caekenberghe <[hidden email]>:

I am seeing a huge (multiline, ~ 5 to 7 lines) high 'critiques' area at the bottom of Calypso browsers in Pharo 7 (dl today), see screenshot:

Why is that ? I can't resize it to be smaller.
On a smaller screen this takes up way too much space.
Can't we have a widget to remove/collapse that area ? Not a setting.

Sven

Denis Kudriashov

Re: Huge Critiques Area in Calypso in Pharo 7

In reply to this post by Sven Van Caekenberghe-2

Hi Sven.

I checked problem and found following method:

FTTableMorph >> minHeight
^ 100

It prevents full critiques widget to be small.

There is probably a bug in morphic which does not set up this "correct" extent by default. In my case when I browse your method in fresh image only three rows are visible in critiques view. But as soon as I start resizing this pane it becomes bigger and unminimizable.

Sven Van Caekenberghe-2

Re: Huge Critiques Area in Calypso in Pharo 7

In reply to this post by Denis Kudriashov

Thanks, Denis, for the swift reply.
What is the solution, though ?
What do you think should happen ?
Make the constant smaller, like the height of 1 row ?

> On 17 Dec 2018, at 18:42, Denis Kudriashov <[hidden email]> wrote:
>
> Hi Sven.
>
> I checked problem and found following method:
>
> FTTableMorph >> minHeight
> ^ 100
>
> It prevents full critiques widget to be small.
>
> There is probably a bug in morphic which does not set up this "correct" extent by default. In my case when I browse your method in fresh image only three rows are visible in critiques view. But as soon as I start resizing this pane it becomes bigger and unminimizable.
>
> пн, 17 дек. 2018 г. в 17:14, Sven Van Caekenberghe <[hidden email]>:
> I am seeing a huge (multiline, ~ 5 to 7 lines) high 'critiques' area at the bottom of Calypso browsers in Pharo 7 (dl today), see screenshot:
>
> <Screenshot 2018-12-17 at 17.19.35.png>
> Why is that ? I can't resize it to be smaller.
> On a smaller screen this takes up way too much space.
> Can't we have a widget to remove/collapse that area ? Not a setting.
>
> Sven
>

Pharo Smalltalk Developers mailing list

Re: Huge Critiques Area in Calypso in Pharo 7

In reply to this post by Sven Van Caekenberghe-2

I have that feeling too - critiques pane is annoying + occupying too much place - what about showing critiques inline only (in the line nubers and breakpoint markers left pane)?

This choice existed for the old Nautilus browser - but I can't find it for Calypso.

pf

> I am seeing a huge (multiline, ~ 5 to 7 lines) high 'critiques' area at the bottom of Calypso browsers in Pharo 7 (dl today), see screenshot:
>
>
> Why is that ? I can't resize it to be smaller.
> On a smaller screen this takes up way too much space.
> Can't we have a widget to remove/collapse that area ? Not a setting.
>
> Sven
>

Denis Kudriashov

Re: Huge Critiques Area in Calypso in Pharo 7

In reply to this post by Sven Van Caekenberghe-2

Hi Sven.

I did little change in Pharo https://github.com/pharo-project/pharo/pull/2096.

The best would be to have floating/docking layout of such panes like in other IDEs. Probably easy to do in Bloc but not in Morphic

пн, 17 дек. 2018 г. в 18:52, Sven Van Caekenberghe <[hidden email]>:

Thanks, Denis, for the swift reply.
What is the solution, though ?
What do you think should happen ?
Make the constant smaller, like the height of 1 row ?

> On 17 Dec 2018, at 18:42, Denis Kudriashov <[hidden email]> wrote:
>
> Hi Sven.
>
> I checked problem and found following method:
>
> FTTableMorph >> minHeight
> ^ 100
>
> It prevents full critiques widget to be small.
>
> There is probably a bug in morphic which does not set up this "correct" extent by default. In my case when I browse your method in fresh image only three rows are visible in critiques view. But as soon as I start resizing this pane it becomes bigger and unminimizable.
>
> пн, 17 дек. 2018 г. в 17:14, Sven Van Caekenberghe <[hidden email]>:
> I am seeing a huge (multiline, ~ 5 to 7 lines) high 'critiques' area at the bottom of Calypso browsers in Pharo 7 (dl today), see screenshot:
>
> <Screenshot 2018-12-17 at 17.19.35.png>
> Why is that ? I can't resize it to be smaller.
> On a smaller screen this takes up way too much space.
> Can't we have a widget to remove/collapse that area ? Not a setting.
>
> Sven
>

Denis Kudriashov

Re: Huge Critiques Area in Calypso in Pharo 7

In reply to this post by Pharo Smalltalk Developers mailing list

Hi Petr.

Setting would be nice. I did not know about it in Nautilus

вт, 18 дек. 2018 г. в 14:44, Petr Fischer via Pharo-dev <[hidden email]>:

I have that feeling too - critiques pane is annoying + occupying too much place - what about showing critiques inline only (in the line nubers and breakpoint markers left pane)?

This choice existed for the old Nautilus browser - but I can't find it for Calypso.

pf

> I am seeing a huge (multiline, ~ 5 to 7 lines) high 'critiques' area at the bottom of Calypso browsers in Pharo 7 (dl today), see screenshot:
>
>
> Why is that ? I can't resize it to be smaller.
> On a smaller screen this takes up way too much space.
> Can't we have a widget to remove/collapse that area ? Not a setting.
>
> Sven
>