ISSUE 2514
Locked
 
|
SLICE-NewTextMorph-acceptContents-FernandoOlivero.1
ISSUE 2514 NewTextMorph does not accept on cmd-s. NewTextMorph>>example1 is not working. Fixed this issue, made a test and aslo fixed #testFittingParagraph _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Hi,
Thanks Fernando! Adrian, Stef this is the fix required for fixing one of the remanning failing tests in Pharo 1.1 Cheers, Jorge On Sun, Jun 6, 2010 at 4:28 PM, Fernando olivero <[hidden email]> wrote: > SLICE-NewTextMorph-acceptContents-FernandoOlivero.1 > > > > ISSUE 2514 > NewTextMorph does not accept on cmd-s. > NewTextMorph>>example1 is not working. > > Fixed this issue, made a test and aslo fixed #testFittingParagraph > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
THANKS!!!
Stef On Jun 6, 2010, at 7:16 PM, Jorge Ressia wrote: > Hi, > > Thanks Fernando! > > Adrian, Stef this is the fix required for fixing one of the remanning > failing tests in Pharo 1.1 > > Cheers, > > Jorge > > On Sun, Jun 6, 2010 at 4:28 PM, Fernando olivero <[hidden email]> wrote: >> SLICE-NewTextMorph-acceptContents-FernandoOlivero.1 >> >> >> >> ISSUE 2514 >> NewTextMorph does not accept on cmd-s. >> NewTextMorph>>example1 is not working. >> >> Fixed this issue, made a test and aslo fixed #testFittingParagraph >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Hi Fernando,
Thanks for the fix. Now there is a new failing test: #testAcceptConcents (at least I don't remember that we saw this failing before). Can you check? Cheers, Adrian On Jun 6, 2010, at 20:04 , Stéphane Ducasse wrote: > THANKS!!! > > Stef > > On Jun 6, 2010, at 7:16 PM, Jorge Ressia wrote: > >> Hi, >> >> Thanks Fernando! >> >> Adrian, Stef this is the fix required for fixing one of the remanning >> failing tests in Pharo 1.1 >> >> Cheers, >> >> Jorge >> >> On Sun, Jun 6, 2010 at 4:28 PM, Fernando olivero <[hidden email]> wrote: >>> SLICE-NewTextMorph-acceptContents-FernandoOlivero.1 >>> >>> >>> >>> ISSUE 2514 >>> NewTextMorph does not accept on cmd-s. >>> NewTextMorph>>example1 is not working. >>> >>> Fixed this issue, made a test and aslo fixed #testFittingParagraph >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Hi Adrian, i've added this test in the SLICE.
It wasn't there before. The problem is that in PharoCore-1.1-11383-Beta the new editors aren't initialized, and the test fails, TextEditor initialize. SmalltalkEditor initialize. SimpleEditor initialize. I could either add this statements as a test preconditions, or we could execute them and have already initialized in the image itself. So we have a valid state of the editors in the image. What is your opinion? Fernando On Jun 7, 2010, at 8:45 AM, Adrian Lienhard wrote: > Hi Fernando, > > Thanks for the fix. Now there is a new failing test: #testAcceptConcents (at least I don't remember that we saw this failing before). Can you check? > > Cheers, > Adrian > > On Jun 6, 2010, at 20:04 , Stéphane Ducasse wrote: > >> THANKS!!! >> >> Stef >> >> On Jun 6, 2010, at 7:16 PM, Jorge Ressia wrote: >> >>> Hi, >>> >>> Thanks Fernando! >>> >>> Adrian, Stef this is the fix required for fixing one of the remanning >>> failing tests in Pharo 1.1 >>> >>> Cheers, >>> >>> Jorge >>> >>> On Sun, Jun 6, 2010 at 4:28 PM, Fernando olivero <[hidden email]> wrote: >>>> SLICE-NewTextMorph-acceptContents-FernandoOlivero.1 >>>> >>>> >>>> >>>> ISSUE 2514 >>>> NewTextMorph does not accept on cmd-s. >>>> NewTextMorph>>example1 is not working. >>>> >>>> Fixed this issue, made a test and aslo fixed #testFittingParagraph >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
Since the initialize methods are there the next time we will load it we will not have the problem
so we can just do that in the next integration pass. Setf > Hi Adrian, i've added this test in the SLICE. > It wasn't there before. > > The problem is that in PharoCore-1.1-11383-Beta the new editors aren't initialized, and the test fails, > > TextEditor initialize. > SmalltalkEditor initialize. > SimpleEditor initialize. > > I could either add this statements as a test preconditions, or we could execute them and have already initialized in the image itself. So we have a valid state of the editors in the image. > > What is your opinion? > > Fernando > > > On Jun 7, 2010, at 8:45 AM, Adrian Lienhard wrote: > >> Hi Fernando, >> >> Thanks for the fix. Now there is a new failing test: #testAcceptConcents (at least I don't remember that we saw this failing before). Can you check? >> >> Cheers, >> Adrian >> >> On Jun 6, 2010, at 20:04 , Stéphane Ducasse wrote: >> >>> THANKS!!! >>> >>> Stef >>> >>> On Jun 6, 2010, at 7:16 PM, Jorge Ressia wrote: >>> >>>> Hi, >>>> >>>> Thanks Fernando! >>>> >>>> Adrian, Stef this is the fix required for fixing one of the remanning >>>> failing tests in Pharo 1.1 >>>> >>>> Cheers, >>>> >>>> Jorge >>>> >>>> On Sun, Jun 6, 2010 at 4:28 PM, Fernando olivero <[hidden email]> wrote: >>>>> SLICE-NewTextMorph-acceptContents-FernandoOlivero.1 >>>>> >>>>> >>>>> >>>>> ISSUE 2514 >>>>> NewTextMorph does not accept on cmd-s. >>>>> NewTextMorph>>example1 is not working. >>>>> >>>>> Fixed this issue, made a test and aslo fixed #testFittingParagraph >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> [hidden email] >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
|
|
In reply to this post by Fernando olivero
On Jun 7, 2010, at 3:03 33PM, Fernando olivero wrote: > Hi Adrian, i've added this test in the SLICE. > It wasn't there before. > > The problem is that in PharoCore-1.1-11383-Beta the new editors aren't initialized, and the test fails, > > TextEditor initialize. > SmalltalkEditor initialize. > SimpleEditor initialize. > > I could either add this statements as a test preconditions, or we could execute them and have already initialized in the image itself. So we have a valid state of the editors in the image. > > What is your opinion? > > Fernando And most of them are initialized, it's just SmalltalkEditor which is not. Since it doesn't implement initialize directly, it is never executed when loaded from Monticello (or filed in, for that matter). With the initialize factored into different methods like that, the initialize method itself is seldomly updated, it's hard to ensure you've initialized correctly when using Monticello. In this case, a postload script for System-Text doing Editor allSubclassesDo: [:each | each initialize] might have been the simplest solution, but those don't exist anymore in Pharo. Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ISSUE 2514: Refactoring the Editors
|
|
On Jun 7, 2010, at 3:29 PM, Henrik Johansen wrote: > > On Jun 7, 2010, at 3:03 33PM, Fernando olivero wrote: > >> Hi Adrian, i've added this test in the SLICE. >> It wasn't there before. >> >> The problem is that in PharoCore-1.1-11383-Beta the new editors aren't initialized, and the test fails, >> >> TextEditor initialize. >> SmalltalkEditor initialize. >> SimpleEditor initialize. >> >> I could either add this statements as a test preconditions, or we could execute them and have already initialized in the image itself. So we have a valid state of the editors in the image. >> >> What is your opinion? >> >> Fernando > Should do some refactoring too, right now actions are stored in a shared variable for SimpleEditor, and a class inst var for TextEditor. (capitalized differently) > YES! > And most of them are initialized, it's just SmalltalkEditor which is not. > Since it doesn't implement initialize directly, it is never executed when loaded from Monticello (or filed in, for that matter). > With the initialize factored into different methods like that, the initialize method itself is seldomly updated, it's hard to ensure you've initialized correctly when using Monticello. > Up to now i've only ported the Editors, and made minor modifcations due to Pharo being diferent than CUIS and Squeak. What you propose and also what Lukas proposed in the past is the next step. > In this case, a postload script for System-Text doing Editor allSubclassesDo: [:each | each initialize] might have been the simplest solution, but those don't exist anymore in Pharo. > > Cheers, > Henry > > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |