Iceberg left:right

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Iceberg left:right

Stephane Ducasse-3
Hi Esteban

did you change the left right order in the diff tool?
I'm super confused in the latest version doing a code review.

I have left: workingcopy right: incoming updates

Is right the change proposed?
What is the workingcopy? My image?

Because as you can see in the attached screeshot the right is showing
what is in the image.
It is super difficult to understand anything.

I checked with github and incoming is the image and workingcopy the
proposed fix!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Argh. Is it only me?
Can you fix this important glitch?

Stef

Screen Shot 2018-02-17 at 08.20.43.png (231K) Download Attachment
Screen Shot 2018-02-17 at 08.22.43.png (82K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Iceberg left:right

EstebanLM
yes, is super confusing and is completely mixed :(

I’m working on the changes with this in mind. In the future, all diffs with be show with: left old/right new metaphor (problem is even that will have some problems, but at least it will be coherent)

Esteban

> On 17 Feb 2018, at 08:23, Stephane Ducasse <[hidden email]> wrote:
>
> Hi Esteban
>
> did you change the left right order in the diff tool?
> I'm super confused in the latest version doing a code review.
>
> I have left: workingcopy right: incoming updates
>
> Is right the change proposed?
> What is the workingcopy? My image?
>
> Because as you can see in the attached screeshot the right is showing
> what is in the image.
> It is super difficult to understand anything.
>
> I checked with github and incoming is the image and workingcopy the
> proposed fix!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> Argh. Is it only me?
> Can you fix this important glitch?
>
> Stef
> <Screen Shot 2018-02-17 at 08.20.43.png><Screen Shot 2018-02-17 at 08.22.43.png>


Reply | Threaded
Open this post in threaded view
|

Re: Iceberg left:right

Stephane Ducasse-3
Tx

On Sat, Feb 17, 2018 at 9:31 AM, Esteban Lorenzano <[hidden email]> wrote:

> yes, is super confusing and is completely mixed :(
>
> I’m working on the changes with this in mind. In the future, all diffs with be show with: left old/right new metaphor (problem is even that will have some problems, but at least it will be coherent)
>
> Esteban
>
>> On 17 Feb 2018, at 08:23, Stephane Ducasse <[hidden email]> wrote:
>>
>> Hi Esteban
>>
>> did you change the left right order in the diff tool?
>> I'm super confused in the latest version doing a code review.
>>
>> I have left: workingcopy right: incoming updates
>>
>> Is right the change proposed?
>> What is the workingcopy? My image?
>>
>> Because as you can see in the attached screeshot the right is showing
>> what is in the image.
>> It is super difficult to understand anything.
>>
>> I checked with github and incoming is the image and workingcopy the
>> proposed fix!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>> Argh. Is it only me?
>> Can you fix this important glitch?
>>
>> Stef
>> <Screen Shot 2018-02-17 at 08.20.43.png><Screen Shot 2018-02-17 at 08.22.43.png>
>
>