Iceberg package addition

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Iceberg package addition

Stephane Ducasse-3
Hi esteban

each time I add a new packages to an iceberg project I get the same DNU

KeyNotFound: why the name of my new package (which I added).

packageNamed: packageName
     ^ self savedPackagesDictionary at: packageName
                                                             ^^^^^^^^^^^^^^^


directoryForPackage: mcPackage
   | package |
   package := self packageNamed: mcPackage name.
                                                      ^^^^^^^^^^^^^^^^^^^^
   ^ self subdirectory isEmptyOrNil
         ifTrue: [ package directoryName ]
         ifFalse: [ self subdirectory, '/', package directoryName ]


The second time I do it. It works but it does not give a good feeling.

Stef

Reply | Threaded
Open this post in threaded view
|

Re: Iceberg package addition

Denis Kudriashov

2018-02-11 19:27 GMT+01:00 Stephane Ducasse <[hidden email]>:
Hi esteban

each time I add a new packages to an iceberg project I get the same DNU

KeyNotFound: why the name of my new package (which I added).

packageNamed: packageName
     ^ self savedPackagesDictionary at: packageName
                                                             ^^^^^^^^^^^^^^^


directoryForPackage: mcPackage
   | package |
   package := self packageNamed: mcPackage name.
                                                      ^^^^^^^^^^^^^^^^^^^^
   ^ self subdirectory isEmptyOrNil
         ifTrue: [ package directoryName ]
         ifFalse: [ self subdirectory, '/', package directoryName ]


The second time I do it. It works but it does not give a good feeling.

Stef


Reply | Threaded
Open this post in threaded view
|

Re: Iceberg package addition

Stephane Ducasse-3
Tx denis.

On Sun, Feb 11, 2018 at 8:58 PM, Denis Kudriashov <[hidden email]> wrote:

> There is already issue  Unable commit new added package
>
> 2018-02-11 19:27 GMT+01:00 Stephane Ducasse <[hidden email]>:
>>
>> Hi esteban
>>
>> each time I add a new packages to an iceberg project I get the same DNU
>>
>> KeyNotFound: why the name of my new package (which I added).
>>
>> packageNamed: packageName
>>      ^ self savedPackagesDictionary at: packageName
>>
>> ^^^^^^^^^^^^^^^
>>
>>
>> directoryForPackage: mcPackage
>>    | package |
>>    package := self packageNamed: mcPackage name.
>>                                                       ^^^^^^^^^^^^^^^^^^^^
>>    ^ self subdirectory isEmptyOrNil
>>          ifTrue: [ package directoryName ]
>>          ifFalse: [ self subdirectory, '/', package directoryName ]
>>
>>
>> The second time I do it. It works but it does not give a good feeling.
>>
>> Stef
>>
>