IconFactory - utility for creating icons in Pharo

Hi,

since I've been making new icons lately for my project I was frustrated with constantly copying code and methods around... so I've made a small utility for it

http://smalltalkhub.com/#!/~peteruhnak/IconFactory

​

on top of creating the icons it can add extra stuff like GTInspector support.

Any feedback appreciated.

Peter

Tried your install instructions but give me an error[1] about being unable to resolve IconFactory , tries to look inside my package-cache of my image (pharo 4 - 40591 -MACOSX 10).

Interesting tool, out of coincidence I am also working with icons but in my cases its SVG icons using Bloc .

[1]
MetacelloFetchingMCSpecLoader(MetacelloCommonMCSpecLoader)>>retryingResolvePackageSpecReferences:gofer:
linearLoadPackageSpec: packageSpec gofer: gofer
    MetacelloPlatform current
        do: [
            | references nearestReference cachedReference externalReference mcVersion loadedVersionInfos |
            "check to see if mcz file is already in cacheRepository"
            cachedReference := self resolvePackageSpec: packageSpec cachedGofer: self loaderPolicy cacheGofer.
            (cachedReference ~~ nil and: [ packageSpec getFile ~~ nil ])
                ifTrue: [
                    cachedReference name = packageSpec file
                        ifTrue: [
                            "exact match between packageSpec file and cache"
                            ^ self scheduleFetchFor: packageSpec cachedReference: cachedReference ] ].    "look up mcz file"
            references := self retryingResolvePackageSpecReferences: packageSpec gofer: gofer.
            nearestReference := references last asMetacelloCachingResolvedReference.    "If the mcz is already in the cacheRepository, no need to copy"
            (cachedReference ~~ nil and: [ cachedReference name = nearestReference name ])
                ifTrue: [
                    "latest reference in repository matches cachedReference ... "
                    ^ self scheduleFetchFor: packageSpec nearestReference: nearestReference ].    "If the mcz is already loaded into the image, no need to copy"
            (self ignoreImage not and: [ (loadedVersionInfos := self ancestorsFor: packageSpec) ~~ nil ])
                ifTrue: [
                    loadedVersionInfos
                        do: [ :info |
                            info name = nearestReference name
                                ifTrue: [ ^ self ] ] ].
            externalReference := (references select: [ :ref | ref name = nearestReference name ]) first
                asMetacelloCachingResolvedReference.
            self repositoryMap at: externalReference name put: externalReference repository.
            (self
                resolveDependencies: externalReference
                nearest: nearestReference
                into: (OrderedCollection with: nearestReference))
                do: [ :reference |
                    | pSpec l |
                    mcVersion := reference version.
                    (l := (GoferVersionReference name: reference name) resolveAllWith: self loaderPolicy cacheGofer) isEmpty
                        ifTrue: [
                            self cacheRepository storeVersion: mcVersion.
                            reference == nearestReference
                                ifTrue: [ pSpec := packageSpec ]
                                ifFalse: [
                                    pSpec := packageSpec project packageSpec.
                                    pSpec name: mcVersion package name ].
                            self loadData
                                addVersion: mcVersion
                                versionInfo: mcVersion info
                                resolvedReference: reference
                                packageSpec: pSpec ] ].
            self scheduleFetchFor: packageSpec externalReference: externalReference ]
        displaying: 'Fetching ' , packageSpec file in MetacelloFetchingMCSpecLoader>>linearLoadPackageSpec:gofer: in Block: linearLoadPackageSpec: packageSpec gofer: gofer...
MetacelloPharo30Platform(MetacelloPlatform)>>do:displaying:
MetacelloFetchingMCSpecLoader>>linearLoadPackageSpec:gofer:
MetacelloPackageSpec>>loadUsing:gofer:
[ :pkg | pkg loadUsing: self gofer: gofer ] in MetacelloFetchingMCSpecLoader(MetacelloCommonMCSpecLoader)>>linearLoadPackageSpecs:repositories: in Block: [ :pkg | pkg loadUsing: self gofer: gofer ]
OrderedCollection>>do:
MetacelloFetchingMCSpecLoader(MetacelloCommonMCSpecLoader)>>linearLoadPackageSpecs:repositories:
[ super linearLoadPackageSpecs: packageSpecs repositories: repositories ] in MetacelloFetchingMCSpecLoader>>linearLoadPackageSpecs:repositories: in Block: [ super linearLoadPackageSpecs: packageSpecs repos...etc...
BlockClosure>>ensure:
MetacelloLoaderPolicy>>pushLoadDirective:during:
MetacelloLoaderPolicy>>pushLinearLoadDirectivesDuring:for:
MetacelloFetchingMCSpecLoader>>linearLoadPackageSpecs:repositories:
MetacelloFetchingMCSpecLoader(MetacelloCommonMCSpecLoader)>>load
MetacelloMCVersionSpecLoader>>load
MetacelloMCVersion>>executeLoadFromArray:
[ :dict | ^ self executeLoadFromArray: anArray ] in [
self versionSpec loader: newLoader.
MetacelloPlatform current
    useStackCacheDuring: [ :dict | ^ self executeLoadFromArray: anArray ]
    defaultDictionary: Dictionary new ] in [
[
self versionSpec loader: newLoader.
MetacelloPlatform current
    useStackCacheDuring: [ :dict | ^ self executeLoadFromArray: anArray ]
    defaultDictionary: Dictionary new ]
    ensure: [ self versionSpec loader: originalLoader ] ] in MetacelloMCVersion>>fetchRequiredFromArray: in Block: [ :dict | ^ self executeLoadFromArray: anArray ]
[ ^ aBlock value: dict ] in MetacelloPharo30Platform(MetacelloPlatform)>>useStackCacheDuring:defaultDictionary: in Block: [ ^ aBlock value: dict ]
BlockClosure>>on:do:
MetacelloPharo30Platform(MetacelloPlatform)>>useStackCacheDuring:defaultDictionary:
[
self versionSpec loader: newLoader.
MetacelloPlatform current
    useStackCacheDuring: [ :dict | ^ self executeLoadFromArray: anArray ]
    defaultDictionary: Dictionary new ] in [
[
self versionSpec loader: newLoader.
MetacelloPlatform current
    useStackCacheDuring: [ :dict | ^ self executeLoadFromArray: anArray ]
    defaultDictionary: Dictionary new ]
    ensure: [ self versionSpec loader: originalLoader ] ] in MetacelloMCVersion>>fetchRequiredFromArray: in Block: [ ...
BlockClosure>>ensure:
[
[
self versionSpec loader: newLoader.
MetacelloPlatform current
    useStackCacheDuring: [ :dict | ^ self executeLoadFromArray: anArray ]
    defaultDictionary: Dictionary new ]
    ensure: [ self versionSpec loader: originalLoader ] ] in MetacelloMCVersion>>fetchRequiredFromArray: in Block: [ ...
MetacelloPharo30Platform(MetacelloPlatform)>>do:displaying:
MetacelloMCVersion>>fetchRequiredFromArray:
[
| fetchLoader |
fetchLoader := self fetchRequiredFromArray: (self defaultPackageNamesToLoad: anArray).
MetacelloPlatform current do: [ fetchLoader doLoad ] displaying: 'Loading ' , displayString.
Transcript
    cr;
    show: '...finished ' , self versionNumber printString.
^ fetchLoader ] in MetacelloMCVersion>>doLoadRequiredFromArray: in Block: [ ...
BlockClosure>>ensure:
MetacelloMCVersion>>doLoadRequiredFromArray:
MetacelloMCVersion>>load
GoferMetacelloLoad>>loadConfiguration
 

On Sat, Apr 4, 2015 at 2:50 PM, Peter Uhnák <[hidden email]> wrote:

Hi,

since I've been making new icons lately for my project I was frustrated with constantly copying code and methods around... so I've made a small utility for it

http://smalltalkhub.com/#!/~peteruhnak/IconFactory

​

on top of creating the icons it can add extra stuff like GTInspector support.

Any feedback appreciated.

Peter

createIconsFromDirectory seems to see only the first png, maybe because its too large

how large? 

createIconFromFile gives me a MNU

it accepts a FileReference, not a string; I should put guard there.

Peter

createIconsFromDirectory seems to see only the first png, maybe because its too large

how large? 

createIconFromFile gives me a MNU

it accepts a FileReference, not a string; I should put guard there.

Peter

On Sat, Apr 4, 2015 at 2:46 PM, kilon alios <[hidden email]> wrote:

actually i was wrong its not that large, only 34kbs , I have also attached it if you want to take a look at it.

 

This works just fine for me; does it show any error for you? Or did it just create one file and then gave up?

Peter

create file ? i thought the class only creates methods

yeah, I mean method 

anyway, the method is created , but it does not proceed to next png. Shouldn create a method for each png it finds in the directory ?

yes it should, it operates on a collection, so if 

dir allFiles select: [ :each | each extension = 'png' ]

shows more then one file it should also create a method for each one, not just the first

Peter

I found the problem

"Norse_largeThe '-' prefix works only for literal numbers (use #negated instead) -> -cpcIconContents
    "Private - Method generated with the content of the file File @ /Users/kilon/Downloads/Norse_large-cpc.png""

looks like it does not like that i use "-" inside the file name. In the folder the name of the file is not Norse_large-cpc.png but Norse-large-cpc.png

"-" has some special meaning here ?

On Sat, Apr 4, 2015 at 4:12 PM, Peter Uhnák <[hidden email]> wrote:

create file ? i thought the class only creates methods

yeah, I mean method 

anyway, the method is created , but it does not proceed to next png. Shouldn create a method for each png it finds in the directory ?

yes it should, it operates on a collection, so if 

dir allFiles select: [ :each | each extension = 'png' ]

shows more then one file it should also create a method for each one, not just the first

Peter

Aha, of course.

The program makes assumptions about the file name and since it is naming the method like the file it fails, because you can't have "-" in method name.

I could change it so it removes all non-alphanumeric characters from the name.

Peter

On Sat, Apr 4, 2015 at 3:52 PM, kilon alios <[hidden email]> wrote:

I found the problem

"Norse_largeThe '-' prefix works only for literal numbers (use #negated instead) -> -cpcIconContents
    "Private - Method generated with the content of the file File @ /Users/kilon/Downloads/Norse_large-cpc.png""

looks like it does not like that i use "-" inside the file name. In the folder the name of the file is not Norse_large-cpc.png but Norse-large-cpc.png

"-" has some special meaning here ?

On Sat, Apr 4, 2015 at 4:12 PM, Peter Uhnák <[hidden email]> wrote:

create file ? i thought the class only creates methods

yeah, I mean method 

anyway, the method is created , but it does not proceed to next png. Shouldn create a method for each png it finds in the directory ?

yes it should, it operates on a collection, so if 

dir allFiles select: [ :each | each extension = 'png' ]

shows more then one file it should also create a method for each one, not just the first

Peter

Because composition/decomposition is good (among others for re-use), because with separate entries you can browse them more easily, because we don't like long methods, ... You get the idea ;-)

> On 04 Apr 2015, at 16:45, kilon alios <[hidden email]> wrote:
>
> once more I really dont like idea of methods returning single values. This also one of the reasons why Spec annoys me. Why not have Collection / Dictionary that stores all these strings ? Having 100 methods for 100 icons seems really ugly .  Instead one collection with 100 entries and a single method would be more than enough.
>
> I know its not just you that do this  and is how icons work in Pharo .Its basically how many things work like this inside Pharo. But I still dont get it.... why ?
>
> On Sat, Apr 4, 2015 at 5:15 PM, Peter Uhnák <[hidden email]> wrote:
> Aha, of course.
> The program makes assumptions about the file name and since it is naming the method like the file it fails, because you can't have "-" in method name.
> I could change it so it removes all non-alphanumeric characters from the name.
>
> Peter
>
> On Sat, Apr 4, 2015 at 3:52 PM, kilon alios <[hidden email]> wrote:
> I found the problem
>
> "Norse_largeThe '-' prefix works only for literal numbers (use #negated instead) -> -cpcIconContents
>     "Private - Method generated with the content of the file File @ /Users/kilon/Downloads/Norse_large-cpc.png""
>
> looks like it does not like that i use "-" inside the file name. In the folder the name of the file is not Norse_large-cpc.png but Norse-large-cpc.png
>
> "-" has some special meaning here ?
>
> On Sat, Apr 4, 2015 at 4:12 PM, Peter Uhnák <[hidden email]> wrote:
> create file ? i thought the class only creates methods
> yeah, I mean method
>
> anyway, the method is created , but it does not proceed to next png. Shouldn create a method for each png it finds in the directory ?
> yes it should, it operates on a collection, so if
> dir allFiles select: [ :each | each extension = 'png' ]
> shows more then one file it should also create a method for each one, not just the first
>
> Peter
>
>
>