ImageSegment part 3 ready to integrate

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

ImageSegment part 3 ready to integrate

Mariano Martinez Peck
Issue http://code.google.com/p/pharo/issues/detail?id=1940

SLICE-Issue1940-ImageSegmentCleaningPart3-Mariano.3    in PharoInbox.

- remove #fixCapitalizationOfSymbols
- remove TTCFontSet code from #comeFullyUpOnReload:
This even fixes a cycle dependency between ImageSegment and Multilingual
- the following implementors were moved to category *System-Object Storage:
*startUpFrom:
*saveImageSegments:
*areThereImageSegments
*rootStubInImageSegment:
*scanFromNoCompile: aStream forSegment: anImageSegment

Now we have a cleaner kernel (Object, Behavior, etc) and a little step more to put ImageSegment as a separate package.

This is not possible yet as there are method from the kernel referencing to ImageSegment.

Take into account that ImageSegment tests are failing but due to issue http://code.google.com/p/pharo/issues/detail?id=1941
However, "rollbacking" that problem I make sure that this ImageSegment version is working.

Cheers

Mariano

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: ImageSegment part 3 ready to integrate

Adrian Lienhard
Great! Thanks Mariano.

Adrian

On Feb 8, 2010, at 15:02 , Mariano Martinez Peck wrote:

> Issue http://code.google.com/p/pharo/issues/detail?id=1940
>
> SLICE-Issue1940-ImageSegmentCleaningPart3-Mariano.3    in PharoInbox.
>
> - remove #fixCapitalizationOfSymbols
> - remove TTCFontSet code from #comeFullyUpOnReload:
> This even fixes a cycle dependency between ImageSegment and Multilingual
> - the following implementors were moved to category *System-Object Storage:
> *startUpFrom:
> *saveImageSegments:
> *areThereImageSegments
> *rootStubInImageSegment:
> *scanFromNoCompile: aStream forSegment: anImageSegment
>
> Now we have a cleaner kernel (Object, Behavior, etc) and a little step more
> to put ImageSegment as a separate package.
>
> This is not possible yet as there are method from the kernel referencing to
> ImageSegment.
>
> Take into account that ImageSegment tests are failing but due to issue
> http://code.google.com/p/pharo/issues/detail?id=1941
> However, "rollbacking" that problem I make sure that this ImageSegment
> version is working.
>
> Cheers
>
> Mariano
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: ImageSegment part 3 ready to integrate

Mariano Martinez Peck


On Mon, Feb 8, 2010 at 3:59 PM, Adrian Lienhard <[hidden email]> wrote:
Great! Thanks Mariano.


You are welcome. You will notice that after this commit, it is much "easier" to put ImageSegment as separate package. So...if you wanted to continue my work and to put that out, I think after this slice, it is a good start point :)   At least, this is the maximum I could did so far.

Cheers

Mariano
 
Adrian

On Feb 8, 2010, at 15:02 , Mariano Martinez Peck wrote:

> Issue http://code.google.com/p/pharo/issues/detail?id=1940
>
> SLICE-Issue1940-ImageSegmentCleaningPart3-Mariano.3    in PharoInbox.
>
> - remove #fixCapitalizationOfSymbols
> - remove TTCFontSet code from #comeFullyUpOnReload:
> This even fixes a cycle dependency between ImageSegment and Multilingual
> - the following implementors were moved to category *System-Object Storage:
> *startUpFrom:
> *saveImageSegments:
> *areThereImageSegments
> *rootStubInImageSegment:
> *scanFromNoCompile: aStream forSegment: anImageSegment
>
> Now we have a cleaner kernel (Object, Behavior, etc) and a little step more
> to put ImageSegment as a separate package.
>
> This is not possible yet as there are method from the kernel referencing to
> ImageSegment.
>
> Take into account that ImageSegment tests are failing but due to issue
> http://code.google.com/p/pharo/issues/detail?id=1941
> However, "rollbacking" that problem I make sure that this ImageSegment
> version is working.
>
> Cheers
>
> Mariano
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project