Smalltalk › Frameworks & Tools › Moose

Improvement of the legend

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

abergel

Improvement of the legend

Hi!

Today Usman and I have pair-programmed. We improved the legend builder.

Here is an example

Check this out:

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

b := RTMondrian new.
b shape rectangle
width: [ :c | c numberOfVariables * 5 ];
height: #numberOfMethods.
b nodes: RTShape withAllSubclasses.
b edges connectFrom: #superclass.
b layout tree.
b normalizer
normalizeColor: #numberOfLinesOfCode using: { Color black. Color red }.
b build.

lb := RTLegendBuilder new.
lb view: b view.

lb addText: 'System complexity view'.
lb addRectanglePolymetricWidth: 'number of methods' height: 'Line of code' box: 'a Pharo class'.

lb addColorFadingFrom: Color red to: Color black text: 'Number of lines of code'.
lb build.

b
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Cheers,

Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba-2

Re: Improvement of the legend

Hi,

Nice. However, the way the legend is presented is too intrusive. If you look at the picture, the first thing that draws your attention is the legend, not the data.

I would prefer to have the legend available only on demand, rather than always. We could introduce a symbol (e.g., ?) that is always available on the top right or bottom right and that can toggle the legend on or off (or only offer it when we hover over the symbol). What do you think?

Cheers,

Doru

On Fri, Jul 10, 2015 at 1:59 PM, Alexandre Bergel <[hidden email]> wrote:

Hi!

Today Usman and I have pair-programmed. We improved the legend builder.
Here is an example

Check this out:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
b := RTMondrian new.
b shape rectangle
width: [ :c | c numberOfVariables * 5 ];
height: #numberOfMethods.
b nodes: RTShape withAllSubclasses.
b edges connectFrom: #superclass.
b layout tree.
b normalizer
normalizeColor: #numberOfLinesOfCode using: { Color black. Color red }.
b build.

lb := RTLegendBuilder new.
lb view: b view.

lb addText: 'System complexity view'.
lb addRectanglePolymetricWidth: 'number of methods' height: 'Line of code' box: 'a Pharo class'.

lb addColorFadingFrom: Color red to: Color black text: 'Number of lines of code'.
lb build.

b
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

cbc

Re: Improvement of the legend

On Fri, Jul 10, 2015 at 5:09 AM, Tudor Girba <[hidden email]> wrote:

Hi,

Nice. However, the way the legend is presented is too intrusive. If you look at the picture, the first thing that draws your attention is the legend, not the data.

I would prefer to have the legend available only on demand, rather than always. We could introduce a symbol (e.g., ?) that is always available on the top right or bottom right and that can toggle the legend on or off (or only offer it when we hover over the symbol). What do you think?

Or instead of a symbol, and thumbnail version of the legend.

Cheers,
Doru

<snip>

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Thierry Goubier

Re: Improvement of the legend

2015-07-10 17:15 GMT+02:00 Chris Cunningham <[hidden email]>:

On Fri, Jul 10, 2015 at 5:09 AM, Tudor Girba <[hidden email]> wrote:
Hi,

Nice. However, the way the legend is presented is too intrusive. If you look at the picture, the first thing that draws your attention is the legend, not the data.

I would prefer to have the legend available only on demand, rather than always. We could introduce a symbol (e.g., ?) that is always available on the top right or bottom right and that can toggle the legend on or off (or only offer it when we hover over the symbol). What do you think?

Or instead of a symbol, and thumbnail version of the legend.

Thierry

Cheers,
Doru

<snip>

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

abergel

Re: Improvement of the legend

In reply to this post by Tudor Girba-2

You are becoming picky. I like that :-)

I have added a method #onDemand in the class RTLegendBuilder.

Here is an example:

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

b := RTMondrian new.
b shape rectangle
width: [ :c | c numberOfVariables * 5 ];
height: #numberOfMethods.
b nodes: Collection withAllSubclasses.
b edges connectFrom: #superclass.
b layout tree.
b normalizer
normalizeColor: #numberOfLinesOfCode using: { Color black. Color red }.
b build.

lb := RTLegendBuilder new.
lb onDemand.
lb view: b view.

lb addText: 'System complexity view'.
lb addRectanglePolymetricWidth: 'number of methods' height: 'Line of code' box: 'a Pharo class'.
lb build.

b view.

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Cheers

Alexandre

On Jul 10, 2015, at 2:09 PM, Tudor Girba <[hidden email]> wrote:

Hi,

Nice. However, the way the legend is presented is too intrusive. If you look at the picture, the first thing that draws your attention is the legend, not the data.

I would prefer to have the legend available only on demand, rather than always. We could introduce a symbol (e.g., ?) that is always available on the top right or bottom right and that can toggle the legend on or off (or only offer it when we hover over the symbol). What do you think?

Cheers,
Doru

On Fri, Jul 10, 2015 at 1:59 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

Today Usman and I have pair-programmed. We improved the legend builder.
Here is an example
<Screen Shot 2015-07-10 at 1.53.17 PM.png>

Check this out:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
b := RTMondrian new.
b shape rectangle
width: [ :c | c numberOfVariables * 5 ];
height: #numberOfMethods.
b nodes: RTShape withAllSubclasses.
b edges connectFrom: #superclass.
b layout tree.
b normalizer
normalizeColor: #numberOfLinesOfCode using: { Color black. Color red }.
b build.

lb := RTLegendBuilder new.
lb view: b view.

lb addText: 'System complexity view'.
lb addRectanglePolymetricWidth: 'number of methods' height: 'Line of code' box: 'a Pharo class'.

lb addColorFadingFrom: Color red to: Color black text: 'Number of lines of code'.
lb build.

b
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

abergel

Re: Improvement of the legend

In reply to this post by Thierry Goubier

Hi Thierry and Chris,

What do you think about the legend on demand I have committed. Is it really necessary to have a thumbnail or can we live without ? :-)

Cheers,
Alexandre

> On Jul 10, 2015, at 5:17 PM, Thierry Goubier <[hidden email]> wrote:
>
>
>
> 2015-07-10 17:15 GMT+02:00 Chris Cunningham <[hidden email]>:
>
> On Fri, Jul 10, 2015 at 5:09 AM, Tudor Girba <[hidden email]> wrote:
> Hi,
>
> Nice. However, the way the legend is presented is too intrusive. If you look at the picture, the first thing that draws your attention is the legend, not the data.
>
> I would prefer to have the legend available only on demand, rather than always. We could introduce a symbol (e.g., ?) that is always available on the top right or bottom right and that can toggle the legend on or off (or only offer it when we hover over the symbol). What do you think?
>
> Or instead of a symbol, and thumbnail version of the legend.
>
> +1
>
> Thierry
>
>
> Cheers,
> Doru
>
>
> <snip>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Thierry Goubier

Re: Improvement of the legend

Le 11/07/2015 13:29, Alexandre Bergel a écrit :
> Hi Thierry and Chris,
>
> What do you think about the legend on demand I have committed. Is it
> really necessary to have a thumbnail or can we live without ? :-)

A thumbnail, I want a thumbnail :)

The legend a bit more opaque maybe when displayed, to make it easier to
read.

Thanks for the work :)

Thierry

> Cheers, Alexandre
>
>
>> On Jul 10, 2015, at 5:17 PM, Thierry Goubier
>> <[hidden email]> wrote:
>>
>>
>>
>> 2015-07-10 17:15 GMT+02:00 Chris Cunningham
>> <[hidden email]>:
>>
>> On Fri, Jul 10, 2015 at 5:09 AM, Tudor Girba <[hidden email]>
>> wrote: Hi,
>>
>> Nice. However, the way the legend is presented is too intrusive. If
>> you look at the picture, the first thing that draws your attention
>> is the legend, not the data.
>>
>> I would prefer to have the legend available only on demand, rather
>> than always. We could introduce a symbol (e.g., ?) that is always
>> available on the top right or bottom right and that can toggle the
>> legend on or off (or only offer it when we hover over the symbol).
>> What do you think?
>>
>> Or instead of a symbol, and thumbnail version of the legend.
>>
>> +1
>>
>> Thierry
>>
>>
>> Cheers, Doru
>>
>>
>> <snip>
>>
>> _______________________________________________ Moose-dev mailing
>> list [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>> _______________________________________________ Moose-dev mailing
>> list [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

cbc

Re: Improvement of the legend

In reply to this post by abergel

On Sat, Jul 11, 2015 at 4:29 AM, Alexandre Bergel <[hidden email]> wrote:

Hi Thierry and Chris,

What do you think about the legend on demand I have committed. Is it really necessary to have a thumbnail or can we live without ? :-)

Cheers,
Alexandre

I think a thumbnail would be best. You could probably do a link (called 'Legend' - the pictures leave many things open to missing the intent - '?' would be more 'how do I do stuff with this' to me at least).

The reasons for a thumbnail are many - it is really obvious what it is.

When you take a screen shot of the graphic, you have a chance of interpreting the thumbnail legend (small, but it exists).

And it is neat.

And I agree with Thierry that the legend needs to be more opaque. I can't make out most of the legend as-shown.

Very exciting!

-cbc

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev