Christophe/Stef,
Metacello Pharo5.0 tests are green[1]! The "default" test fails, but that test is designed to validate the examples in the documentation and I believe that the failure occurs while attempting to load Seaside3.1.3[2] and I'm pretty sure that Seaside3.1.3 won't load into Pharo5.0 so we're in business ... I will move the "default" test back to pharo4.0 and submit a bug that the Metacello docs/examples need to be updated for Pharo5.0 ... Dale [1] https://travis-ci.org/dalehenrich/metacello-work/builds/74470530 [2] https://travis-ci.org/dalehenrich/metacello-work/jobs/74470531#L2603 On 08/06/2015 11:41 AM, Dale Henrichs wrote: > Christophe, > > It looks like Metacello travis builds are still failing for > Pharo5.0[1]. The error appears to be occurring in the builderCI > Metacello bootstrapping code. So I will shift my focus to that area > ... Since 5.0 already has Metacello installed (like GemStone) we > should arrange to skip the Metacello bootsrap step altogether ... I > will look into that now ... > > Since my travis builds are failing, it would help if someone can > confirm that the master branch of Metacello can be used by Pharo5.0 > while I tackle the builderCI issues ... > > Thanks, > > Dale > > [1] https://travis-ci.org/dalehenrich/metacello-work/builds/74445315 > On 08/06/2015 10:42 AM, Dale Henrichs wrote: >> Okay I'm back and looking into this (I had some family issues to >> attend to over the last few weeks) ... >> >> I've merge Christophe's changes for Pharo5.0 into the Metacello >> master branch ... there is a chicken and egg problem in testing >> fundamental changes in Metacello on travis, since the travis >> framework (builderCI [1]) reuires Metacello to be loaded ... the >> tests are running at the moment and I'll try to stay on top of this >> until we get things loading smoothly for Pharo 5.0 >> >> Dale >> >> [1] https://github.com/dalehenrich/builderCI >> On 07/24/2015 03:28 AM, Stephan Eggermont wrote: >>> On 24-07-15 11:14, Thierry Goubier wrote: >>>> Hi Peter, >>>> >>>> the FileTree part is solved, as far as I could do (i.e. all tests >>>> green >>>> with Pharo5 on Linux), but there is a failure in the travis CI of the >>>> most annoying type: the filetree code isn't even loaded :( >>> >>> The BaseLineOfMetacello was misisng Pharo5.x platform attributes. >>> >>> Pull request 358 >>> >>> Stephan >>> >>> >> > |
In reply to this post by Dale Henrichs-3
Le 06/08/2015 22:25, Dale Henrichs a écrit :
> Thierry, > > One test failure[1] on the pharo5.0 branch > (MCGitFileTreeLoaderTest>>#testCypressCuisLoad.). Ok, I'll have a look as soon as my internet access is stable enough to rebuild a Pharo5.0 image. I don't think it is very important. > But we've gotten past the BaselineOfFileTree load errors, so I think > we're in business! Yes! Thierry > > Dale > > [1] https://travis-ci.org/dalehenrich/filetree/builds/74448965#L547 > > On 08/06/2015 10:47 AM, Dale Henrichs wrote: >> Thierry, >> >> I've kicked off a pharo5.0 branch test for FileTree[1] ... with the >> pharo5.0 changes merged in the Metacello, builderCI should be able to >> function again.. The builderCI test is running here[2], but I'm >> flooding travis with builds, so it may be a while before they all finish:) >> >> Anyway, if I get the tests scheduled we'll at least you can take a >> look at any failures if they pop up ... >> >> Thanks, >> >> Dale >> >> [1] https://travis-ci.org/dalehenrich/filetree/builds/74448965 >> [2] https://travis-ci.org/dalehenrich/builderCI/builds/74445951 >> >> On 07/24/2015 02:14 AM, Thierry Goubier wrote: >>> Hi Peter, >>> >>> the FileTree part is solved, as far as I could do (i.e. all tests >>> green with Pharo5 on Linux), but there is a failure in the travis CI >>> of the most annoying type: the filetree code isn't even loaded :( >>> >>> I'm going on annual leave later today, and Dale told me he won't be >>> easily available for a few weeks; I'll try to make some progress on >>> it during the holidays, but don't count too much on it ;) >>> >>> In the meantime, if someone would be nice to setup Metacello and >>> FileTree in Pharo5 as external projects with a configuration, it >>> would immensely help. FileTree on the pharo5.0_dev is ready for it >>> (apart for the travis CI), as are the tests. >>> >>> Thierry >>> >>> 2015-07-24 11:00 GMT+02:00 Peter Uhnák <[hidden email] >>> <mailto:[hidden email]>>: >>> >>> Is there any update on this? >>> >>> Thanks, >>> Peter >>> >>> On Mon, Jul 20, 2015 at 10:26 PM, Dale Henrichs >>> <[hidden email] >>> <mailto:[hidden email]>> wrote: >>> >>> Wait, the "fix" was on the pharo5.0_dev branch (not clear to >>> me whether this was even run against pharo5.0[1]) so it looks >>> like Metacello is stalled by FileTree issues at the moment >>> and it looks like Thierry is tackling the issues .... >>> >>> Dale >>> >>> [1] https://travis-ci.org/dalehenrich/filetree/builds/71656767 >>> >>> On 07/20/2015 01:13 PM, Dale Henrichs wrote: >>>> Okay ... apparently it isn't enough to fix the FileTree for >>>> Pharo 5.0, because that nets you a MNU with >>>> FileReference>>closed[1]. >>>> >>>> This issue looks to have been fixed a day ago[3], so I will >>>> see if I can kick off a rebuild of PR #351[2] and see where >>>> the port stands ... >>>> >>>> Dale >>>> >>>> [1] >>>> https://github.com/dalehenrich/metacello-work/pull/351#issuecomment-122550670 >>>> [2] https://github.com/dalehenrich/metacello-work/pull/351 >>>> [3] https://travis-ci.org/dalehenrich/filetree/builds/71656767 >>>> >>>> On 07/20/2015 12:35 PM, Peter Uhnák wrote: >>>>> Hmm, #onWarningLog doesn't exist either. >>>>> >>>>> I'm assuming this is the issue >>>>> https://pharo.fogbugz.com/f/cases/15456/Load-latest-version-of-metacello >>>>> >>>>> There's linked github issue >>>>> https://github.com/dalehenrich/metacello-work/issues/354 >>>>> >>>>> But running the script (in the github issue) fails, because >>>>> there's no defined spec for FileTree for Pharo 5.0 >>>>> >>>>> I'm not knowledgeable in Monticello so I don't know if I >>>>> can do anything to help besides user testing. >>>>> >>>>> Peter >>>>> >>>>> On Mon, Jul 20, 2015 at 9:22 PM, Marcus Denker >>>>> <[hidden email] <mailto:[hidden email]>> wrote: >>>>> >>>>> No. There is an issue on the issue tracker. >>>>> >>>>> If nobody pushes, nothing will happen. >>>>> >>>>> Marcus >>>>> >>>>>> On 20 Jul 2015, at 21:04, Peter Uhnák >>>>>> <[hidden email] <mailto:[hidden email]>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I was playing around with metacello because I wanted >>>>>> to ignore warnings with locks... >>>>>> >>>>>> currently I am doing something like >>>>>> >>>>>> ~~~~~~~~ >>>>>> Metacello new >>>>>> baseline: 'ProjectAAA'; >>>>>> repository: 'gitfiletree:///path/to/projectAAA'; >>>>>> lock. >>>>>> >>>>>> Metacello new >>>>>> baseline: 'ProjectBBB'; >>>>>> repository: 'gitfiletree:///projectBBB'; >>>>>> onConflict: [ :ex | ex allow ]; >>>>>> load. >>>>>> ~~~~~~~~~ >>>>>> >>>>>> This will load both projects via gitfiletree, however >>>>>> it will also generate a lots of lock warnings which I >>>>>> have to manually confirm - this is bad for scripts. >>>>>> >>>>>> So the docs ( >>>>>> https://github.com/dalehenrich/metacello-work/blob/master/docs/LockCommandReference.md >>>>>> ) >>>>>> >>>>>> mention onLock: [ :ex | ex honor ], however in Pharo >>>>>> 5.0 there is no such method "honor". >>>>>> >>>>>> Is this bug? >>>>>> Should Metacello be updated on Pharo 5.0? >>>>>> Will this even solve my problems? (Honoring locks >>>>>> while not throwing warnings). >>>>>> >>>>>> Thanks, >>>>>> Peter >>>>> >>>>> >>>> >>> >>> >>> >> > |
In reply to this post by Dale Henrichs-3
Le 6 août 2015 à 20:41, Dale Henrichs a écrit : > Christophe, > > It looks like Metacello travis builds are still failing for Pharo5.0[1]. The error appears to be occurring in the builderCI Metacello bootstrapping code. So I will shift my focus to that area ... Since 5.0 already has Metacello installed (like GemStone) we should arrange to skip the Metacello bootsrap step altogether ... I will look into that now ... indeed, I'm not sure it is really needed to update Metacello if it is already present in builderCI. > > Since my travis builds are failing, it would help if someone can confirm that the master branch of Metacello can be used by Pharo5.0 while I tackle the builderCI issues ... Yes, they are green: https://ci.inria.fr/rmod/job/Metacello/552/ Thank you Dale to take time to fix builderCI. Christophe smime.p7s (5K) Download Attachment |
On 08/06/2015 01:37 PM, Christophe Demarey wrote: > Le 6 août 2015 à 20:41, Dale Henrichs a écrit : > >> Christophe, >> >> It looks like Metacello travis builds are still failing for Pharo5.0[1]. The error appears to be occurring in the builderCI Metacello bootstrapping code. So I will shift my focus to that area ... Since 5.0 already has Metacello installed (like GemStone) we should arrange to skip the Metacello bootsrap step altogether ... I will look into that now ... > indeed, I'm not sure it is really needed to update Metacello if it is already present in builderCI. > The basic builderCI framework is based on using Metacello, so a Baseline aware version of Metacello is required to be present and builderCI will bootstrap Metacello if necessary ... Since Pharo5.0 has Metacello present no bootstrapping by builderCI is needed (this was true for Pharo3.0 and Pharo5.0 so it was an update that was needed for builderCI to skip bootstrapping Metacello) ... For the Metacello tests themselves, the version of Metacello under test is installed on top of the version present in the image, using the "standard Metacello update code" ... failures at this point indicate Metacello upgrade problems ... then the unit tests are run ... Dale |
Le 6 août 2015 à 22:49, Dale Henrichs a écrit : > For the Metacello tests themselves, the version of Metacello under test is installed on top of the version present in the image, using the "standard Metacello update code" ... failures at this point indicate Metacello upgrade problems ... then the unit tests are run ... ok, I found hat is missing. Metacello update through the BaselineOfMetacello works ... but the code used for the bootsrap of Metacello in BuilderCI uses the ConfigurationOfMetacelloPreview and load the stable version that is currently 1.0.0-beta.32.17. I think when there is already a version of Metacello able to load through the baseline, builderCi should use the Baseline to update Metacello. WDYT? Cheers, Christophe smime.p7s (5K) Download Attachment |
On 08/07/2015 01:08 AM, Christophe Demarey wrote: > Le 6 août 2015 à 22:49, Dale Henrichs a écrit : > >> For the Metacello tests themselves, the version of Metacello under test is installed on top of the version present in the image, using the "standard Metacello update code" ... failures at this point indicate Metacello upgrade problems ... then the unit tests are run ... > ok, I found hat is missing. > Metacello update through the BaselineOfMetacello works ... but the code used for the bootsrap of Metacello in BuilderCI uses the ConfigurationOfMetacelloPreview and load the stable version that is currently 1.0.0-beta.32.17. The change I made to builderCI[1] involves skipping the bootstrap of Metacello (via ConfigurationOfMetacelloPreview) completely. The Metacello bootstrap was been skipped for Pharo3.0 and Pharo4.0 and we just missed that detail when adding Pharo5.0. [1] https://github.com/dalehenrich/builderCI/commit/0394467e5d13c7e99500fd30175a1210225f71ac > I think when there is already a version of Metacello able to load through the baseline, builderCi should use the Baseline to update Metacello. > WDYT? builderCI only ensures that there is a Metacello available, I don't think that it should upgrade Metacello ... I use builderCI to test the upgrade/update of Metacello to a new version so to have builderCI automatically update would defeat the purpose and mask issues. Also if there are issues in the shipped version of Metacello that show up when loading a particular project, then those issues should be revealed, since the standard workflow for loading into an image should not include lading the latest Metacello first... If a project chooses to test with the latest version of Metacello (something I often do for GemStone tests) then the project itself should do the upgrade ... Dale |
Free forum by Nabble | Edit this page |