Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

Next Topic
 
classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Dear Colleagues,
I am currently working on issue 106, which is to add the coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,
Hemal
--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPf%2BwJ-hR29Zc7FUJX8PHB7cJXG91rm-HM72oq4nVF_faw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

SergeStinckwich
Yes I think this is the code of Werner.
Are you there Werner to help a little bit Hemal ?
Thank you.


On Mon, Jul 8, 2019 at 10:04 PM Hemal Varambhia <[hidden email]> wrote:
Dear Colleagues,
I am currently working on issue 106, which is to add the coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,
Hemal
--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPf%2BwJ-hR29Zc7FUJX8PHB7cJXG91rm-HM72oq4nVF_faw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


--
Serge Stinckwic
​h​

Int. Research Unit
 on Modelling/Simulation of Complex Systems (UMMISCO)
​Sorbonne University
 (SU)
French National Research Institute for Sustainable Development (IRD)​
U
​niversity of Yaoundé I​, Cameroon
"Programs must be written for people to read, and only incidentally for machines to execute."
https://twitter.com/SergeStinckwich

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CAOysuxWkOFoaZdYH7%2BPxRJVms4mWP%3DL58BwjyKNCimKVg%2BS3SA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
In reply to this post by hemalvarambhia
Dear Werner,
I am currently working on issue 106, which is to add the coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

I have refactored findKey to make the logic clearer, but your review and advice on why an error should be raised would be helpful because I lack understanding/context here. The link to the refactoring PR is:


Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,
Hemal

PS. Thank you, Serge, for appealing to Werner on my behalf.

On Mon, 8 Jul 2019, 22:04 Hemal Varambhia, <[hidden email]> wrote:
Dear Colleagues,
I am currently working on issue 106, which is to add the coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,
Hemal
--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPdFcyVKk4cdOUROYd-LTg8XupCG7fTFzbCw%3DG1emf7tfQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
In reply to this post by hemalvarambhia
Hi Hemal, Hi Serge,
i have to admit i dont check this group regularly, but since Serge sent an email to me directly, now i noticed it. i dont know what coveralls.io is, but i downloaded pharo8 and polymath and noticed an error in PMAccuracyTest>>testIfSeveralterations. if this is the problem, that can probably be repaired by changing this line in PMAccuraccy>>run: from
self ifSeveralterations: [ aStream << 'iterations: '    << iterations; cr ].
to
self ifSeveralterations: [ aStream << 'iterations: '    << iterations asString; cr ].

does that help, Hemal?
werner

On Monday, July 8, 2019 at 11:04:31 PM UTC+2, Hemal Varambhia wrote:
Dear Colleagues,
I am currently working on <a href="https://github.com/PolyMathOrg/PolyMath/issues/106" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%2F106\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE11NftqYC2-JziUe4AB4H6q8M5oA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%2F106\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE11NftqYC2-JziUe4AB4H6q8M5oA&#39;;return true;">issue 106, which is to add the <a href="http://coveralls.io" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fcoveralls.io\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEcwMpDJPhJpp7as5w2OLFQy4v1Uw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fcoveralls.io\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEcwMpDJPhJpp7as5w2OLFQy4v1Uw&#39;;return true;">coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,
Hemal
--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/10349477-0da2-4803-991b-b3d8236b1138%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:


It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

Hemal

On Sun, 14 Jul 2019, 15:33 werner kassens, <[hidden email]> wrote:
Hi Hemal, Hi Serge,
i have to admit i dont check this group regularly, but since Serge sent an email to me directly, now i noticed it. i dont know what coveralls.io is, but i downloaded pharo8 and polymath and noticed an error in PMAccuracyTest>>testIfSeveralterations. if this is the problem, that can probably be repaired by changing this line in PMAccuraccy>>run: from
self ifSeveralterations: [ aStream << 'iterations: '    << iterations; cr ].
to
self ifSeveralterations: [ aStream << 'iterations: '    << iterations asString; cr ].

does that help, Hemal?
werner

On Monday, July 8, 2019 at 11:04:31 PM UTC+2, Hemal Varambhia wrote:
Dear Colleagues,
I am currently working on issue 106, which is to add the coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,
Hemal
--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/10349477-0da2-4803-991b-b3d8236b1138%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPeWEzThp24oGwpk%3DPWKvoBM%3D%2B7zfRzOyt9ks%2B2VJPD%2BvQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.
werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229

It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Dear Werner,
That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.

In terms of local setup and reproducing the error in that link, use the instructions here. I recommend you checkout the development branch.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 09:42, werner kassens <[hidden email]> wrote:
Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.
werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:


It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPfYQExNo5QjU7HgzajsAi8nN90_1Ch85s6R7Vn3us-uBg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Werner and Serge,
As mentioned earlier in the chain the refactoring PR is now ready for your perusal:


Please review when you have energy and capacity. The key thing to mention here is that the ifNone clause in findKey now yields an empty string. This way any client using this code is guaranteed to get a string back and won't have to resort to null checks. Of course this isn't final and your advice/review on this would be very helpful.

Once this is accepted and merged, I will proceed to get the Math-Accuracy package under test coverage for us as a new PR.

Thank you, Werner, for helping to unblock me.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 10:57, Hemal Varambhia <[hidden email]> wrote:
Dear Werner,
That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.

In terms of local setup and reproducing the error in that link, use the instructions here. I recommend you checkout the development branch.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 09:42, werner kassens <[hidden email]> wrote:
Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.
werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:


It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPfX5VhKwO7hHmpyD%3D3X6AUD9%2BL4pmVtM%2BabLRRTNobxrg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

SergeStinckwich
I merge the PR.
Thank you to both of you.


On Tue, Jul 16, 2019 at 10:57 PM Hemal Varambhia <[hidden email]> wrote:
Werner and Serge,
As mentioned earlier in the chain the refactoring PR is now ready for your perusal:


Please review when you have energy and capacity. The key thing to mention here is that the ifNone clause in findKey now yields an empty string. This way any client using this code is guaranteed to get a string back and won't have to resort to null checks. Of course this isn't final and your advice/review on this would be very helpful.

Once this is accepted and merged, I will proceed to get the Math-Accuracy package under test coverage for us as a new PR.

Thank you, Werner, for helping to unblock me.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 10:57, Hemal Varambhia <[hidden email]> wrote:
Dear Werner,
That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.

In terms of local setup and reproducing the error in that link, use the instructions here. I recommend you checkout the development branch.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 09:42, werner kassens <[hidden email]> wrote:
Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.
werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:


It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPfX5VhKwO7hHmpyD%3D3X6AUD9%2BL4pmVtM%2BabLRRTNobxrg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


--
Serge Stinckwic
​h​

Int. Research Unit
 on Modelling/Simulation of Complex Systems (UMMISCO)
​Sorbonne University
 (SU)
French National Research Institute for Sustainable Development (IRD)​
U
​niversity of Yaoundé I​, Cameroon
"Programs must be written for people to read, and only incidentally for machines to execute."
https://twitter.com/SergeStinckwich

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CAOysuxXQRCz4-%2Bcve23G5Rr3XFOK0Ba4O%2BuEx-rytfuVnL6htA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
In reply to this post by hemalvarambhia
Hi Hemal,
it is my impression that the second example in the docu with

initializeSine
self argument: (0 to: Float pi by: Float pi /2).
self result: #((0)(1)(0))

and

checkSine
^self argument sin

doesnt work anymore but this has nothing to do with your changes. i had constructed the Accuracy package a bit complicated, and i'd guess it should simply be thrown away.
werner

On Tuesday, July 16, 2019 at 11:57:29 PM UTC+2, Hemal Varambhia wrote:
Werner and Serge,
As mentioned earlier in the chain the refactoring PR is now ready for your perusal:

<a href="https://github.com/PolyMathOrg/PolyMath/pull/139" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F139\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNESZ6Xn4krF3WF0RfxkGW8p4t4kAA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F139\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNESZ6Xn4krF3WF0RfxkGW8p4t4kAA&#39;;return true;">https://github.com/PolyMathOrg/PolyMath/pull/139

Please review when you have energy and capacity. The key thing to mention here is that the ifNone clause in findKey now yields an empty string. This way any client using this code is guaranteed to get a string back and won't have to resort to null checks. Of course this isn't final and your advice/review on this would be very helpful.

Once this is accepted and merged, I will proceed to get the Math-Accuracy package under test coverage for us as a new PR.

Thank you, Werner, for helping to unblock me.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 10:57, Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="3A2vTYcEBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.v...@...> wrote:
Dear Werner,
That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.

In terms of local setup and reproducing the error in that link, use the instructions <a href="https://github.com/hpi-swa/smalltalkCI#how-to-local" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhpi-swa%2FsmalltalkCI%23how-to-local\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHWPJZqu0wsTQcVmQtVU1UE7808oA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhpi-swa%2FsmalltalkCI%23how-to-local\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHWPJZqu0wsTQcVmQtVU1UE7808oA&#39;;return true;">here. I recommend you checkout the development branch.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 09:42, werner kassens <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="3A2vTYcEBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">werne...@...> wrote:
Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.
werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229

It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="3A2vTYcEBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/7d275e3a-99f3-4ff6-9ac9-332cd5249fc7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal

On Wed, 17 Jul 2019, 11:26 werner kassens, <[hidden email]> wrote:
Hi Hemal,
it is my impression that the second example in the docu with

initializeSine
self argument: (0 to: Float pi by: Float pi /2).
self result: #((0)(1)(0))

and

checkSine
^self argument sin

doesnt work anymore but this has nothing to do with your changes. i had constructed the Accuracy package a bit complicated, and i'd guess it should simply be thrown away.
werner

On Tuesday, July 16, 2019 at 11:57:29 PM UTC+2, Hemal Varambhia wrote:
Werner and Serge,
As mentioned earlier in the chain the refactoring PR is now ready for your perusal:


Please review when you have energy and capacity. The key thing to mention here is that the ifNone clause in findKey now yields an empty string. This way any client using this code is guaranteed to get a string back and won't have to resort to null checks. Of course this isn't final and your advice/review on this would be very helpful.

Once this is accepted and merged, I will proceed to get the Math-Accuracy package under test coverage for us as a new PR.

Thank you, Werner, for helping to unblock me.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 10:57, Hemal Varambhia <[hidden email]> wrote:
Dear Werner,
That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.

In terms of local setup and reproducing the error in that link, use the instructions here. I recommend you checkout the development branch.

Yours sincerely,
Hemal

On Tue, 16 Jul 2019 at 09:42, werner kassens <[hidden email]> wrote:
Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.
werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:


It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/7d275e3a-99f3-4ff6-9ac9-332cd5249fc7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPdeq5h%3DEF_U1vQu-BGk30d4npyZ3NGERo1jThVGr6dVNw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
Hi Hemal,
yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.
werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal


--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Werner,
Could you send me the failing code and steps to reproduce the problem?

Hemal


On Wed, 17 Jul 2019, 12:56 werner kassens, <[hidden email]> wrote:
Hi Hemal,
yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.
werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal


--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPf-Xv038amGjbfmr7EF-B4mxE1LNcrU%2B7-EZ6k0woApSQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
Hi Hemal
i attached AccuracySin.st.
you file it in and then do:

a:=AccuracySin new.
a run.

which produces an error
werner

On Wednesday, July 17, 2019 at 2:03:36 PM UTC+2, Hemal Varambhia wrote:
Werner,
Could you send me the failing code and steps to reproduce the problem?

Hemal


On Wed, 17 Jul 2019, 12:56 werner kassens, <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="nND6hbMyBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">werne...@...> wrote:
Hi Hemal,
yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.
werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal


--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="nND6hbMyBAAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

AccuracySin.st (600 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Werner,
Could you send me a screenshot of the error, please? I do get an error as well - it says that floating point numbers are not indexable (see screenshot below). Is this what you get?

accuracy_error.png

Yours sincerely,
Hemal

On Wed, 17 Jul 2019 at 13:22, werner kassens <[hidden email]> wrote:
Hi Hemal
i attached AccuracySin.st.
you file it in and then do:

a:=AccuracySin new.
a run.

which produces an error
werner

On Wednesday, July 17, 2019 at 2:03:36 PM UTC+2, Hemal Varambhia wrote:
Werner,
Could you send me the failing code and steps to reproduce the problem?

Hemal


On Wed, 17 Jul 2019, 12:56 werner kassens, <[hidden email]> wrote:
Hi Hemal,
yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.
werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal


--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPe33MQQSKr0wVyt_%2BsF9hxF6GOnN0MAFNJ4u-Qc7hTm0g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
yes exactly
werner

On Wednesday, July 17, 2019 at 5:39:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Could you send me a screenshot of the error, please? I do get an error as well - it says that floating point numbers are not indexable (see screenshot below). Is this what you get?

accuracy_error.png

Yours sincerely,
Hemal

On Wed, 17 Jul 2019 at 13:22, werner kassens <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="TPhu_X8-BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">werne...@...> wrote:
Hi Hemal
i attached AccuracySin.st.
you file it in and then do:

a:=AccuracySin new.
a run.

which produces an error
werner

On Wednesday, July 17, 2019 at 2:03:36 PM UTC+2, Hemal Varambhia wrote:
Werner,
Could you send me the failing code and steps to reproduce the problem?

Hemal


On Wed, 17 Jul 2019, 12:56 werner kassens, <[hidden email]> wrote:
Hi Hemal,
yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.
werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal


--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="TPhu_X8-BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/ba4456d4-3e1f-4e0c-a87a-8337a01bdc75%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

hemalvarambhia
Werner,
I had a look through the stacktrace and it doesn't contain any of the methods that I changed so I am likely missing something. Was the instance created correctly from what you can see in the debugger? Perhaps we could pair on this to get to the root cause. Do you have some time this Friday?

Hemal

On Wed, 17 Jul 2019 at 17:27, werner kassens <[hidden email]> wrote:
yes exactly
werner

On Wednesday, July 17, 2019 at 5:39:49 PM UTC+2, Hemal Varambhia wrote:
Werner,
Could you send me a screenshot of the error, please? I do get an error as well - it says that floating point numbers are not indexable (see screenshot below). Is this what you get?

accuracy_error.png

Yours sincerely,
Hemal

On Wed, 17 Jul 2019 at 13:22, werner kassens <[hidden email]> wrote:
Hi Hemal
i attached AccuracySin.st.
you file it in and then do:

a:=AccuracySin new.
a run.

which produces an error
werner

On Wednesday, July 17, 2019 at 2:03:36 PM UTC+2, Hemal Varambhia wrote:
Werner,
Could you send me the failing code and steps to reproduce the problem?

Hemal


On Wed, 17 Jul 2019, 12:56 werner kassens, <[hidden email]> wrote:
Hi Hemal,
yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.
werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:
Werner,
You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal


--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/ba4456d4-3e1f-4e0c-a87a-8337a01bdc75%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
 
"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPc0WWgVzV7scKvOCtp%3DxY5bfWsq3-oopZ4hyygC4OQFRQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

werner kassens-2
Hi Hemal,
i looked at all our changes & they are not responsible for that error. this is obviously the result of some changes in pharo and those things will repeat with future changes; eg in pharo 8 the change that i mentioned in an earlier message will be necessary & the necessity won't be visible with the tests as they are not complete enough (im not sure but perhaps it will be visible when one makes a test that runs AccuracySine, didnt try that). the general problem with this package is that it is in principle just a simple database program that does not use any of the standard databases, but does everything by itself & additionally uses occasionally some lowlevel functions & with your changes is not really covered by tests, iow i would _seriously_ just throw it away. originally i made it only because i needed it for making the genetic algo & therefore it was fine, but it was for me just a little subprogram quickly cobbled together, because i needed it, nothing worth keeping.
werner

p.s. i dont want to pair program, i never did this, dont have the necessary programs for it (no messenger program at all), havent used pharo for a year ( iow i am much too slow for this <friendly grin>)

On Wednesday, July 17, 2019 at 7:14:29 PM UTC+2, Hemal Varambhia wrote:
Werner,
I had a look through the stacktrace and it doesn't contain any of the methods that I changed so I am likely missing something. Was the instance created correctly from what you can see in the debugger? Perhaps we could pair on this to get to the root cause. Do you have some time this Friday?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/d6027b1a-81ae-4683-8bfc-5220cfae4619%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.