Issue 106: Help with Math-Accuracy Error Raised From findKey During CI Run

Dear Colleagues,

I am currently working on <a href="https://github.com/PolyMathOrg/PolyMath/issues/106" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%2F106\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE11NftqYC2-JziUe4AB4H6q8M5oA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%2F106\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNE11NftqYC2-JziUe4AB4H6q8M5oA&#39;;return true;">issue 106, which is to add the <a href="http://coveralls.io" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fcoveralls.io\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEcwMpDJPhJpp7as5w2OLFQy4v1Uw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fcoveralls.io\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEcwMpDJPhJpp7as5w2OLFQy4v1Uw&#39;;return true;">coveralls.io test coverage tool to the PolyMath project. At this point I am currently blocked by the Math-Tests-Accuracy and Math-Accuracy packages, which are yielding an error with the message 'run:in:with: called in wrong context.' The 'run:in:with:' comes from SmalltalkCI, our CI tool of choice. Werner, from Serge I understand that you are the author of the above-mentioned packages. Would you be willing to pair with me on this? I could use your expertise here. If so, when would be best? I would prefer Fridays if that is possible.

Thank you for your assistance in the above regard. I look forward to hearing from you in due course.

Yours sincerely,

Hemal

--

 

"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

Werner,

Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229

It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

Werner and Serge,

As mentioned earlier in the chain the refactoring PR is now ready for your perusal:

<a href="https://github.com/PolyMathOrg/PolyMath/pull/139" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F139\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNESZ6Xn4krF3WF0RfxkGW8p4t4kAA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F139\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNESZ6Xn4krF3WF0RfxkGW8p4t4kAA&#39;;return true;">https://github.com/PolyMathOrg/PolyMath/pull/139

Please review when you have energy and capacity. The key thing to mention here is that the ifNone clause in findKey now yields an empty string. This way any client using this code is guaranteed to get a string back and won't have to resort to null checks. Of course this isn't final and your advice/review on this would be very helpful.

Once this is accepted and merged, I will proceed to get the Math-Accuracy package under test coverage for us as a new PR.

Thank you, Werner, for helping to unblock me.

Yours sincerely,

Hemal

On Tue, 16 Jul 2019 at 10:57, Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="3A2vTYcEBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.v...@...> wrote:

Dear Werner,

That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.

In terms of local setup and reproducing the error in that link, use the instructions <a href="https://github.com/hpi-swa/smalltalkCI#how-to-local" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhpi-swa%2FsmalltalkCI%23how-to-local\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHWPJZqu0wsTQcVmQtVU1UE7808oA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhpi-swa%2FsmalltalkCI%23how-to-local\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHWPJZqu0wsTQcVmQtVU1UE7808oA&#39;;return true;">here. I recommend you checkout the development branch.

Yours sincerely,

Hemal

On Tue, 16 Jul 2019 at 09:42, werner kassens <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="3A2vTYcEBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">werne...@...> wrote:

Hi Hemal,
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.

werner

On Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:

Werner,

Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath%2Fjobs%2F553440229\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFUoKOig-wIGgR6Ay4wa38TQQseJw&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath/jobs/553440229

It comes from the error raised in findKey. Does that really need to throw an error?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="3A2vTYcEBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--

 

"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

--

 

"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

Werner,

You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal

Werner,

Could you send me the failing code and steps to reproduce the problem?

Hemal

On Wed, 17 Jul 2019, 12:56 werner kassens, <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="nND6hbMyBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">werne...@...> wrote:

Hi Hemal,

yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.

werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:

Werner,

You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="nND6hbMyBAAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

Werner,

Could you send me a screenshot of the error, please? I do get an error as well - it says that floating point numbers are not indexable (see screenshot below). Is this what you get?

Yours sincerely,

Hemal

On Wed, 17 Jul 2019 at 13:22, werner kassens <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="TPhu_X8-BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">werne...@...> wrote:

Hi Hemal

i attached AccuracySin.st.

you file it in and then do:

a:=AccuracySin new.
a run.

which produces an error

werner

On Wednesday, July 17, 2019 at 2:03:36 PM UTC+2, Hemal Varambhia wrote:

Werner,

Could you send me the failing code and steps to reproduce the problem?

Hemal

On Wed, 17 Jul 2019, 12:56 werner kassens, <[hidden email]> wrote:

Hi Hemal,

yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.

werner

On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:

Werner,

You mean delete the Math-Accuracy package entirely from PolyMath?

Hemal

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="TPhu_X8-BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--

 

"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL

Home:  +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908

Werner,

I had a look through the stacktrace and it doesn't contain any of the methods that I changed so I am likely missing something. Was the instance created correctly from what you can see in the debugger? Perhaps we could pair on this to get to the root cause. Do you have some time this Friday?

Hemal