Issue # 1498 "Collections should not accept non integer indexes"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue # 1498 "Collections should not accept non integer indexes"

csrabak
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute.

However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.

So I'll resort to the alternative plan, which is to send the changeset to this list. On a core image update #11067 the Collection tests are all green.  Running all tests show one error and two failures not related to the changed methods.

--
Cesar Rabak


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Slice-CesarRabak-Issue-1489.cs (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Issue 332, 1489, 1529: arithmetic protocols extracted from core

Simon Denier-3

On 1 déc. 2009, at 21:07, [hidden email] wrote:

I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute.

However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.

Hi Cesar, I took your changeset and prepared a Slice, I did not have any problem.

So this is a batch of 3 slices for issue 332 and related issues 1489 and 1529, pair programming by me & Cesar during the Pharo sprint in Buenos Aires

Issue 332: Arithmetic protocol should be removed from Collections and Strings
Issue 1489: Collections shuould not accept non integer as indexes
Issue 1529: Date and time classes should not rely on collections arithmetic

with CollectionArithmetic now an extra package in squeaksource.

Tests unchanged, minus tests related to arithmetic which of course have been moved to the extra package.


So I'll resort to the alternative plan, which is to send the changeset to this list. On a core image update #11067 the Collection tests are all green.  Running all tests show one error and two failures not related to the changed methods.

--
Cesar Rabak

<Slice-CesarRabak-Issue-1489.cs>_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

--
 Simon




_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 332, 1489, 1529: arithmetic protocols extracted from core

csrabak
Em 02/12/2009 01:41, Simon Denier < [hidden email] > escreveu:
>
>  On 1 déc. 2009, at 21:07, [hidden email] wrote:
>
> > I'm    trying    to    follow    the    directions    given    at:
> >http://code.google.com/p/pharo/wiki/HowToContribute.
> > However, after  the SLICE asks  for the first comment,  it freezes
> > the image and the small  window "Writing definitions" stays at 50%
> > progress and nothing happens then.

>  Hi Cesar,  I took your  changeset and prepared  a Slice, I  did not
> have any problem.

Nice to know, Simon.  Just to understand how I can troubleshoot this: did you
empoly a core or dev image to do the Monticello stuff?



_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 332, 1489, 1529: arithmetic protocols extracted from core

Simon Denier-3

On 2 déc. 2009, at 09:56, [hidden email] wrote:

Em 02/12/2009 01:41, Simon Denier < [hidden email] > escreveu:

On 1 déc. 2009, at 21:07, [hidden email] wrote:

I'm    trying    to    follow    the    directions    given    at:
http://code.google.com/p/pharo/wiki/HowToContribute.
However, after  the SLICE asks  for the first comment,  it freezes
the image and the small  window "Writing definitions" stays at 50%
progress and nothing happens then.

Hi Cesar,  I took your  changeset and prepared  a Slice, I  did not
have any problem.

Nice to know, Simon.  Just to understand how I can troubleshoot this: did you
empoly a core or dev image to do the Monticello stuff?

A core image. Perhaps you can try to repeat the steps, Monticello can take some times to do its stuff, from time to time.

--
 Simon




_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 332, 1489, 1529: arithmetic protocols extracted from core

Miguel Cobá
In reply to this post by csrabak
El mié, 02-12-2009 a las 10:56 -0200, [hidden email] escribió:

> Em 02/12/2009 01:41, Simon Denier < [hidden email] > escreveu:
> >
> >  On 1 déc. 2009, at 21:07, [hidden email] wrote:
> >
> > > I'm    trying    to    follow    the    directions    given    at:
> > >http://code.google.com/p/pharo/wiki/HowToContribute.
> > > However, after  the SLICE asks  for the first comment,  it freezes
> > > the image and the small  window "Writing definitions" stays at 50%
> > > progress and nothing happens then.
>
> >  Hi Cesar,  I took your  changeset and prepared  a Slice, I  did not
> > have any problem.
>
> Nice to know, Simon.  Just to understand how I can troubleshoot this: did you
> empoly a core or dev image to do the Monticello stuff?
>

Always use a core image to prepare the SLICES.

Cheers
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
--
Miguel Cobá
http://miguel.leugim.com.mx


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 332, 1489, 1529: arithmetic protocols extracted from core

csrabak
Miguel,

I've used the core image and just  had it updated as the first bullet of
instructions direct.

I was just curious :-)

Em 02/12/2009 16:42, Miguel Enrique Cobá Martinez < [hidden email] > escreveu:


El mié, 02-12-2009 a las 10:56 -0200, [hidden email] escribió:

> Em 02/12/2009 01:41, Simon Denier < [hidden email] > escreveu:
> >
> >  On 1 déc. 2009, at 21:07, [hidden email] wrote:
> >
> > > I'm    trying    to    follow    the    directions    given    at:
> > >http://code.google.com/p/pharo/wiki/HowToContribute.
> > > However, after  the SLICE asks  for the first comment,  it freezes
> > > the image and the small  window "Writing definitions" stays at 50%
> > > progress and nothing happens then.
>
> >  Hi Cesar,  I took your  changeset and prepared  a Slice, I  did not
> > have any problem.
>
> Nice to know, Simon.  Just to understand how I can troubleshoot this: did you
> empoly a core or dev image to do the Monticello stuff?
>

Always use a core image to prepare the SLICES.

Cheers
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
--
Miguel Cobá
http://miguel.leugim.com.mx


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project