Smalltalk › Pharo › Pharo Smalltalk Developers

Issue 1554

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Danny Chan

Issue 1554

Hi!

I just uploaded my first fix (or so I hope) for Pharo to the Inbox as
Ocompletion-DannyChan.44, following the instructions on the wiki for
contributions.

When selecting a text in a workspace including the first character in
the window and hitting backspace, an exception will be thrown by
ocompletion, because the smartBackspace method will try to look at the
character before the current position of the caret, which is 0 in this
case.

The instructions on the wiki say to put the status of the bug report to
fixed, but I saw no way to do this. Did I miss something?

By the way, I want to thank all of you for the great work you put into
Pharo. I am no software developer myself, but I really hope to be able
to use it for all the little tools I need all the time at work.

Danny

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Adrian Lienhard

Re: Issue 1554

Hi Danny,

Thanks for your contribution.

Your change is in the package Ocompletion, which is outside Pharo-
core. This package is maintained by Romain. I added Romain to CC so he
can merge your fix into the main branch of Ocompletion.

Cheers,
Adrian

On Dec 8, 2009, at 09:09 , Danny Chan wrote:

> Hi!
>
> I just uploaded my first fix (or so I hope) for Pharo to the Inbox as
> Ocompletion-DannyChan.44, following the instructions on the wiki for
> contributions.
>
> When selecting a text in a workspace including the first character in
> the window and hitting backspace, an exception will be thrown by
> ocompletion, because the smartBackspace method will try to look at the
> character before the current position of the caret, which is 0 in this
> case.
>
> The instructions on the wiki say to put the status of the bug report
> to
> fixed, but I saw no way to do this. Did I miss something?
>
> By the way, I want to thank all of you for the great work you put into
> Pharo. I am no software developer myself, but I really hope to be able
> to use it for all the little tools I need all the time at work.
>
> Danny
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Damien Cassou

Re: Issue 1554

2009/12/8 Adrian Lienhard <[hidden email]>:
> Thanks for your contribution.
>
> Your change is in the package Ocompletion, which is outside Pharo-
> core. This package is maintained by Romain. I added Romain to CC so he
> can merge your fix into the main branch of Ocompletion.

Done.

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Lambdas are relegated to relative obscurity until Java makes them
popular by not having them." James Iry

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project