Issue 1692: MNU when tried to navigate pop up menus with the keyboard

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 1692: MNU when tried to navigate pop up menus with the keyboard

Francisco Ortiz Peñaloza
Pharo image: Pharo-core
Pharo core version: PharoCore1.1ALPHA Latest update: #11116
Virtual machine used: Squeak 4.2.2beta1U | Cocoa Squeak 5.0.0b9 64*32

Steps to reproduce:
1. Open a pop up using your mouse o pressing <esc>
2. Try to select an action using your keyboard. Enter text to narrow
down your matching items or
using the arrow keys, neither work anymore.

Francisco

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1692: MNU when tried to navigate pop up menus with the keyboard

Mariano Martinez Peck
Hi Alain: This bug seems related with the new preference architecture.

Look the method before your change was:

MenuMorph >> drawOn:

    super drawOn: aCanvas.

    (ActiveHand notNil
            and: [ActiveHand keyboardFocus == self]
            and: [self rootMenu hasProperty: #hasUsedKeyboard])
        ifTrue: [
            aCanvas
                frameAndFillRectangle: self innerBounds
                fillColor: Color transparent
                borderWidth: Preferences menuBorderWidth
                borderColor: Preferences keyboardFocusColor
        ].



Now it is:

drawOn: aCanvas
    "Draw the menu. Add keyboard-focus feedback if appropriate"

    super drawOn: aCanvas.

    (ActiveHand notNil
            and: [ActiveHand keyboardFocus == self]
            and: [self rootMenu hasProperty: #hasUsedKeyboard])
        ifTrue: [
            aCanvas
                frameAndFillRectangle: self innerBounds
                fillColor: Color transparent
                borderWidth: self theme settings menuBorderWidth
                borderColor: self theme settings menuBorderColor.
        ].


The problem is that "self theme settings menuBorderColor"  is returned #raised  and thus, the DNU with isTransparent.
The problem is that flatMenu is nil.

Solutions ?

- Change " self theme settings menuBorderColor."  for "Preference keyboardFocusColor"
NOOOOO TO THIS SOLUTION!!!

- Change to hardcore a color, something like:  "borderColor: Color lightGray"

This is all I can help :)

Cheers

Mariano




On Fri, Dec 25, 2009 at 11:13 PM, Francisco Ortiz Peñaloza <[hidden email]> wrote:
Pharo image: Pharo-core
Pharo core version: PharoCore1.1ALPHA Latest update: #11116
Virtual machine used: Squeak 4.2.2beta1U | Cocoa Squeak 5.0.0b9 64*32

Steps to reproduce:
1. Open a pop up using your mouse o pressing <esc>
2. Try to select an action using your keyboard. Enter text to narrow
down your matching items or
using the arrow keys, neither work anymore.

Francisco

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1692: MNU when tried to navigate pop up menus with the keyboard

Alain Plantec-4
Mariano Martinez Peck a écrit :
> Hi Alain: This bug seems related with the new preference architecture.
indeed, I will check that very soon.
Alain


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1692: MNU when tried to navigate pop up menus with the keyboard

Mariano Martinez Peck


On Mon, Jan 4, 2010 at 7:58 AM, Alain Plantec <[hidden email]> wrote:
Mariano Martinez Peck a écrit :
> Hi Alain: This bug seems related with the new preference architecture.
indeed, I will check that very soon.

Cool. Take it easy. No one is rushing :)
 
Alain


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1692: MNU when tried to navigate pop up menus with the keyboard

Alain Plantec-4
Mariano Martinez Peck a écrit :

>
>
> On Mon, Jan 4, 2010 at 7:58 AM, Alain Plantec <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Mariano Martinez Peck a écrit :
>     > Hi Alain: This bug seems related with the new preference
>     architecture.
>     indeed, I will check that very soon.
>
>
> Cool. Take it easy. No one is rushing :)
SLICE-Issue1692-KeyboardFocusColor is in inbox.
Thanks for reporting
Alain

>  
>
>     Alain
>
>
>     _______________________________________________
>     Pharo-project mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project