Issue 230 in glassdb: Number class>>readFrom: fails when Locale class>>decimalPoint not '.'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 230 in glassdb: Number class>>readFrom: fails when Locale class>>decimalPoint not '.'

glassdb
Status: Accepted
Owner: [hidden email]
Labels: Type-Defect Priority-Medium GLASS-Server Version-1.0-beta.8  
Milestone-1.0-beta.8.6

New issue 230 by [hidden email]: Number class>>readFrom: fails when  
Locale class>>decimalPoint not '.'
http://code.google.com/p/glassdb/issues/detail?id=230

While debugging Max Leske's report about test failures that hadn't  
reproduced in my test environment:

   http://forum.world.st/failing-tests-td3244020.html

specifically, SqueakTests>>#testReadFrom.

Upon code inspection, Number class>>readRemainderOf:from:base:withSign:,  
directly checks for a $. when parsing Floats, which means the parser fails  
if a Locale uses a different decimalPoint character...

In Max's description of the problem he mentions the value of the  
ScaledDecimal was "'34,' (yes, a comma, no fraction)" which implies that  
the printString for ScaledDecimal uses the Locale to create the  
printString...

Need to have a test environment with multiple locale's installed so I can  
flush these problems out.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 230 in glassdb: Number class>>readFrom: fails when Locale class>>decimalPoint not '.'

glassdb
Updates:
        Labels: -Milestone-1.0-beta.8.6 Milestone-1.0-beta.8.7
        Blockedon: 229

Comment #1 on issue 230 by [hidden email]: Number class>>readFrom:  
fails when Locale class>>decimalPoint not '.'
http://code.google.com/p/glassdb/issues/detail?id=230

part of making use of SqNumberParser needs to be making it Locale  
friendly .... while making sure that Locale is used on the printing side  
consistently ...

Reply | Threaded
Open this post in threaded view
|

Re: Issue 230 in glassdb: Number class>>readFrom: fails when Locale class>>decimalPoint not '.'

glassdb
Updates:
        Status: Fixed
        Labels: Fixed-1.0-beta.8.7

Comment #2 on issue 230 by [hidden email]: Number class>>readFrom:  
fails when Locale class>>decimalPoint not '.'
http://code.google.com/p/glassdb/issues/detail?id=230

SqNumberParser should be using Locale class>>decimalPoint when parsing  
numbers show `34,` should be parsed correctly moving forward ... not sure  
if all of the printStrings use Locale?

Name: ConfigurationOfGsCore-dkh.185
Author: dkh
Time: 03/25/2011, 14:02:33
UUID: 9b0249eb-a255-45d9-8ccd-99fdf9fb964c
Ancestors: ConfigurationOfGsCore-dkh.184