Issue 247 in glassdb: Loading class def with shadowed IV and no "correction" corrupts class hierarchy

Status: Accepted
Owner: [hidden email]
Labels: Type-Defect Priority-Medium GLASS-Server Version-1.0-beta.8  
Milestone-1.0-beta.8.6

New issue 247 by [hidden email]: Loading class def with shadowed IV and  
no "correction" corrupts class hierarchy
http://code.google.com/p/glassdb/issues/detail?id=247

In the Monticello-Mocks package the class MCMockClassL has an instance  
variable 'ivar', so creating a package that adds the instance  
variable 'ivar' to MCMockClassJ will cause a duplicate instance variable  
error and if you close the walkback, you'll notice that the class structure  
of MCMockClassJ is corrupted.

In a development scenario, the instance variable would be removed from  
MCMockClassL in another class definition in the same package - that  
scenario is actually covered (by an earlier bugfix).

However, in this case the class structure is corrupted and no repair takes  
place ...

Updates:
        Status: Fixed
        Labels: Fixed-1.0-beta.8.6

Comment #1 on issue 247 by [hidden email]: Loading class def with  
shadowed IV and no "correction" corrupts class hierarchy
http://code.google.com/p/glassdb/issues/detail?id=247

tough nut, this one ... have to repair the root class _after_ the new class  
version is created ...


Name: Monticello.g-DaleHenrichs.425
Author: DaleHenrichs
Time: 03/02/2011, 13:51:19
UUID: 0485948e-13ce-4f1b-a2f6-fe8083711fa1
Ancestors: Monticello.g-DaleHenrichs.424

Updates:
        Status: Started
        Labels: -Fixed-1.0-beta.8.6

Comment #2 on issue 247 by [hidden email]: Loading class def with  
shadowed IV and no "correction" corrupts class hierarchy
http://code.google.com/p/glassdb/issues/detail?id=247

  ... not so fast bucko ... a look at the image sideways and the tests start  
failing ...

Comment #3 on issue 247 by [hidden email]: Loading class def with  
shadowed IV and no "correction" corrupts class hierarchy
http://code.google.com/p/glassdb/issues/detail?id=247

first pass through tests and the last test run passed because the an error  
was being thrown, but it was the wrong error and class structure left  
corrupted... on second pass of tests, the other tests failed because of the  
left over corruption ...

run tests twice before believing results:)

Updates:
        Status: Fixed
        Labels: Fixed-1.0-beta.8.6

Comment #4 on issue 247 by [hidden email]: Loading class def with  
shadowed IV and no "correction" corrupts class hierarchy
http://code.google.com/p/glassdb/issues/detail?id=247

beefed up tests and shored up fix.

Name: Monticello.g-DaleHenrichs.426
Author: DaleHenrichs
Time: 03/02/2011, 15:26:47
UUID: 8df850cf-8bf3-4bea-b82a-3e7c885e0ece
Ancestors: Monticello.g-DaleHenrichs.425

In middle of Seaside3.0.4 port, so this fix will get hammered on shortly...