Issue 269 in glassdb: SmaCC: scanner uses incorrect stream indexing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 269 in glassdb: SmaCC: scanner uses incorrect stream indexing

glassdb
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium GLASS-Server Version-GLASS0.231

New issue 269 by [hidden email]: SmaCC: scanner uses incorrect stream  
indexing
http://code.google.com/p/glassdb/issues/detail?id=269

As a result from the different stream positioning in GS and Squeak/Pharo,  
scanners can index the stream on a position of -1.

The following two methods need to set the index to 1 instead of 0 (correct  
code included below).
I would commit these changes myself in gemsource, but I don't have access.

SmaCCScanner>>resetOutputToLastMatch
        outputStream position: lastOutputStreamMatchPosition.
        lastOutputStreamMatchPosition == 1
                ifTrue:
                        [lastMatchWasEmpty ifTrue: [self scannerError].
                        lastMatchWasEmpty := true]
                ifFalse: [lastMatchWasEmpty := false]

SmaCCScanner>>resetScanner
        start := stream position.
        outputStream reset.
        lastOutputStreamMatchPosition := 1

Reply | Threaded
Open this post in threaded view
|

Re: Issue 269 in glassdb: SmaCC: scanner uses incorrect stream indexing

glassdb
Updates:
        Status: Accepted
        Labels: Milestone-1.0-beta.8.7

Comment #1 on issue 269 by [hidden email]: SmaCC: scanner uses  
incorrect stream indexing
http://code.google.com/p/glassdb/issues/detail?id=269

(No comment was entered for this change.)

Reply | Threaded
Open this post in threaded view
|

Re: Issue 269 in glassdb: SmaCC: scanner uses incorrect stream indexing

glassdb
Updates:
        Status: Fixed
        Labels: Fixed-1.0-beta.8.7

Comment #2 on issue 269 by [hidden email]: SmaCC: scanner uses  
incorrect stream indexing
http://code.google.com/p/glassdb/issues/detail?id=269

Incorporated your changes. GsMisc 0.239.1 (dkh.79).

Added GLASS DEVS group to SmaCC project ....