Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo
Status: Fixed
Owner: [hidden email]
CC: stephane.ducasse
Labels: Milestone-1.2

New issue 3254 by [hidden email]: [Repackage] "Regular expressions"  
should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

Pharo 1.2a 12235:

I now reorganized the regular expression package:
  - tests are now in 'Regex-Tests-Core' (closer to the code than in
    the general Test package)
  - categories now start with 'Regex-...' instead of 'VB-Regex-...'
    (so nobody should think its a port from VisualBasic ;)
  - there was an RxParser "Documentation" method category
    => this has been converted to a help book
  - missing class comments were added and the note regarding
    the specific Documentation method category was removed

Install the two changesets.

After that you should have:
  - a new "Regex-Core" package
  - a changed package "Tests" since tests are now repackaged close to the  
code
  - a new "Regex-Help" package  => this has to be SAVED
  - a "Regex-Tests-Help" package  => this has to be SAVED
  - the package "VB-Regex" is obsolete then

Attachments:
        01 Reorg Regex.1.cs  9.6 KB
        02 Enhance Regex.1.cs  44.1 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #1 on issue 3254 by [hidden email]: [Repackage] "Regular  
expressions" should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

Slice is in SLICE-Issue-3254-RepackageRegexpressions-TorstenBergmann.1


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #2 on issue 3254 by [hidden email]: [Repackage] "Regular  
expressions" should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

After loading the slice one should also evaluate:

Smalltalk organization removeSystemCategory: 'VB-Regex'.
Smalltalk organization removeSystemCategory: 'VB-Regex-Exceptions'.
Smalltalk organization sortCategories.

to remove the obsolete empty categories


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #3 on issue 3254 by renggli: [Repackage] "Regular expressions"  
should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

Please note that this package is coming from VisualWorks and in the past 10  
years there were new improved versions released every couple of years. Also  
note that Pharo is already behind the latest ported and improved code  
available in <http://source.lukas-renggli.ch/unsorted/>.

So "well structuring" the package likely does not do much good in this  
situation. Maybe it would be better to remove the code from Pharo-Core and  
just load it in Pharo.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #4 on issue 3254 by aplantec: [Repackage] "Regular expressions"  
should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

no, don't remove it from the core.
I'm using it for Editor cleaning and improvements.
a repackaging problem is not a good reason to remove a package from the  
core.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #5 on issue 3254 by stephane.ducasse: [Repackage] "Regular  
expressions" should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

We should merge the versions of lukas then.
I agree with you alain we want regex to be used to simply a lot of old code.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #6 on issue 3254 by stephane.ducasse: [Repackage] "Regular  
expressions" should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

We should merge the versions of lukas then.
I agree with you alain we want regex to be used to simply a lot of old code.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #7 on issue 3254 by stephane.ducasse: [Repackage] "Regular  
expressions" should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

lukas we are just two releases beyond I thought it was much more :).



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #8 on issue 3254 by stephane.ducasse: [Repackage] "Regular  
expressions" should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

I just integrated the latest version available on lukas repository


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3254 in pharo: [Repackage] "Regular expressions" should be well structured

pharo

Comment #9 on issue 3254 by aplantec: [Repackage] "Regular expressions"  
should be well structured
http://code.google.com/p/pharo/issues/detail?id=3254

super