Issue 3283 in pharo: Symbol dependencie

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3283 in pharo: Symbol dependencie

pharo
Status: Fixed
Owner: Benjamin.VanRyseghem.Pharo

New issue 3283 by Benjamin.VanRyseghem.Pharo: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

Attached : a change sort which fix a dependencie between Symbol and Scanner

Attachments:
        SymbolClassReadFrom.1.cs  532 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo
Updates:
        Status: Started

Comment #1 on issue 3283 by marcus.denker: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

Nope...

Symbol readFromString: '#''abc'''




Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo

Comment #2 on issue 3283 by Benjamin.VanRyseghem.Pharo: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

It's fixed (I hope).

I've totally remodel dependencies between Symbol and Scanner :
      TypeTable is now in String
      isLiteralSymbol is in String too
      readFrom: does not depends of Scanner anymore
      neither does storeOn:
      I've added some tests (and recategorized some others), but if someone  
can have a look at SymbolTest>>#expectedBehavior, cause I do not know very  
well the expected behavior ^^


The changeSort is attached

Attachments:
        SymbolClassReadFrom.2.cs  34.0 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo

Comment #3 on issue 3283 by Benjamin.VanRyseghem.Pharo: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

I can't charge the cs, I don't know why, but I'm on it


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo

Comment #4 on issue 3283 by Benjamin.VanRyseghem.Pharo: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

I've make a lot of cs to be sure the order is good, and this time, I can  
charge the 8 files ^^

Attachments:
        FixSymbol.1.cs  4.4 KB
        FixSymbol.2.cs  11.1 KB
        FixSymbol.3.cs  11.9 KB
        FixSymbol.4.cs  13.2 KB
        FixSymbol.5.cs  13.7 KB
        FixSymbol.6.cs  15.4 KB
        FixSymbol.7.cs  17.6 KB
        FixSymbol.8.cs  18.1 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo
Updates:
        Status: Fixed

Comment #5 on issue 3283 by Benjamin.VanRyseghem.Pharo: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo
Updates:
        Labels: Type-Seed

Comment #6 on issue 3283 by Benjamin.VanRyseghem.Pharo: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo
Updates:
        Labels: Milestone-1.2

Comment #7 on issue 3283 by siguctua: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3283 in pharo: Symbol dependencie

pharo

Comment #8 on issue 3283 by stephane.ducasse: Symbol dependencie
http://code.google.com/p/pharo/issues/detail?id=3283

benjamin this is a bit messy.
I'm lost