Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-ReportDefect Milestone-1.2

New issue 3292 by [hidden email]: SourceReference>>parseTimestampFrom:  
chokes on 'tk 2/18/97'
http://code.google.com/p/pharo/issues/detail?id=3292

I ran into the error running OBMercuryPanelTest>>testSenders.

The following expression will trigger the problem:

   SourcedMethodReference
     class: Dictionary
     selector: #keyAtValue:ifAbsent:

when executed in a Pharo1.2a-12251 image. It looks like the timestamp  
parser isn't written to accomodate older timestamp forms


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

pharo

Comment #1 on issue 3292 by [hidden email]:  
SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'
http://code.google.com/p/pharo/issues/detail?id=3292

Amongst other missing things, all timestamp cases were indeed not covered  
yet.
A fix is coming up...


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

pharo

Comment #2 on issue 3292 by Benjamin.VanRyseghem.Pharo:  
SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'
http://code.google.com/p/pharo/issues/detail?id=3292

It should fix the problem ^^

Attachments:
        VeronicasBugFix.1.cs  1.2 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

pharo
Updates:
        Status: Closed

Comment #3 on issue 3292 by marcus.denker:  
SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'
http://code.google.com/p/pharo/issues/detail?id=3292

12255


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

pharo

Comment #4 on issue 3292 by [hidden email]:  
SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'
http://code.google.com/p/pharo/issues/detail?id=3292

The fix does not treat all cases. Try:

Smalltalk allClasses do:[:cl | cl selectors do:[:sel |  
SourcedMethodReference class: cl selector: sel]]

I'm *now* working on it...


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3292 in pharo: SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'

pharo

Comment #5 on issue 3292 by [hidden email]:  
SourceReference>>parseTimestampFrom: chokes on 'tk 2/18/97'
http://code.google.com/p/pharo/issues/detail?id=3292

Fix put in PharoInbox in System-Support-JohanBrichau.408