Issue 3356 in pharo: AllocationTest>>#isSafeVM

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3356 in pharo: AllocationTest>>#isSafeVM

pharo
Status: Fixed
Owner: Benjamin.VanRyseghem.Pharo

New issue 3356 by Benjamin.VanRyseghem.Pharo: AllocationTest>>#isSafeVM
http://code.google.com/p/pharo/issues/detail?id=3356

This code

isSafeVM
        "False if the VM is a Unix VM that has not been updated to version 4.
        Earlier versions may be subject to a bug that can crash the VM when
        running AllocationTest."

        self flag: #toRemove. "April 2010 dtl - remove this about one year from  
now"
        ^ Smalltalk isUnix not
                or: [((Smalltalk vmFullPath
                                findTokens: FileDirectory slash)
                                select: [:e | e beginsWith: '4.']) isEmpty not]

Should be changed by :

isSafeVM
        "False if the VM is a Unix VM that has not been updated to version 4.
        Earlier versions may be subject to a bug that can crash the VM when
        running AllocationTest."

        self flag: #toRemove. "April 2010 dtl - remove this about one year from  
now"
        ^ Smalltalk isUnix not
                or: [((Smalltalk vmFullPath
                                findTokens: FileDirectory slash)
                                anySatisfy: [:e | e beginsWith: '4.'])]


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3356 in pharo: AllocationTest>>#isSafeVM

pharo

Comment #1 on issue 3356 by siguctua: AllocationTest>>#isSafeVM
http://code.google.com/p/pharo/issues/detail?id=3356

i'm sorry, but isn't it would be more correct to check VM version by  
querying VM itself, rather than trying to determine its version based on  
file/directory names?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3356 in pharo: AllocationTest>>#isSafeVM

pharo

Comment #2 on issue 3356 by Benjamin.VanRyseghem.Pharo:  
AllocationTest>>#isSafeVM
http://code.google.com/p/pharo/issues/detail?id=3356

probably ^^

but I do not know how to do that :)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3356 in pharo: AllocationTest>>#isSafeVM

pharo
Updates:
        Status: Closed
        Labels: Milestone-1.2

Comment #3 on issue 3356 by marcus.denker: AllocationTest>>#isSafeVM
http://code.google.com/p/pharo/issues/detail?id=3356

(No comment was entered for this change.)