Issue 3371 in pharo: problem with find & replace in PharoCore 1.2

Status: Accepted
Owner: aplantec
Labels: Milestone-1.2

New issue 3371 by aplantec: problem with find & replace in PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

 From Mariano
-----------------
I have a little bug. Suppose I search something, in this case, I serached  
the word "new" in testParagraphExtent
Now...it shows all the "new" with a orange color. Perfect. But then I put  
cancel, I go to other methods, and it is still painting "new"!!! ;)
I should do that when I change the method I guess, or when I press cancel.

Last little thing is that it would be nice to have the find & replace like  
a popup, so that you can close it from the windows title in addition  
to "close" button.
------------------

Comment #1 on issue 3371 by aplantec: problem with find & replace in  
PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

Le 02/12/2010 22:19, Francisco Ortiz Peñaloza a écrit :

> imho setting search text to empty string in any other context different  
> that the
> place you did the search would be the best
The search text is shared (as it has always been). maybe you notice that  
now because of the color.
As an example, when you browse all senders of a selector,
the selector is also in orange everywhere because the search text it set  
with it.
It can't be changed without further investigation.
and other people (like me) will argue that they like the current behavior...
Cheers
Alain

Ok, thanks! I agree with you about the colors, now i see them :)

Updates:
        Status: Fixed

Comment #2 on issue 3371 by aplantec: problem with find & replace in  
PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

In InBox
SLICE-Issue-3371-problem-with-find--replace-in-PharoCore-1-2

Comment #3 on issue 3371 by aplantec: problem with find & replace in  
PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371


     imho setting search text to empty string in any other context different  
that the place you did the search would be the best

     As an example if i search for "self" browsing a method even if after i  
open an Inspector i can see  "self" highlighted


Exatly. That's another problem. The scope. For me it should be only the  
method you are browsing....
or maybe an option to select scope:
- current method
- all methods of current class
- all classes (all system browser)

And, in my opinion, it should only put colors to the system browser...I  
don't know if it is worth it to do it also in Inspector, Debugger,  
workspace, etc....

Comment #4 on issue 3371 by aplantec: problem with find & replace in  
PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

I agree...
thanks for feedbacks and good ideas for futur improvements!
Alain

Comment #5 on issue 3371 by marianopeck: problem with find & replace in  
PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

Hi Alain.....sorry...I have just read the sentence "It can't be changed  
without further investigation.
and other people (like me) will argue that they like the current behavior.."

Please, don't listen only too me. I am only one guy and
- you are who developed this
- the behavior you want is the one it already was (I didn't notice because  
I never serached becasue the tools were very bad, but now I will start to  
do so)

so...it is ok for me if you keep it as you want. Maybe a setting? or even a  
checkbox in the search popop?

Comment #6 on issue 3371 by aplantec: problem with find & replace in  
PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

don't be sorry, it is a real pleasure to have feedbacks
and context aware selection would be very cool

Updates:
        Status: Closed

Comment #7 on issue 3371 by stephane.ducasse: problem with find & replace  
in PharoCore 1.2
http://code.google.com/p/pharo/issues/detail?id=3371

in 12270