Issue 3382 in pharo: BUG: Class variable creation behavior Inconsistent/incorrect

Status: New
Owner: ----

New issue 3382 by sean.p.denigris: BUG: Class variable creation behavior  
Inconsistent/incorrect
http://code.google.com/p/pharo/issues/detail?id=3382

* Class>>canFindWithoutEnvironment: checks the environment, making the  
behavior like bindingOf:
* changed Class>>declare: and Class>>addClassVarName:
        - check the environment (i.e. Class names) for class variable name  
conflicts
        - conflict error message confusing/inaccurate
* above conflict error in #declare is resumable, same error in  
#addClassVarName: is not

ClassTests
* uses depreciated methods on Class
* testHaSharedPools should be testHasSharedPools

Pharo image: Pharo-core
Pharo core version: Pharo1.2a Latest update: #12264

Fix in inbox SLICE-Issue-3382-Class-variable-creation-behavior-Inconsistentincorrect-SeanDeNigris.1

* fixed Class>>canFindWithoutEnvironment: (it was actually checking the environment, making the behavior like bindingOf:) and added test to KernelTests
* changed Class>>declare: and Class>>addClassVarName:
        - no longer check the environment for conflicts
        - conflict error message clarified
* made conflict error in #addClassVarName: resumable to match the behavior of #declare:

ClassTest - refactored and extended, including:
* added a test for Class>>canFindWithoutEnvironment:
* fixed spelling of testHaSharedPools
* fixed bug where temporary category was left after tests

Cheers,
Sean

Comment #1 on issue 3382 by sean.p.denigris: BUG: Class variable creation  
behavior Inconsistent/incorrect
http://code.google.com/p/pharo/issues/detail?id=3382

Fix in inbox  
SLICE-Issue-3382-Class-variable-creation-behavior-Inconsistentincorrect-SeanDeNigris.1

* fixed Class>>canFindWithoutEnvironment: (it was actually checking the  
environment, making the behavior like bindingOf:) and added test to  
KernelTests
* changed Class>>declare: and Class>>addClassVarName:
         - no longer check the environment for conflicts
         - conflict error message clarified
* made conflict error in #addClassVarName: resumable to match the behavior  
of #declare:

ClassTest - refactored and extended, including:
* added a test for Class>>canFindWithoutEnvironment:
* fixed spelling of testHaSharedPools
* fixed bug where temporary category was left after tests

Cheers,
Sean

Updates:
        Status: Fixed
        Labels: Milestone-1.3

Comment #2 on issue 3382 by marcus.denker: BUG: Class variable creation  
behavior Inconsistent/incorrect
http://code.google.com/p/pharo/issues/detail?id=3382

(No comment was entered for this change.)

Updates:
        Status: FixProposed

Comment #3 on issue 3382 by [hidden email]: BUG: Class variable  
creation behavior Inconsistent/incorrect
http://code.google.com/p/pharo/issues/detail?id=3382

(No comment was entered for this change.)

Updates:
        Labels: -Milestone-1.3

Comment #4 on issue 3382 by [hidden email]: BUG: Class variable  
creation behavior Inconsistent/incorrect
http://code.google.com/p/pharo/issues/detail?id=3382

(No comment was entered for this change.)