Issue 3467 in pharo: Clean up ExternalDropHandler vs. DefaultExternalDropHandler?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Issue 3467 in pharo: Clean up ExternalDropHandler vs. DefaultExternalDropHandler?

pharo
Status: Accepted
Owner: marcus.denker

New issue 3467 by marcus.denker: Clean up ExternalDropHandler vs.  
DefaultExternalDropHandler?
http://code.google.com/p/pharo/issues/detail?id=3467

We fixed Issue 2690 by just fixing the nil check.

But maybe we should clean up the dophandlers?

Comment 1 by project member [hidden email], Aug 05, 2010
Error was happening because of incorrect nil check and it happens for any  
file dropped which has more than one service registered.

Instead of fixing nil check, decided to rather remove class  
DefaultExternalDropHandler as it was doing same checks as  
ExternalDropHandler class. Because of this it would bring up the same  
chooser if the first chooser was cancelled.
It also delegated to the same default behaviour i.e. fileStream edit.

To add more handlers use ExternalDropHandler class>>registerHandler:. (see  
ExternalDropHandler class>>initialize

see

SLICE-Issue-2690-DropHandlerChooserCancelFix-CarloTeixeira.1