Issue 3478 in pharo: [Failing Test] Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit

Status: Accepted
Owner: marcus.denker
Labels: Milestone-1.2

New issue 3478 by marcus.denker: [Failing Test]  
Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit
http://code.google.com/p/pharo/issues/detail?id=3478

Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit

Updates:
        Cc: [hidden email]

Comment #1 on issue 3478 by stephane.ducasse: [Failing Test]  
Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit
http://code.google.com/p/pharo/issues/detail?id=3478

Argh this is probably since the plugin primitives are used. May be  
something was fixed in squeak to address that.
We should have a look or simply remove the primitives calls.

Comment #2 on issue 3478 by [hidden email]: [Failing Test]  
Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit
http://code.google.com/p/pharo/issues/detail?id=3478

Maybe because Andreas changed the test too and this was not integrated into  
Pharo:

See  
http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-December/156043.html

Pharo:
testBmp24Bit
         ...
        self assert: (form pixelValueAt: 1 @ 1) = 4278190080

It fails because the value is "4278190081"

Squeak:
testBmp24Bit
         ...
        self assert: (form pixelValueAt: 1@1) = 16rFF000001.

So if I'm using the test from Squeak (which is more readable anyway)
then it is green.

Updates:
        Status: Fixed
        Cc: stephane.ducasse

Comment #3 on issue 3478 by [hidden email]: [Failing Test]  
Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit
http://code.google.com/p/pharo/issues/detail?id=3478

SLICE-Issue-3478-fix-GraphicsTestsFilesBMPReadWriterTesttestBmp24Bit-tbn.1

aligns the test with the one from Squeak and the issue is fixed

Comment #4 on issue 3478 by stephane.ducasse: [Failing Test]  
Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit
http://code.google.com/p/pharo/issues/detail?id=3478

Good I did the same :)

Updates:
        Status: Closed

Comment #5 on issue 3478 by stephane.ducasse: [Failing Test]  
Graphics.Tests.Files.BMPReadWriterTest.testBmp24Bit
http://code.google.com/p/pharo/issues/detail?id=3478

in 12288