Issue 3481 in pharo: DEVImageCreator references to Preferences

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3481 in pharo: DEVImageCreator references to Preferences

pharo
Status: Accepted
Owner: guillermopolito
Labels: Milestone-1.2-DevImage

New issue 3481 by guillermopolito: DEVImageCreator references to Preferences
http://code.google.com/p/pharo/issues/detail?id=3481

In Pharo1.2 Dev


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3481 in pharo: DEVImageCreator references to Preferences

pharo

Comment #1 on issue 3481 by guillermopolito: DEVImageCreator references to  
Preferences
http://code.google.com/p/pharo/issues/detail?id=3481

In

DEVImageCreator>>openPreferenceBrowser
DEVImageCreator>>closeUnnecessaryWindows


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3481 in pharo: DEVImageCreator references to Preferences

pharo

Comment #2 on issue 3481 by marianopeck: DEVImageCreator references to  
Preferences
http://code.google.com/p/pharo/issues/detail?id=3481

#openPreferenceBrowser  can be removed because it is not used.

#closeUnnecessaryWindows  should be adapted so that it doesnt take into  
account the PreferenceBRower. FOr example:

closeUnnecessaryWindows
        SystemWindow allSubInstancesDo:
                [:window | window delete]

if you agree, we can commmit it


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3481 in pharo: DEVImageCreator references to Preferences

Guillermo Polito
I agree :P

On Sat, Dec 25, 2010 at 10:25 AM, <[hidden email]> wrote:

Comment #2 on issue 3481 by marianopeck: DEVImageCreator references to Preferences
#openPreferenceBrowser  can be removed because it is not used.

#closeUnnecessaryWindows  should be adapted so that it doesnt take into account the PreferenceBRower. FOr example:

closeUnnecessaryWindows
       SystemWindow allSubInstancesDo:
               [:window | window delete]

if you agree, we can commmit it



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3481 in pharo: DEVImageCreator references to Preferences

pharo
In reply to this post by pharo
Updates:
        Status: Fixed

Comment #3 on issue 3481 by guillermopolito: DEVImageCreator references to  
Preferences
http://code.google.com/p/pharo/issues/detail?id=3481

Done!


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3481 in pharo: DEVImageCreator references to Preferences

pharo

Comment #4 on issue 3481 by marianopeck: DEVImageCreator references to  
Preferences
http://code.google.com/p/pharo/issues/detail?id=3481

Name: ImageForDevelopers-pharo-MarianoMartinezPeck.245
Author: MarianoMartinezPeck
Time: 25 December 2010, 5:42 pm
UUID: 5a9559b4-e114-4331-a9cf-ad81466c7f89
Ancestors: ImageForDevelopers-pharo-LaurentLaffont.244

- Removed #openPreferenceBrowser
- Adapted #closeUnnecessaryWindows  without Preferences


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3481 in pharo: DEVImageCreator references to Preferences

pharo
Updates:
        Status: Closed

Comment #5 on issue 3481 by marianopeck: DEVImageCreator references to  
Preferences
http://code.google.com/p/pharo/issues/detail?id=3481

(No comment was entered for this change.)