Issue 3486 in pharo: RecentMessageList problem with PluggableTextMorph

Status: Fixed
Owner: Benjamin.VanRyseghem.Pharo

New issue 3486 by Benjamin.VanRyseghem.Pharo: RecentMessageList problem  
with PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

PluggableTextMorph should be able to support text styling, but some methods  
are missing. I've written the fix a while ago, I think it works, let's try  
^^

Attachments:
        SupportStyling.2.cs  70.5 KB

Updates:
        Cc: stephane.ducasse
        Labels: Milestone-1.2

Comment #1 on issue 3486 by marianopeck: RecentMessageList problem with  
PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

Thanks it works! can we integrate it ?  I put 1.2 milestone.

Comment #2 on issue 3486 by Benjamin.VanRyseghem.Pharo: RecentMessageList  
problem with PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

Yes I guess :) I think there is also the two styler packages, maybe we  
haven't to integrate them right now

Comment #3 on issue 3486 by stephane.ducasse: RecentMessageList problem  
with PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

Ok I will do that now.

Comment #4 on issue 3486 by stephane.ducasse: RecentMessageList problem  
with PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

Benjamin the changes seem to be long. Is it correct?

Comment #5 on issue 3486 by Benjamin.VanRyseghem.Pharo: RecentMessageList  
problem with PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

It's long because there is the packages STStyler80 and STParser, but I do  
not remember if I have done some changes in it or if it was just for tests …

Comment #6 on issue 3486 by stephane.ducasse: RecentMessageList problem  
with PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

I'm confused there are too many classes and I do not know if we want SH* in  
core.
We should check that carefully.
And this code looks old

SHPreferences,

SHParserST80>>-= aSymbol
        ^ 1 -= 2

Mariano is the problem you see only happening in pharo-dev?

Updates:
        Status: Accepted

Comment #7 on issue 3486 by marcus.denker: RecentMessageList problem with  
PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

Hmm... this needs to be solved differently. the SH* classes are not part of  
core.

Updates:
        Labels: -Milestone-1.2 Milestone-1.3

Comment #8 on issue 3486 by marcus.denker: RecentMessageList problem with  
PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

I think we can move that to 1.3

Comment #9 on issue 3486 by marianopeck: RecentMessageList problem with  
PluggableTextMorph
http://code.google.com/p/pharo/issues/detail?id=3486

No, you cannot tag it as 1.3 because the image is fucking broken. You  
cannot even open the HelpSystem nor use the Recentechanges, nothing. It has  
to be fixed for 1.2. I am not saying to integrate all these changes and  
merge all those clases. I am just saying that we need a quick and simple  
fix for pharo 1.2

cheers