Issue 3489 in pharo: Pharo 1.2-dev still uses Preferences in BaseSoundSystem

Status: Accepted
Owner: [hidden email]

New issue 3489 by [hidden email]: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Evaluate "Beeper beep" and you get a DNU since
BaseSoundSystem>>beep calls Preferences>>soundsEnabled which is not there.

Comment #1 on issue 3489 by [hidden email]: Pharo 1.2-dev still  
uses Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Preferences soundsEnabled is also sent in  
SoundPlayer>>resumePlaying:quickStart:

Updates:
        Labels: Milestone-1.2

Comment #2 on issue 3489 by [hidden email]: Pharo 1.2-dev still  
uses Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

(No comment was entered for this change.)

Comment #3 on issue 3489 by [hidden email]: Pharo 1.2-dev still  
uses Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Could be replaced with "SoundSettings soundEnabled"

Comment #4 on issue 3489 by [hidden email]: Pharo 1.2-dev still  
uses Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

But there is no setting similar to the old "Preferences soundQuickStart"

Comment #5 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Hi Torsten. Yes, there are still references to Preferences. If you could  
help us to fix them, it would be awesome. FOr this package in particular,  
please feel free to directly commit fixes to its repo:  
http://www.squeaksource.com/PharoSound/

it is global read and write.

thanks!

Comment #6 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Actually, if you take a pharo dev 1.2, there are still 20 references to  
Preferences :(

Comment #7 on issue 3489 by stephane.ducasse: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

ok where can I find pharodev to fix it?

Comment #8 on issue 3489 by laurent.laffont: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

On Hudson server ?
https://pharo-ic.lille.inria.fr/hudson/job/Pharo%201.2/lastSuccessfulBuild/artifact/Pharo-1.2.zip

Comment #9 on issue 3489 by stephane.ducasse: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

tx

Updates:
        Labels: -Milestone-1.2 Milestone-1.2-DevImage

Comment #10 on issue 3489 by marcus.denker: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

(No comment was entered for this change.)

Comment #11 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

We need people helping in this front...otherwise they will never be  
updated :(

Updates:
        Cc: hilaire.fernandes aplantec

Comment #12 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

I have just fixed as many as I could. There are still some pending ones:

Preferences canRecordWhilePlaying.
Preferences soundStopWhenDone.

People who is interested in Sound shoudl fix them.

Comment #13 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Sorry and Preferences soundQuickStart

Updates:
        Status: Started

Comment #14 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

(No comment was entered for this change.)

Comment #15 on issue 3489 by [hidden email]: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

Issue3566 contains base 1.2 changes for the new 1.2 compatible version in  
PharoSound.

Updates:
        Blockedon: 3566

Comment #16 on issue 3489 by [hidden email]: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

(No comment was entered for this change.)

Updates:
        Status: Fixed

Comment #17 on issue 3489 by [hidden email]: Pharo 1.2-dev still  
uses Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

fixed in a slice

Comment #18 on issue 3489 by [hidden email]: Pharo 1.2-dev still  
uses Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

It is in a Slice-3489 in PharoInbox.

But is integrated in pharo-dev.
Should not be integrated in Pharo-Core.

Comment #19 on issue 3489 by marianopeck: Pharo 1.2-dev still uses  
Preferences in BaseSoundSystem
http://code.google.com/p/pharo/issues/detail?id=3489

commited and merged. Also commited to Metacell configurations. I clos ethe  
issue