Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Status: Accepted
Owner: marianopeck
Labels: Milestone-1.2

New issue 3497 by marianopeck: Monticello Browser, +slice  doesn't validate  
for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

When creating a new slice in the Monticello browser, this tool  
automatically shows up all the dirty packages. For me (stupid) it was not  
obvious that I have to click on it and select them. This is why I upload an  
empty slice (without depedencies).

I suggest a validation that in case of not having selectd any package,  
raise a warning/error saying "You did not select any package. Are you sure  
you want to proceed and create an empty slice?"
or an error: "You did not select any package. Please select at least one."

Pharo core version: 12288


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Updates:
        Labels: -Milestone-1.2 Milestone-1.3

Comment #1 on issue 3497 by stephane.ducasse: Monticello Browser, +slice  
doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Updates:
        Labels: -Milestone-1.3

Comment #2 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Updates:
        Status: Started
        Cc: [hidden email]
        Labels: Milestone-1.2.2 Type-RequestForEnhancement Difficulty-Easy

Comment #3 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

I agree, I've just did the same mistake


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Updates:
        Status: FixProposed

Comment #4 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

Name:  
SLICE-Issue-3497-Monticello-Browser-slice-doesnt-validate-for-not-selecting-any-package-DamienCassou.1
Author: DamienCassou
Time: 12 April 2011, 11:31:32 am
UUID: 17a71d3e-be65-4341-b60e-93370ed34b25
Ancestors:
Dependencies: MonticelloGUI-DamienCassou.86

- Forces the user to select at least one package before being able to  
create a slice


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo

Comment #5 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

damien you mean before saving the slice?
Yes this is a good idea.



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo

Comment #6 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

I did what Mariano suggested: when the slice creation window is opened and  
you have to type the issue number and summary, the 'ok' button is getting  
enabled if and only if there is at least one dirty package selected.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Updates:
        Labels: -Milestone-1.2.2 Milestone-1.3

Comment #7 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

For 1.3


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3497 in pharo: Monticello Browser, +slice doesn't validate for not selecting any package

pharo
Updates:
        Status: Closed

Comment #8 on issue 3497 by [hidden email]: Monticello Browser,  
+slice  doesn't validate for not selecting any package
http://code.google.com/p/pharo/issues/detail?id=3497

in 13153