Issue 3507 in pharo: SUnitUnloader >> unloadTestPackages is wrong and outdated

Status: Accepted
Owner: marianopeck
Labels: Milestone-1.2

New issue 3507 by marianopeck: SUnitUnloader >> unloadTestPackages   is  
wrong and outdated
http://code.google.com/p/pharo/issues/detail?id=3507

SUnitUnloader >> unloadTestPackages
is wrong because it uses # instead of ''. This fails with packages  
like 'Gofer-Tests'.
In addition, this list is not updated.

Now, cleanUpForProduction saves 100kb more aprox ;)

Pharo core version: 12992

The change is to change unloadTestPackages  to:

unloadTestPackages
         
#('Tests' 'CollectionsTests' 'CompilerTests' 'FreeTypeTests' 'Graphics-Tests' 'KernelTests' 'MorphicTests' 'MultilingualTests' 'NetworkTests' 'ToolsTest' 'Gofer-Tests' 'Announcements-Tests-Core' 'CompressionTests' 'HelpSystem-Tests' 'Multilingual-Tests' 'Regex-Tests-Core')
                 do: [ :each | (MCPackage named: each) unload ].

if you agree I create a slice

Updates:
        Status: Fixed

Comment #1 on issue 3507 by marianopeck: SUnitUnloader >>  
unloadTestPackages   is wrong and outdated
http://code.google.com/p/pharo/issues/detail?id=3507

(No comment was entered for this change.)

Hi Mariano,

Nice to see you working on this (sorry, I still didn't get around to do the cleanUp: refactoring (if you like to do this, please go ahead)).

Regarding your extension of #unloadTestPackages I have the following remark: when I implemented this I took care to make all remaining packages non-dirty. For example, you unload "Regex-Tests-Core" and this will change the contents of the "Regex" package and hence make it dirty. To avoid this, I moved tests into their own package – either into their own package like in the case of GraphicsResources (see related comment on the issue tracker) or into the global test package "Tests".

Apparently somebody didn't take care when updating VB-Regex because the tests are back in the main Regex package.

Now, I don't know whether "clean packages" after shrinking is a desired property. It's not critical for me but it feels better to have a well modularized image without needing to unload random sub-packages, classes and methods.

Cheers,
Adrian

On Jan 5, 2011, at 23:08 , [hidden email] wrote:

> Updates:
> Status: Fixed
>
> Comment #1 on issue 3507 by marianopeck: SUnitUnloader >> unloadTestPackages   is wrong and outdated
> http://code.google.com/p/pharo/issues/detail?id=3507
>
> (No comment was entered for this change.)
>
>

Updates:
        Cc: stephane.ducasse

Comment #2 on issue 3507 by marianopeck: SUnitUnloader >>  
unloadTestPackages   is wrong and outdated
http://code.google.com/p/pharo/issues/detail?id=3507

In inbox

Name: SLICE-Issue-3507-unloadTestPackagesIsOutdated-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 6 January 2011, 7:35:54 pm
UUID: c182a210-fb4f-4205-9c26-4f1874864774
Ancestors:
Dependencies: SUnit-MarianoMartinezPeck.40121

Fix to issue 3507

Updates:
        Status: Closed

Comment #3 on issue 3507 by marcus.denker: SUnitUnloader >>  
unloadTestPackages   is wrong and outdated
http://code.google.com/p/pharo/issues/detail?id=3507

12293