Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo
Status: Accepted
Owner: marianopeck
Labels: Milestone-1.2

New issue 3508 by marianopeck: cleanUpForProduction should really  
unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

now cleanUpForProduction  is doing:


        (MCPackage named: 'GraphicsResources') unload.

but the package doesn't exist. So, it should be:

(MCPackage named: 'Graphics-Resources') unload.

Pharo core version: 12292


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo
Updates:
        Status: Fixed

Comment #1 on issue 3508 by marianopeck: cleanUpForProduction should really  
unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

(No comment was entered for this change.)


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo
Updates:
        Status: Comment

Comment #2 on issue 3508 by adrian.lienhard: cleanUpForProduction should  
really unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

No! :)

This is on purpose. There is no class category GraphicsResources but there  
are class extensions *graphicsresources (you can see this when you browse  
the package with MC).

The reason I did this is to be able to unload these methods without making  
the package 'Graphics' dirty. These graphic resources are not needed unless  
you want to recreate the icons.

Adrian


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo

Comment #3 on issue 3508 by marianopeck: cleanUpForProduction should really  
unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

Hi Adrian. Are you checking in Pharo1.2 ?  Because I don't see any package  
GraphicsResources and in addition, if I browse Graphics-Resources  I see  
the class extensions with the correct caegory *GraphicsResources

Finally, I don't see a package Graphics, but instead all Graphics-Something

cheers


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo
Updates:
        Status: Fixed

Comment #4 on issue 3508 by adrian.lienhard: cleanUpForProduction should  
really unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

Hi Mariano. Here too, I checked with a 1.1.1 image. In 1.2 also the  
graphics package structure was changed (in a good way). Apparently this was  
done with issue ##2105.

So the change you propose with this issue makes sense!

Sorry for the confusion...
Adrian



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo

Comment #5 on issue 3508 by marianopeck: cleanUpForProduction should really  
unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

Thanks adrian for the warning :)
In inbox:

Name:  
SLICE-Issue-3508-cleanUpForProductionShouldRemoveGraphicsResources-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 6 January 2011, 8:03:33 pm
UUID: dc80b20c-ddce-41d2-b9e6-48e4c4fe5dc5
Ancestors:
Dependencies: ScriptLoader12-MarianoMartinezPeck.365

fix to issue 3508


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3508 in pharo: cleanUpForProduction should really unload 'Graphics-Resources'

pharo
Updates:
        Status: Closed

Comment #6 on issue 3508 by marcus.denker: cleanUpForProduction should  
really unload 'Graphics-Resources'
http://code.google.com/p/pharo/issues/detail?id=3508

12293