Issue 3515 in pharo: Failing Test: RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod

Status: Accepted
Owner: marcus.denker
Labels: Milestone-1.2-DevImage

New issue 3515 by marcus.denker: Failing Test:  
RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod
http://code.google.com/p/pharo/issues/detail?id=3515

RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod

Comment #1 on issue 3515 by [hidden email]: Failing Test:  
RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod
http://code.google.com/p/pharo/issues/detail?id=3515

Error Message

implementorToInline
Stacktrace

Refactoring class(Object)>>error:
[:ref :imps | self error: #implementorToInline] in Refactoring  
class>>initializeRefactoringOptions
InlineMethodFromComponentRefactoring(Refactoring)>>requestImplementorToInline:
InlineMethodFromComponentRefactoring>>inlineClass
InlineMethodFromComponentRefactoring>>isOverridden
[self findSelectedMessage.
        self isOverridden
                ifTrue: [self
                                refactoringWarning: ('<1p>>><2s> is overriden. Do you want to inline it  
anyway?' expandMacrosWith: self inlineClass with: self inlineSelector)].
        self parseInlineMethod.
        self isPrimitive
                ifTrue: [self refactoringError: 'Cannot inline primitives'].
        self checkSuperMessages.
        self rewriteInlinedTree.
        (sourceMessage parent isReturn
                        or: [self hasMultipleReturns not])
                ifFalse: [self refactoringError: 'Cannot inline method since it contains  
multiple returns that cannot be rewritten'].
        true] in  
InlineMethodFromComponentRefactoring(InlineMethodRefactoring)>>preconditions
RBCondition>>check
RBConjunctiveCondition>>check
InlineMethodFromComponentRefactoring(Refactoring)>>checkPreconditions
InlineMethodFromComponentRefactoring(Refactoring)>>primitiveExecute
RBInlineMethodFromComponentTest(RBRefactoringBrowserTest)>>executeRefactoring:
[refactoring := InlineMethodFromComponentRefactoring
                                inline: (self
                                                convertInterval: (35 to: 91)
                                                for: (RBRefactoryTestDataApp sourceCodeAt: #inlineComponent))
                                inMethod: #inlineComponent
                                forClass: RBRefactoryTestDataApp.
        self setupInlineExpressionFor: refactoring toReturn: false.
        self executeRefactoring: refactoring] in  
RBInlineMethodFromComponentTest>>testInlineEmptyComponentMethod
BlockClosure>>on:do:
RBInlineMethodFromComponentTest(RBRefactoringBrowserTest)>>proceedThroughWarning:
RBInlineMethodFromComponentTest>>testInlineEmptyComponentMethod
RBInlineMethodFromComponentTest(TestCase)>>performTest

Updates:
        Status: FixProposed

Comment #2 on issue 3515 by [hidden email]: Failing Test:  
RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod
http://code.google.com/p/pharo/issues/detail?id=3515

In Inbox:  
SLICE-Issue-3515-Failing-Test-RBInlineMethodFromComponentTesttestInlineEmptyComponentMethod-LaurentLaffont.1

The problem is that the refactoring is supposed to ask which implementor to  
choose (as Mocketry implements yourself to).

So the test is changed to declare that we use the refactoring class named  
#Object (which is better I suppose)

Updates:
        Cc: renggli jorge.ressia

Comment #3 on issue 3515 by [hidden email]: Failing Test:  
RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod
http://code.google.com/p/pharo/issues/detail?id=3515

the fix is in Refactoring-Tests-Core. Can it be integrated in  
squeaksource.com/rb ?

Updates:
        Status: Closed

Comment #4 on issue 3515 by renggli: Failing Test:  
RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod
http://code.google.com/p/pharo/issues/detail?id=3515

This is integrated in Refactoring-Tests-Core-lr.51.